refactor: use filter_var to process node value

gowrizrh · gowrizrh · commit 2e98f9d81732 · 2021-08-18T18:42:34.000+09:30
diff --git a/app/code/Magento/Webapi/Model/Config/Converter.php b/app/code/Magento/Webapi/Model/Config/Converter.php
@@ -138,7 +138,7 @@ protected function convertMethodParameters($parameters)
             }
             $name = $parameter->attributes->getNamedItem('name')->nodeValue;
             $forceNode = $parameter->attributes->getNamedItem('force');
-            $force = $forceNode ? (bool)$forceNode->nodeValue : false;
+            $force = filter_var($forceNode->nodeValue, FILTER_VALIDATE_BOOLEAN);
             $value = $parameter->nodeValue;
             $data[$name] = [
                 self::KEY_FORCE => $force,

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ protected function convertMethodParameters($parameters)`
`138`	`138`	`}`
`139`	`139`	`$name = $parameter->attributes->getNamedItem('name')->nodeValue;`
`140`	`140`	`$forceNode = $parameter->attributes->getNamedItem('force');`
`141`		`- $force = $forceNode ? (bool)$forceNode->nodeValue : false;`
	`141`	`+ $force = filter_var($forceNode->nodeValue, FILTER_VALIDATE_BOOLEAN);`
`142`	`142`	`$value = $parameter->nodeValue;`
`143`	`143`	`$data[$name] = [`
`144`	`144`	`self::KEY_FORCE => $force,`