MAGETWO-8709: [GITHUB] Child product image should be shown in Wishist if options are selected for configurable product #8168

- removing object from composite
- removing un-necessary methods

Author: cpartica

app/code/Magento/Catalog/Model/Product/Configuration/Item/ItemResolverComposite.php

@@ -8,17 +8,18 @@
 namespace Magento\Catalog\Model\Product\Configuration\Item;
 
 use Magento\Catalog\Api\Data\ProductInterface;
+use Magento\Framework\App\ObjectManager;
 
 /**
  * {@inheritdoc}
  */
 class ItemResolverComposite implements ItemResolverInterface
 {
-    /** @var ItemResolverInterface[] */
+    /** @var string[] */
     private $itemResolvers = [];
 
     /**
-     * @param ItemResolverInterface[] $itemResolvers
+     * @param string[] $itemResolvers
      */
     public function __construct(array $itemResolvers)
     {
@@ -32,12 +33,23 @@ public function getFinalProduct(ItemInterface $item) : ProductInterface
     {
         $product = $item->getProduct();
         foreach ($this->itemResolvers as $resolver) {
-            $resolvedProduct = $resolver->getFinalProduct($item);
+            $resolvedProduct = $this->getItemResolverInstance($resolver)->getFinalProduct($item);
             if ($resolvedProduct !== $product) {
                 $product = $resolvedProduct;
                 break;
             }
         }
         return $product;
     }
+
+    /**
+     * Get the instance of the item resolver by class name
+     *
+     * @param string $className
+     * @return ItemResolverInterface
+     */
+    private function getItemResolverInstance(string $className)
+    {
+        return ObjectManager::getInstance()->get($className);
+    }
 }

app/code/Magento/ConfigurableProduct/Block/Cart/Item/Renderer/Configurable.php

@@ -57,16 +57,6 @@ public function getOptionList()
         return $this->_productConfig->getOptions($this->getItem());
     }
 
-    /**
-     * {@inheritdoc}
-     * @deprecated because now parent handles the logic for images of all product types
-     * @see \Magento\Checkout\Block\Cart\Item\Renderer::getProductForThumbnail
-     */
-    public function getProductForThumbnail()
-    {
-        return parent::getProductForThumbnail();
-    }
-
     /**
      * Return identifiers for produced content
      *

app/code/Magento/ConfigurableProduct/etc/di.xml

@@ -208,7 +208,7 @@
     <type name="Magento\Catalog\Model\Product\Configuration\Item\ItemResolverComposite">
         <arguments>
             <argument name="itemResolvers" xsi:type="array">
-                <item name="configurable" xsi:type="object">Magento\ConfigurableProduct\Model\Product\Configuration\Item\ItemProductResolver</item>
+                <item name="configurable" xsi:type="string">Magento\ConfigurableProduct\Model\Product\Configuration\Item\ItemProductResolver</item>
             </argument>
         </arguments>
     </type>

app/code/Magento/GroupedProduct/Block/Cart/Item/Renderer/Grouped.php

@@ -38,16 +38,6 @@ public function getGroupedProduct()
         return $this->getProduct();
     }
 
-    /**
-     * {@inheritdoc}
-     * @deprecated because now parent handles the logic for images of all product types
-     * @see \Magento\Checkout\Block\Cart\Item\Renderer::getProductForThumbnail
-     */
-    public function getProductForThumbnail()
-    {
-        return parent::getProductForThumbnail();
-    }
-
     /**
      * Return identifiers for produced content
      *

app/code/Magento/GroupedProduct/etc/di.xml

@@ -103,7 +103,7 @@
     <type name="Magento\Catalog\Model\Product\Configuration\Item\ItemResolverComposite">
         <arguments>
             <argument name="itemResolvers" xsi:type="array">
-                <item name="grouped" xsi:type="object">Magento\GroupedProduct\Model\Product\Configuration\Item\ItemProductResolver</item>
+                <item name="grouped" xsi:type="string">Magento\GroupedProduct\Model\Product\Configuration\Item\ItemProductResolver</item>
             </argument>
         </arguments>
     </type>