Skip to content

Commit 3413844

Browse files
rachanarachana
authored andcommitted
BUG#AC-6920:Updated Unit Testcase
1 parent 54433cd commit 3413844

File tree

2 files changed

+43
-27
lines changed

2 files changed

+43
-27
lines changed

app/code/Magento/QuoteGraphQl/Model/Resolver/MaskedCartId.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,22 @@ class MaskedCartId implements ResolverInterface
2727
/**
2828
* @var QuoteIdToMaskedQuoteIdInterface
2929
*/
30-
private $quoteIdToMaskedQuoteId;
30+
private QuoteIdToMaskedQuoteIdInterface $quoteIdToMaskedQuoteId;
3131

3232
/**
3333
* @var QuoteIdMaskFactory
3434
*/
35-
private $quoteIdMaskFactory;
35+
private QuoteIdMaskFactory $quoteIdMaskFactory;
3636

3737
/**
3838
* @var QuoteIdMaskResourceModel
3939
*/
40-
private $quoteIdMaskResourceModel;
40+
private QuoteIdMaskResourceModel $quoteIdMaskResourceModel;
4141

4242
/**
4343
* @param QuoteIdToMaskedQuoteIdInterface $quoteIdToMaskedQuoteId
44+
* @param QuoteIdMaskFactory $quoteIdMaskFactory
45+
* @param QuoteIdMaskResourceModel $quoteIdMaskResourceModel
4446
*/
4547
public function __construct(
4648
QuoteIdToMaskedQuoteIdInterface $quoteIdToMaskedQuoteId,
@@ -83,6 +85,7 @@ private function getQuoteMaskId(int $quoteId): string
8385
}
8486
return $maskedId;
8587
}
88+
8689
/**
8790
* Create masked id for quote if it's not exists
8891
*

app/code/Magento/QuoteGraphQl/Test/Unit/Model/Resolver/MaskedCartIdTest.php

Lines changed: 37 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
use Magento\Quote\Model\ResourceModel\Quote\QuoteIdMask as QuoteIdMaskResourceModel;
1717
use Magento\QuoteGraphQl\Model\Resolver\Cart;
1818
use Magento\QuoteGraphQl\Model\Resolver\MaskedCartId;
19+
use Magento\Sales\Model\ResourceModel\Order\Collection;
20+
use Magento\Sales\Model\ResourceModel\Order\CollectionFactory;
1921
use PHPUnit\Framework\MockObject\MockObject;
2022
use PHPUnit\Framework\TestCase;
2123

@@ -29,12 +31,12 @@ class MaskedCartIdTest extends TestCase
2931
/**
3032
* @var QuoteIdToMaskedQuoteIdInterface|MockObject
3133
*/
32-
private QuoteIdToMaskedQuoteIdInterface $quoteIdToMaskedQuoteIdMock;
34+
private QuoteIdToMaskedQuoteIdInterface $quoteIdToMaskedQuoteId;
3335

3436
/**
3537
* @var QuoteIdMaskFactory|MockObject
3638
*/
37-
private QuoteIdMaskFactory $quoteIdMaskFactoryMock;
39+
private QuoteIdMaskFactory $quoteIdMaskFactory;
3840

3941
/**
4042
* @var QuoteIdMaskResourceModel|MockObject
@@ -68,16 +70,23 @@ class MaskedCartIdTest extends TestCase
6870

6971
protected function setUp(): void
7072
{
71-
$this->quoteIdToMaskedQuoteIdMock = $this->createMock(QuoteIdToMaskedQuoteIdInterface::class);
72-
$this->quoteIdMaskFactoryMock = $this->createMock(QuoteIdMaskFactory::class);
73+
$this->quoteIdToMaskedQuoteId = $this->createPartialMock(
74+
QuoteIdToMaskedQuoteIdInterface::class,
75+
['execute']
76+
);
77+
$this->quoteIdMaskFactory = $this->createPartialMock(
78+
QuoteIdMaskFactory ::class,
79+
['create']
80+
);
81+
$this->quoteIdMaskFactory = $this->getMockBuilder(QuoteIdMaskFactory::class)
82+
->disableOriginalConstructor()
83+
->addMethods(['setQuoteId']
84+
)
85+
->getMock();
7386
$this->quoteIdMaskResourceModelMock = $this->createMock(QuoteIdMaskResourceModel::class);
7487
$this->fieldMock = $this->createMock(Field::class);
7588
$this->resolveInfoMock = $this->createMock(ResolveInfo::class);
7689
$this->contextMock = $this->createMock(Context::class);
77-
$this->cartMock = $this->getMockBuilder(Cart::class)
78-
->disableOriginalConstructor()
79-
->addMethods(['getId'])
80-
->getMock();
8190
$this->quoteIdMaskResourceModelMock = $this->getMockBuilder(QuoteIdMaskResourceModel::class)
8291
->disableOriginalConstructor()
8392
->addMethods(
@@ -87,12 +96,17 @@ protected function setUp(): void
8796
]
8897
)
8998
->getMock();
99+
$this->cartMock = $this->getMockBuilder(Cart::class)
100+
->disableOriginalConstructor()
101+
->addMethods(['setQuoteId','getId'])
102+
->getMock();
90103
$this->maskedCartId = new MaskedCartId(
91-
$this->quoteIdToMaskedQuoteIdMock,
92-
$this->quoteIdMaskFactoryMock,
104+
$this->quoteIdToMaskedQuoteId,
105+
$this->quoteIdMaskFactory,
93106
$this->quoteIdMaskResourceModelMock
94107
);
95108
}
109+
96110
public function testResolveWithoutModelInValueParameter(): void
97111
{
98112
$this->expectException(LocalizedException::class);
@@ -102,20 +116,19 @@ public function testResolveWithoutModelInValueParameter(): void
102116

103117
public function testResolve(): void
104118
{
105-
$this->valueMock = ['model' => $this->valueMock];
106-
$this->cartMock
107-
->expects($this->any())
108-
->method('getId');
109-
$this->quoteIdMaskResourceModelMock
110-
->expects($this->any())
111-
->method('getQuoteMaskId')
112-
->willReturn('maskedId');
113-
$this->quoteIdMaskResourceModelMock
119+
$this->valueMock = ['model' => $this->cartMock];
120+
$quoteIdMask = $this->createPartialMock(
121+
QuoteIdMaskResourceModel::class,
122+
['setQuoteId']
123+
);
124+
$this->quoteIdToMaskedQuoteId
114125
->expects($this->any())
115-
->method('ensureQuoteMaskExist')
116-
->willReturn('maskedId');
117-
126+
->method('execute');
127+
// echo get_class($this->quoteIdMaskFactory);die;
128+
// $this->quoteIdMaskFactory->setQuoteId('maskId');
129+
$this->quoteIdMaskFactory->expects($this->once())
130+
->method('create')
131+
->willReturn($quoteIdMask);
132+
$this->maskedCartId->resolve($this->fieldMock, $this->contextMock, $this->resolveInfoMock, $this->valueMock);
118133
}
119134
}
120-
121-

0 commit comments

Comments
 (0)