Allow use factories and OM for creating objects with variadic arguments in constructor

Author: adrian-martinez-interactiv4

lib/internal/Magento/Framework/Code/Reader/ClassReader.php

@@ -28,7 +28,8 @@ public function getConstructor($className)
                         $parameter->getName(),
                         $parameter->getClass() !== null ? $parameter->getClass()->getName() : null,
                         !$parameter->isOptional() && !$parameter->isDefaultValueAvailable(),
-                        $parameter->isDefaultValueAvailable() ? $parameter->getDefaultValue() : null,
+                        $this->getReflectionParameterDefaultValue($parameter),
+                        $parameter->isVariadic(),
                     ];
                 } catch (\ReflectionException $e) {
                     $message = $e->getMessage();
@@ -40,6 +41,19 @@ public function getConstructor($className)
         return $result;
     }
 
+    /**
+     * @param \ReflectionParameter $parameter
+     * @return array|mixed|null
+     */
+    private function getReflectionParameterDefaultValue(\ReflectionParameter $parameter)
+    {
+        if ($parameter->isVariadic()) {
+            return [];
+        }
+
+        return $parameter->isDefaultValueAvailable() ? $parameter->getDefaultValue() : null;
+    }
+
     /**
      * Retrieve parent relation information for type in a following format
      * array(

lib/internal/Magento/Framework/ObjectManager/Factory/AbstractFactory.php

@@ -226,7 +226,7 @@ protected function resolveArgumentsInRuntime($requestedType, array $parameters,
     {
         $resolvedArguments = [];
         foreach ($parameters as $parameter) {
-            list($paramName, $paramType, $paramRequired, $paramDefault) = $parameter;
+            list($paramName, $paramType, $paramRequired, $paramDefault, $isVariadic) = $parameter;
             $argument = null;
             if (!empty($arguments) && (isset($arguments[$paramName]) || array_key_exists($paramName, $arguments))) {
                 $argument = $arguments[$paramName];
@@ -243,9 +243,13 @@ protected function resolveArgumentsInRuntime($requestedType, array $parameters,
                 $argument = $paramDefault;
             }
 
-            $this->resolveArgument($argument, $paramType, $paramDefault, $paramName, $requestedType);
+            if ($isVariadic && is_array($argument)) {
+                $resolvedArguments = array_merge($resolvedArguments, $argument);
+            } else {
+                $this->resolveArgument($argument, $paramType, $paramDefault, $paramName, $requestedType);
+                $resolvedArguments[] = $argument;
+            }
 
-            $resolvedArguments[] = $argument;
         }
         return $resolvedArguments;
     }