#23279: Integration test for unsubscribing from 'Back in stock notification'

Added integration tests for ProductAlert\Controller\Unsubscribe\Stock and ProductAlert\Controller\Add\Stock

Author: yuriichayka

dev/tests/integration/testsuite/Magento/ProductAlert/Controller/Add/StockTest.php

@@ -7,6 +7,7 @@
 
 namespace Magento\ProductAlert\Controller\Add;
 
+use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Framework\App\ResourceConnection;
 use Magento\Framework\ObjectManagerInterface;
 use Magento\Framework\App\Action\Action;
@@ -20,6 +21,7 @@
  * Test for Magento\ProductAlert\Controller\Add\Stock class.
  *
  * @magentoAppIsolation enabled
+ * @magentoDbIsolation enabled
  */
 class StockTest extends AbstractController
 {
@@ -50,6 +52,11 @@ class StockTest extends AbstractController
      */
     protected $connectionMock;
 
+    /**
+     * @var ProductRepositoryInterface
+     */
+    private $productRepository;
+
     protected function setUp()
     {
         parent::setUp();
@@ -60,16 +67,17 @@ protected function setUp()
 
         $this->resource = $this->objectManager->get(ResourceConnection::class);
         $this->connectionMock = $this->resource->getConnection();
+        $this->productRepository = $this->objectManager->create(ProductRepositoryInterface::class);
     }
 
     /**
      * @magentoAppArea     frontend
      * @magentoDataFixture Magento/Catalog/_files/product_simple_out_of_stock.php
      * @magentoDataFixture Magento/Customer/_files/customer.php
      */
-    public function testSubscribe()
+    public function testSubscribeStockNotification()
     {
-        $productId = 1;
+        $productId = $this->productRepository->get('simple-out-of-stock')->getId();
         $customerId = 1;
 
         $this->customerSession->setCustomerId($customerId);
@@ -81,17 +89,17 @@ public function testSubscribe()
         $this->dispatch('productalert/add/stock');
 
         $select = $this->connectionMock->select()->from($this->resource->getTableName('product_alert_stock'))
-                                       ->where('`customer_id` LIKE ?', '1');
+                                       ->where('`product_id` LIKE ?', $productId);
         $result = $this->connectionMock->fetchAll($select);
         $this->assertCount(1, $result);
     }
 
     /**
-     * @param int $productId
+     * @param $productId
      *
      * @return string
      */
-    private function getUrlEncodedParameter(int $productId):string
+    private function getUrlEncodedParameter($productId):string
     {
         $baseUrl = $this->objectManager->get(StoreManagerInterface::class)->getStore()->getBaseUrl();
         $encodedParameterValue = urlencode(

dev/tests/integration/testsuite/Magento/ProductAlert/Controller/Unsubscribe/StockTest.php

@@ -7,9 +7,10 @@
 
 namespace Magento\ProductAlert\Controller\Unsubscribe;
 
+use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Framework\App\ResourceConnection;
+use Magento\Framework\DB\Adapter\AdapterInterface;
 use Magento\Framework\ObjectManagerInterface;
-use Magento\Framework\Url\Helper\Data;
 use Magento\Customer\Model\Session;
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\TestFramework\TestCase\AbstractController;
@@ -18,6 +19,7 @@
  * Test for Magento\ProductAlert\Controller\Unsubscribe\Stock class.
  *
  * @magentoAppIsolation enabled
+ * @magentoDbIsolation  enabled
  */
 class StockTest extends AbstractController
 {
@@ -39,17 +41,23 @@ class StockTest extends AbstractController
     /**
      * Connection adapter
      *
-     * @var \Magento\Framework\DB\Adapter\AdapterInterface
+     * @var AdapterInterface
      */
     protected $connectionMock;
 
+    /**
+     * @var ProductRepositoryInterface
+     */
+    private $productRepository;
+
     protected function setUp()
     {
         parent::setUp();
         $this->objectManager = Bootstrap::getObjectManager();
         $this->customerSession = $this->objectManager->get(Session::class);
         $this->resource = $this->objectManager->get(ResourceConnection::class);
         $this->connectionMock = $this->resource->getConnection();
+        $this->productRepository = $this->objectManager->create(ProductRepositoryInterface::class);
     }
 
     /**
@@ -58,18 +66,18 @@ protected function setUp()
      * @magentoDataFixture Magento/Customer/_files/customer.php
      * @magentoDataFixture Magento/ProductAlert/_files/customer_unsubscribe_stock.php
      */
-    public function testSubscribe()
+    public function testUnsubscribeStockNotification()
     {
-        $productId = 1;
         $customerId = 1;
+        $productId = $this->productRepository->get('simple-out-of-stock')->getId();
 
         $this->customerSession->setCustomerId($customerId);
-        $select = $this->connectionMock->select()->from($this->resource->getTableName('product_alert_stock'))
-                                       ->where('`customer_id` LIKE ?', $customerId);
 
         $this->getRequest()->setPostValue('product', $productId)->setMethod('POST');
         $this->dispatch('productalert/unsubscribe/stock');
 
+        $select = $this->connectionMock->select()->from($this->resource->getTableName('product_alert_stock'))
+                                       ->where('`product_id` LIKE ?', $productId);
         $result = $this->connectionMock->fetchAll($select);
         $this->assertCount(0, $result);
     }

dev/tests/integration/testsuite/Magento/ProductAlert/_files/customer_unsubscribe_stock.php

@@ -4,22 +4,25 @@
  * See COPYING.txt for license details.
  */
 
+use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Framework\Stdlib\DateTime\DateTimeFactory;
 use Magento\ProductAlert\Model\ResourceModel\Stock;
 use Magento\TestFramework\Helper\Bootstrap;
 
 $objectManager = Bootstrap::getObjectManager();
-$resource = $objectManager->create(Stock::class);
+$resource = $objectManager->get(Stock::class);
 
 /** @var \Magento\Framework\Stdlib\DateTime\DateTime $dateTime */
 $dateTime = $objectManager->get(DateTimeFactory::class)->create();
 $date = $dateTime->gmtDate(null, ($dateTime->gmtTimestamp() - 3600));
+$productRepository = $objectManager->create(ProductRepositoryInterface::class);
+$productId = $productRepository->get('simple-out-of-stock')->getId();
 
 $resource->getConnection()->insert(
     $resource->getMainTable(),
     [
         'customer_id' => 1,
-        'product_id' => 1,
+        'product_id' => $productId,
         'website_id' => 1,
         'store_id' => 1,
         'add_date' => $date,