MAGETWO-48192: More than 100 rows cannot be exported in Braintree Settlement Report

- Fixed tests

Author: Alexander Makeev

app/code/Magento/BraintreeTwo/Test/Unit/Model/Report/TransactionsCollectionTest.php

@@ -145,6 +145,39 @@ public function testGetItemsWithLimit()
             $this->braintreeAdapterMock,
             $this->filterMapperMock
         );
+        $collection->setPageSize(TransactionsCollection::TRANSACTION_MAXIMUM_COUNT);
+
+        $collection->addFieldToFilter('orderId', ['like' => '0']);
+        $items = $collection->getItems();
+        $this->assertEquals(TransactionsCollection::TRANSACTION_MAXIMUM_COUNT, count($items));
+        $this->assertInstanceOf(DocumentInterface::class, $items[1]);
+    }
+
+    /**
+     * Get items with limit
+     */
+    public function testGetItemsWithNullLimit()
+    {
+        $transations = range(1, TransactionsCollection::TRANSACTION_MAXIMUM_COUNT + 10);
+
+        $this->filterMapperMock->expects($this->once())
+            ->method('getFilter')
+            ->willReturn(new BraintreeSearchNodeStub());
+
+        $this->braintreeAdapterMock->expects($this->once())
+            ->method('search')
+            ->willReturn($transations);
+
+        $this->entityFactoryMock->expects($this->exactly(TransactionsCollection::TRANSACTION_MAXIMUM_COUNT))
+            ->method('create')
+            ->willReturn($this->transactionMapMock);
+
+        $collection = new TransactionsCollection(
+            $this->entityFactoryMock,
+            $this->braintreeAdapterMock,
+            $this->filterMapperMock
+        );
+        $collection->setPageSize(NULL);
 
         $collection->addFieldToFilter('orderId', ['like' => '0']);
         $items = $collection->getItems();

app/code/Magento/Ui/Test/Unit/Model/Export/ConvertToXmlTest.php

@@ -5,6 +5,7 @@
  */
 namespace Magento\Ui\Test\Unit\Model\Export;
 
+use Magento\Framework\Api\Search\DocumentInterface;
 use Magento\Framework\App\Filesystem\DirectoryList;
 use Magento\Framework\Convert\ExcelFactory;
 use Magento\Framework\Filesystem;
@@ -15,6 +16,10 @@
 use Magento\Ui\Model\Export\ConvertToXml;
 use Magento\Ui\Model\Export\MetadataProvider;
 use Magento\Ui\Model\Export\SearchResultIteratorFactory;
+use Magento\Framework\View\Element\UiComponent\ContextInterface;
+use Magento\Ui\Model\Export\SearchResultIterator;
+use Magento\Framework\Api\Search\SearchResultInterface;
+use Magento\Framework\View\Element\UiComponent\DataProvider\DataProviderInterface;
 
 class ConvertToXmlTest extends \PHPUnit_Framework_TestCase
 {
@@ -65,26 +70,26 @@ class ConvertToXmlTest extends \PHPUnit_Framework_TestCase
 
     public function setUp()
     {
-        $this->directory = $this->getMockBuilder('Magento\Framework\Filesystem\Directory\WriteInterface')
+        $this->directory = $this->getMockBuilder(DirectoryWriteInterface::class)
             ->getMockForAbstractClass();
 
-        $this->filesystem = $this->getMockBuilder('Magento\Framework\Filesystem')
+        $this->filesystem = $this->getMockBuilder(Filesystem::class)
             ->disableOriginalConstructor()
             ->getMock();
         $this->filesystem->expects($this->any())
             ->method('getDirectoryWrite')
             ->with(DirectoryList::VAR_DIR)
             ->willReturn($this->directory);
 
-        $this->filter = $this->getMockBuilder('Magento\Ui\Component\MassAction\Filter')
+        $this->filter = $this->getMockBuilder(Filter::class)
             ->disableOriginalConstructor()
             ->getMock();
 
-        $this->metadataProvider = $this->getMockBuilder('Magento\Ui\Model\Export\MetadataProvider')
+        $this->metadataProvider = $this->getMockBuilder(MetadataProvider::class)
             ->disableOriginalConstructor()
             ->getMock();
 
-        $this->excelFactory = $this->getMockBuilder('Magento\Framework\Convert\ExcelFactory')
+        $this->excelFactory = $this->getMockBuilder(ExcelFactory::class)
             ->disableOriginalConstructor()
             ->setMethods(['create'])
             ->getMock();
@@ -94,10 +99,10 @@ public function setUp()
             ->setMethods(['create'])
             ->getMock();
 
-        $this->component = $this->getMockBuilder('Magento\Framework\View\Element\UiComponentInterface')
+        $this->component = $this->getMockBuilder(UiComponentInterface::class)
             ->getMockForAbstractClass();
 
-        $this->stream = $this->getMockBuilder('Magento\Framework\Filesystem\File\WriteInterface')
+        $this->stream = $this->getMockBuilder(FileWriteInterface::class)
             ->setMethods([
                 'lock',
                 'unlock',
@@ -118,7 +123,8 @@ public function testGetRowData()
     {
         $data = ['data_value'];
 
-        $document = $this->getMockBuilder('Magento\Framework\Api\Search\DocumentInterface')
+        /** @var DocumentInterface $document */
+        $document = $this->getMockBuilder(DocumentInterface::class)
             ->getMockForAbstractClass();
 
         $this->metadataProvider->expects($this->once())
@@ -145,14 +151,15 @@ public function testGetXmlFile()
     {
         $componentName = 'component_name';
 
-        $document = $this->getMockBuilder('Magento\Framework\Api\Search\DocumentInterface')
+        /** @var DocumentInterface $document */
+        $document = $this->getMockBuilder(DocumentInterface::class)
             ->getMockForAbstractClass();
 
         $this->mockComponent($componentName, $document);
         $this->mockStream();
         $this->mockFilter();
         $this->mockDirectory();
-        $this->mockExcel($componentName);
+        $this->mockExcel($componentName, $document);
 
         $this->metadataProvider->expects($this->once())
             ->method('getHeaders')
@@ -186,10 +193,11 @@ protected function mockStream()
 
     /**
      * @param string $componentName
+     * @param DocumentInterface $document
      */
-    protected function mockExcel($componentName)
+    protected function mockExcel($componentName, DocumentInterface $document)
     {
-        $searchResultIterator = $this->getMockBuilder('Magento\Ui\Model\Export\SearchResultIterator')
+        $searchResultIterator = $this->getMockBuilder(SearchResultIterator::class)
             ->disableOriginalConstructor()
             ->getMock();
 
@@ -199,7 +207,7 @@ protected function mockExcel($componentName)
 
         $this->iteratorFactory->expects($this->once())
             ->method('create')
-            ->with(['items' => []])
+            ->with(['items' => [$document]])
             ->willReturn($searchResultIterator);
 
         $this->excelFactory->expects($this->once())
@@ -222,21 +230,19 @@ protected function mockExcel($componentName)
 
     /**
      * @param string $componentName
-     * @param null|object $document
+     * @param DocumentInterface|null $document
      */
-    protected function mockComponent($componentName, $document = null)
+    protected function mockComponent($componentName, DocumentInterface $document = null)
     {
-        $context = $this->getMockBuilder('Magento\Framework\View\Element\UiComponent\ContextInterface')
+        $context = $this->getMockBuilder(ContextInterface::class)
             ->setMethods(['getDataProvider'])
             ->getMockForAbstractClass();
 
-        $dataProvider = $this->getMockBuilder(
-            'Magento\Framework\View\Element\UiComponent\DataProvider\DataProviderInterface'
-        )
+        $dataProvider = $this->getMockBuilder(DataProviderInterface::class)
             ->setMethods(['getSearchResult', 'setLimit'])
             ->getMockForAbstractClass();
 
-        $searchResult = $this->getMockBuilder('Magento\Framework\Api\Search\SearchResultInterface')
+        $searchResult = $this->getMockBuilder(SearchResultInterface::class)
             ->setMethods(['getItems'])
             ->getMockForAbstractClass();
 
@@ -263,9 +269,6 @@ protected function mockComponent($componentName, $document = null)
             $searchResult->expects($this->at(0))
                 ->method('getItems')
                 ->willReturn([$document]);
-            $searchResult->expects($this->at(1))
-                ->method('getItems')
-                ->willReturn([]);
         } else {
             $searchResult->expects($this->at(0))
                 ->method('getItems')