MAGETWO-61095: When attempting to place a reorder after a product is disabled, product still gets added to the cart

Author: oserediuk

dev/tests/functional/tests/app/Magento/Sales/Test/Block/Order/History.php

@@ -43,6 +43,13 @@ class History extends Block
      */
     protected $viewButton = '.action.view';
 
+    /**
+     * 'Reorder' button css selector.
+     *
+     * @var string
+     */
+    protected $reorderButton = '.action.order';
+
     /**
      * Order history form selector.
      *
@@ -100,6 +107,18 @@ public function openOrderById($id)
         $this->searchOrderById($id)->find($this->viewButton)->click();
     }
 
+    /**
+     * Check if 'Reorder' button is visible for customer on order page
+     *
+     * @param string $id
+     * @return boolean
+     */
+    public function isReorderButtonPresentByOrderId($id)
+    {
+        $this->waitFormToLoad();
+        return $this->searchOrderById($id)->find($this->reorderButton)->isVisible();
+    }
+
     /**
      * Method that escapes currency symbols.
      *

dev/tests/functional/tests/app/Magento/Sales/Test/Constraint/AssertReorderButtonIsNotVisibleOnFrontend.php

@@ -0,0 +1,74 @@
+<?php
+/**
+ * Copyright © 2013-2017 Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Sales\Test\Constraint;
+
+use Magento\Customer\Test\Fixture\Customer;
+use Magento\Customer\Test\Page\CustomerAccountIndex;
+use Magento\Sales\Test\Fixture\OrderInjectable;
+use Magento\Sales\Test\Page\OrderHistory;
+use Magento\Mtf\Constraint\AbstractConstraint;
+use Magento\Mtf\ObjectManager;
+
+/**
+ * Assert that "Reorder" button is absent in Orders grid on frontend.
+ */
+class AssertReorderButtonIsNotVisibleOnFrontend extends AbstractConstraint
+{
+    /* tags */
+    const SEVERITY = 'low';
+    /* end tags */
+
+    /**
+     * Assert that "Reorder" button is absent in Orders grid on frontend.
+     *
+     * @param OrderInjectable $order
+     * @param Customer $customer
+     * @param ObjectManager $objectManager
+     * @param CustomerAccountIndex $customerAccountIndex
+     * @param OrderHistory $orderHistory
+     * @param string $status
+     * @param string $orderId
+     * @param string|null $statusToCheck
+     * @return void
+     */
+    public function processAssert(
+        OrderInjectable $order,
+        Customer $customer,
+        ObjectManager $objectManager,
+        CustomerAccountIndex $customerAccountIndex,
+        OrderHistory $orderHistory,
+        $status = null,
+        $orderId = '',
+        $statusToCheck = null
+    ) {
+        $filter = [
+            'id' => $order->hasData('id') ? $order->getId() : $orderId,
+            'status' => $statusToCheck === null ? $status : $statusToCheck,
+        ];
+
+        $objectManager->create(
+            \Magento\Customer\Test\TestStep\LoginCustomerOnFrontendStep::class,
+            ['customer' => $customer]
+        )->run();
+        $customerAccountIndex->getAccountMenuBlock()->openMenuItem('My Orders');
+        $errorMessage = implode(', ', $filter);
+        \PHPUnit_Framework_Assert::assertFalse(
+            $orderHistory->getOrderHistoryBlock()->isReorderButtonPresentByOrderId($filter['id']),
+            '"Reorder" button for order with following data \'' . $errorMessage . '\' is present in Orders block on frontend.'
+        );
+    }
+
+    /**
+     * Returns a string representation of the object.
+     *
+     * @return string
+     */
+    public function toString()
+    {
+        return '"Reorder" button is not present in orders on frontend.';
+    }
+}

dev/tests/functional/tests/app/Magento/Sales/Test/TestCase/CreateOrderBackendTest.xml

@@ -165,5 +165,21 @@
             <constraint name="Magento\Sales\Test\Constraint\AssertOrderGrandTotal" />
             <constraint name="Magento\Catalog\Test\Constraint\AssertProductsOutOfStock" />
         </variation>
+        <variation name="CreateOrderBackendTestVariation19" summary="'Reorder' button is not visible for customer if ordered item is out of stock" ticketId="MAGETWO-63924">
+            <data name="products/0" xsi:type="string">catalogProductSimple::default_qty_1</data>
+            <data name="customer/dataset" xsi:type="string">default</data>
+            <data name="billingAddress/dataset" xsi:type="string">US_address_1_without_email</data>
+            <data name="saveAddress" xsi:type="string">No</data>
+            <data name="shipping/shipping_service" xsi:type="string">Flat Rate</data>
+            <data name="shipping/shipping_method" xsi:type="string">Fixed</data>
+            <data name="prices" xsi:type="array">
+                <item name="grandTotal" xsi:type="string">565.00</item>
+            </data>
+            <data name="payment/method" xsi:type="string">cashondelivery</data>
+            <data name="configData" xsi:type="string">cashondelivery</data>
+            <constraint name="Magento\Sales\Test\Constraint\AssertOrderSuccessCreateMessage" />
+            <constraint name="Magento\Sales\Test\Constraint\AssertOrderGrandTotal" />
+            <constraint name="Magento\Sales\Test\Constraint\AssertReorderButtonIsNotVisibleOnFrontend" />
+        </variation>
     </testCase>
 </config>