MAGETWO-99838: Error message '"customer address attribute" is a required value.' is absent on Storefront

- Fixed bug
- Added unit test

Author: vital-pantsialeyeu

app/code/Magento/Eav/Model/Validator/Attribute/Data.php

@@ -4,15 +4,15 @@
  * See COPYING.txt for license details.
  */
 
+namespace Magento\Eav\Model\Validator\Attribute;
+
+use Magento\Eav\Model\Attribute;
+
 /**
  * EAV attribute data validator
  *
  * @author     Magento Core Team <[email protected]>
  */
-namespace Magento\Eav\Model\Validator\Attribute;
-
-use Magento\Eav\Model\Attribute;
-
 class Data extends \Magento\Framework\Validator\AbstractValidator
 {
     /**
@@ -126,7 +126,7 @@ public function isValid($entity)
             $dataModel = $this->_attrDataFactory->create($attribute, $entity);
             $dataModel->setExtractedData($data);
             if (!isset($data[$attributeCode])) {
-                $data[$attributeCode] = null;
+                $data[$attributeCode] = '';
             }
             $result = $dataModel->validateValue($data[$attributeCode]);
             if (true !== $result) {

app/code/Magento/Eav/Test/Unit/Model/Validator/Attribute/DataTest.php

@@ -4,13 +4,43 @@
  * See COPYING.txt for license details.
  */
 
+namespace Magento\Eav\Test\Unit\Model\Validator\Attribute;
+
 /**
  * Test for \Magento\Eav\Model\Validator\Attribute\Data
  */
-namespace Magento\Eav\Test\Unit\Model\Validator\Attribute;
-
 class DataTest extends \PHPUnit\Framework\TestCase
 {
+    /**
+     * @var \Magento\Eav\Model\AttributeDataFactory|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private $attrDataFactory;
+
+    /**
+     * @var \Magento\Eav\Model\Validator\Attribute\Data
+     */
+    private $model;
+
+    /**
+     * @inheritdoc
+     */
+    protected function setUp()
+    {
+        $this->attrDataFactory = $this->getMockBuilder(\Magento\Eav\Model\AttributeDataFactory::class)
+            ->setMethods(['create'])
+            ->setConstructorArgs(
+                [
+                    'objectManager' => $this->createMock(\Magento\Framework\ObjectManagerInterface::class),
+                    'string' => $this->createMock(\Magento\Framework\Stdlib\StringUtils::class)
+                ]
+            )
+            ->getMock();
+
+        $this->model = new \Magento\Eav\Model\Validator\Attribute\Data(
+            $this->attrDataFactory
+        );
+    }
+
     /**
      * Testing  \Magento\Eav\Model\Validator\Attribute\Data::isValid
      *
@@ -381,13 +411,15 @@ public function testAddErrorMessages()
     protected function _getAttributeMock($attributeData)
     {
         $attribute = $this->getMockBuilder(\Magento\Eav\Model\Attribute::class)
-            ->setMethods([
-                'getAttributeCode',
-                'getDataModel',
-                'getFrontendInput',
-                '__wakeup',
-                'getIsVisible',
-            ])
+            ->setMethods(
+                [
+                    'getAttributeCode',
+                    'getDataModel',
+                    'getFrontendInput',
+                    '__wakeup',
+                    'getIsVisible',
+                ]
+            )
             ->disableOriginalConstructor()
             ->getMock();
 
@@ -466,4 +498,35 @@ protected function _getEntityMock()
         )->disableOriginalConstructor()->getMock();
         return $entity;
     }
+
+    /**
+     * Test for isValid() without data for attribute.
+     *
+     * @return void
+     */
+    public function testIsValidWithoutData() : void
+    {
+        $attributeData = ['attribute_code' => 'attribute', 'frontend_input' => 'text', 'is_visible' => true];
+        $entity = $this->_getEntityMock();
+        $attribute = $this->_getAttributeMock($attributeData);
+        $this->model->setAttributes([$attribute])->setData([]);
+        $dataModel = $this->getMockBuilder(\Magento\Eav\Model\Attribute\Data\AbstractData::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['validateValue'])
+            ->getMockForAbstractClass();
+        $dataModel->expects($this->once())
+            ->method('validateValue')
+            // only empty string
+            ->with(
+                $this->logicalAnd(
+                    $this->isEmpty(),
+                    $this->isType('string')
+                )
+            )->willReturn(true);
+        $this->attrDataFactory->expects($this->once())
+            ->method('create')
+            ->with($attribute, $entity)
+            ->willReturn($dataModel);
+        $this->assertEquals(true, $this->model->isValid($entity));
+    }
 }