Skip to content

Commit 3d18a88

Browse files
committed
Merge remote-tracking branch 'origin/AC-14558-stomp-v2' into Platform_Health_ActiveMQ_Delivery
2 parents 1eb530e + 9698e3e commit 3d18a88

File tree

31 files changed

+136
-90
lines changed

31 files changed

+136
-90
lines changed

app/code/Magento/Amqp/Setup/ConfigOptionsList.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
*/
66
namespace Magento\Amqp\Setup;
77

8+
use Magento\Framework\App\DeploymentConfig;
89
use Magento\Framework\Config\Data\ConfigData;
910
use Magento\Framework\Config\File\ConfigFilePool;
1011
use Magento\Framework\Setup\ConfigOptionsListInterface;
1112
use Magento\Framework\Setup\Option\TextConfigOption;
12-
use Magento\Framework\App\DeploymentConfig;
1313

1414
/**
1515
* Deployment configuration options needed for Setup application

app/code/Magento/AsynchronousOperations/Model/MassConsumer.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99

1010
use Magento\Framework\App\ObjectManager;
1111
use Magento\Framework\MessageQueue\CallbackInvokerInterface;
12+
use Magento\Framework\MessageQueue\Consumer\ConfigInterface as ConsumerConfig;
1213
use Magento\Framework\MessageQueue\ConsumerConfigurationInterface;
1314
use Magento\Framework\MessageQueue\ConsumerInterface;
1415
use Magento\Framework\MessageQueue\EnvelopeInterface;
1516
use Magento\Framework\MessageQueue\QueueInterface;
1617
use Magento\Framework\Registry;
17-
use Magento\Framework\MessageQueue\Consumer\ConfigInterface as ConsumerConfig;
1818

1919
/**
2020
* Class Consumer used to process OperationInterface messages.
@@ -85,16 +85,12 @@ public function process($maxNumberOfMessages = null)
8585
if (!isset($maxNumberOfMessages)) {
8686
$queue->subscribe($this->getTransactionCallback($queue));
8787
} else {
88-
$connectionName = $this->consumerConfig
89-
->getConsumer($this->configuration->getConsumerName())
90-
->getConnection();
9188
$this->invoker->invoke(
9289
$queue,
9390
$maxNumberOfMessages,
9491
$this->getTransactionCallback($queue),
9592
$maxIdleTime,
96-
$sleep,
97-
$connectionName
93+
$sleep
9894
);
9995
}
10096

app/code/Magento/Stomp/Model/Bulk/Publisher.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@
88
namespace Magento\Stomp\Model\Bulk;
99

1010
use Magento\Framework\MessageQueue\Bulk\Queue\QueueRepository as BulkQueueRepository;
11-
use Magento\Framework\MessageQueue\QueueRepository;
1211
use Magento\Framework\MessageQueue\EnvelopeFactory;
13-
use Magento\Framework\MessageQueue\MessageIdGeneratorInterface;
14-
use Magento\Framework\MessageQueue\PublisherInterface;
1512
use Magento\Framework\MessageQueue\MessageEncoder;
13+
use Magento\Framework\MessageQueue\MessageIdGeneratorInterface;
1614
use Magento\Framework\MessageQueue\MessageValidator;
1715
use Magento\Framework\MessageQueue\Publisher\ConfigInterface as PublisherConfig;
16+
use Magento\Framework\MessageQueue\PublisherInterface;
17+
use Magento\Framework\MessageQueue\QueueRepository;
1818

1919
/**
2020
* A MessageQueue Publisher to handle publishing messages in bulk.

app/code/Magento/Stomp/Model/MassPublisher.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
declare(strict_types=1);
88
namespace Magento\Stomp\Model;
99

10-
use Magento\Framework\MessageQueue\MessageValidator;
10+
use Magento\AsynchronousOperations\Model\ConfigInterface as AsyncConfig;
11+
use Magento\Framework\MessageQueue\Bulk\Queue\QueueRepository as BulkQueueRepository;
12+
use Magento\Framework\MessageQueue\EnvelopeFactory;
1113
use Magento\Framework\MessageQueue\MessageEncoder;
14+
use Magento\Framework\MessageQueue\MessageIdGeneratorInterface;
15+
use Magento\Framework\MessageQueue\MessageValidator;
1216
use Magento\Framework\MessageQueue\Publisher\ConfigInterface as PublisherConfig;
13-
use Magento\Framework\MessageQueue\EnvelopeFactory;
14-
use Magento\AsynchronousOperations\Model\ConfigInterface as AsyncConfig;
1517
use Magento\Framework\MessageQueue\PublisherInterface;
16-
use Magento\Framework\MessageQueue\MessageIdGeneratorInterface;
17-
use Magento\Framework\MessageQueue\Bulk\Queue\QueueRepository as BulkQueueRepository;
1818
use Magento\Framework\MessageQueue\QueueRepository;
1919

2020
/**

app/code/Magento/Stomp/Model/Rpc/Publisher.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public function publish($topicName, $data)
111111
$publisher = $this->publisherConfig->getPublisher($topicName);
112112
$connectionName = $publisher->getConnection()->getName();
113113
$queue = $this->queueRepository->get($connectionName, $replyTo);
114-
$responseMessage = $queue->push($envelope);
114+
$responseMessage = $queue->callRpc($envelope);
115115
return $this->messageEncoder->decode($topicName, $responseMessage, false);
116116
}
117117
}

app/code/Magento/Stomp/Setup/ConfigOptionsList.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77

88
namespace Magento\Stomp\Setup;
99

10+
use Magento\Framework\App\DeploymentConfig;
1011
use Magento\Framework\Config\Data\ConfigData;
1112
use Magento\Framework\Config\File\ConfigFilePool;
1213
use Magento\Framework\Setup\ConfigOptionsListInterface;
1314
use Magento\Framework\Setup\Option\TextConfigOption;
14-
use Magento\Framework\App\DeploymentConfig;
1515

1616
/**
1717
* Deployment configuration options needed for Setup application

app/code/Magento/Stomp/Setup/Recurring.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77

88
namespace Magento\Stomp\Setup;
99

10-
use Magento\Framework\Stomp\TopologyInstaller;
1110
use Magento\Framework\Setup\InstallSchemaInterface;
1211
use Magento\Framework\Setup\ModuleContextInterface;
1312
use Magento\Framework\Setup\SchemaSetupInterface;
13+
use Magento\Framework\Stomp\TopologyInstaller;
1414

1515
/**
1616
* Class Recurring used for installing queues in ActiveMq

app/code/Magento/Stomp/Test/Unit/Setup/ConfigOptionsListTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77

88
namespace Magento\Stomp\Test\Unit\Setup;
99

10-
use Magento\Stomp\Setup\ConfigOptionsList;
11-
use Magento\Stomp\Setup\ConnectionValidator;
1210
use Magento\Framework\App\DeploymentConfig;
1311
use Magento\Framework\Config\Data\ConfigData;
1412
use Magento\Framework\Setup\Option\TextConfigOption;
1513
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
14+
use Magento\Stomp\Setup\ConfigOptionsList;
15+
use Magento\Stomp\Setup\ConnectionValidator;
1616
use PHPUnit\Framework\MockObject\MockObject;
1717
use PHPUnit\Framework\TestCase;
1818

dev/tests/integration/testsuite/Magento/Framework/MessageQueue/UseCase/DeprecatedFormat/AsyncMultiTopicsSeparateQueuesTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
namespace Magento\Framework\MessageQueue\UseCase\DeprecatedFormat;
77

88
use Magento\Framework\MessageQueue\DefaultValueProvider;
9-
use Magento\TestFramework\Helper\Bootstrap;
109
use Magento\Framework\MessageQueue\UseCase\QueueTestCaseAbstract;
10+
use Magento\TestFramework\Helper\Bootstrap;
1111
use Magento\TestModuleAsyncAmqp\Model\AsyncTestData;
1212

1313
class AsyncMultiTopicsSeparateQueuesTest extends QueueTestCaseAbstract

dev/tests/integration/testsuite/Magento/Framework/Stomp/TopologyTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
namespace Magento\Framework\Stomp;
1010

1111
use Magento\Framework\MessageQueue\DefaultValueProvider;
12-
use Magento\TestFramework\Helper\Stomp;
1312
use Magento\TestFramework\Helper\Bootstrap;
13+
use Magento\TestFramework\Helper\Stomp;
1414
use Magento\TestFramework\ObjectManager;
1515
use PHPUnit\Framework\TestCase;
1616

0 commit comments

Comments
 (0)