MC-19791: Poor performance on sales order update - string to integer

Oleksandr Iegorov · Oleksandr Iegorov · commit 3d1b4aad391a · 2019-09-09T16:50:30.000-05:00
diff --git a/lib/internal/Magento/Framework/Model/ResourceModel/Db/AbstractDb.php b/lib/internal/Magento/Framework/Model/ResourceModel/Db/AbstractDb.php
@@ -811,7 +811,6 @@ private function isNeedToQuoteValue(array $columnDescription): bool
      */
     protected function updateObject(\Magento\Framework\Model\AbstractModel $object)
     {
-        /** @var AdapterInterface $connection */
         $connection = $this->getConnection();
         $tableDescription = $connection->describeTable($this->getMainTable());
         $preparedValue = $connection->prepareColumnValue($tableDescription[$this->getIdFieldName()], $object->getId());

Original file line number	Diff line number	Diff line change
`@@ -811,7 +811,6 @@ private function isNeedToQuoteValue(array $columnDescription): bool`
`811`	`811`	`*/`
`812`	`812`	`protected function updateObject(\Magento\Framework\Model\AbstractModel $object)`
`813`	`813`	`{`
`814`		`- /** @var AdapterInterface $connection */`
`815`	`814`	`$connection = $this->getConnection();`
`816`	`815`	`$tableDescription = $connection->describeTable($this->getMainTable());`
`817`	`816`	`$preparedValue = $connection->prepareColumnValue($tableDescription[$this->getIdFieldName()], $object->getId());`