ACP2E-1120: extend new statuses that can apply for new placed order with free payment

Author: alzota

app/code/Magento/Payment/Model/Method/Free.php

@@ -139,9 +139,12 @@ public function getConfigPaymentAction()
     {
         $newStateStatuses = $this->config->getStateStatuses('new');
         $configNewOrderStatus = $this->getConfigData('order_status');
+        $paymentAction = parent::getConfigPaymentAction();
+
         return
-            $configNewOrderStatus == 'pending' ||
-            array_key_exists($configNewOrderStatus, $newStateStatuses) ?
-                null : parent::getConfigPaymentAction();
+            array_key_exists($configNewOrderStatus, $newStateStatuses) &&
+            $configNewOrderStatus != 'processing' &&
+            empty($paymentAction)
+                ? null : $paymentAction;
     }
 }

app/code/Magento/Payment/Test/Unit/Model/Method/FreeTest.php

@@ -105,7 +105,8 @@ public function testGetConfigPaymentAction($orderStatus, $paymentAction, $result
             ->willReturn($stateStatuses);
         $this->scopeConfig
             ->method('getValue')
-            ->willReturnOnConsecutiveCalls($orderStatus, $paymentAction);
+            ->withConsecutive(['payment/free/order_status'], ['payment/free/'.$paymentAction])
+            ->willReturnOnConsecutiveCalls($orderStatus, $result);
         $this->assertEquals($result, $this->methodFree->getConfigPaymentAction());
     }
 
@@ -164,10 +165,12 @@ public function getIsAvailableProvider(): array
     public function getConfigPaymentActionProvider(): array
     {
         return [
-            ['pending', 'action', null, ['pending' => 'Pending']],
-            ['new', 'action', null, ['pending' => 'Pending', 'new' => 'New']],
+            ['pending', 'payment_action', null, ['pending' => 'Pending']],
+            ['new', 'payment_action', null, ['pending' => 'Pending', 'new' => 'New']],
             ['new', 'payment_action', 'payment_action', ['pending' => 'Pending']],
-            ['processing', 'payment_action', 'payment_action', ['pending' => 'Pending']]
+            ['processing', 'payment_action', 'payment_action', ['pending' => 'Pending']],
+            ['processing', 'payment_action', null, ['pending' => 'Pending', 'processing' => 'Processing']],
+            ['processing', 'payment_action', 'payment_action', ['pending' => 'Pending', 'processing' => 'Processing']]
         ];
     }
 }