MC-20636: Order Details : Order Details by Order Number

- fix static

Author: cpartica

app/code/Magento/SalesGraphQl/Model/Resolver/InvoiceItems.php

@@ -55,11 +55,11 @@ public function resolve(
         array $value = null,
         array $args = null
     ) {
-        if (!($value['model'] ?? null) instanceof InvoiceInterface)  {
+        if (!(($value['model'] ?? null) instanceof InvoiceInterface)) {
             throw new LocalizedException(__('"model" value should be specified'));
         }
 
-        if (!($value['order'] ?? null) instanceof OrderInterface)  {
+        if (!(($value['order'] ?? null) instanceof OrderInterface)) {
             throw new LocalizedException(__('"order" value should be specified'));
         }
 

app/code/Magento/SalesGraphQl/Model/Resolver/Invoices.php

@@ -29,7 +29,7 @@ public function resolve(
         array $value = null,
         array $args = null
     ) {
-        if (!($value['model'] ?? null) instanceof OrderInterface)  {
+        if (!(($value['model'] ?? null) instanceof OrderInterface)) {
             throw new LocalizedException(__('"model" value should be specified'));
         }
 

app/code/Magento/SalesGraphQl/Model/Resolver/OrderItems.php

@@ -53,7 +53,7 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         if (false === $context->getExtensionAttributes()->getIsCustomer()) {
             throw new GraphQlAuthorizationException(__('The current customer isn\'t authorized.'));
         }
-        if (!($value['model'] ?? null) instanceof OrderInterface)  {
+        if (!(($value['model'] ?? null) instanceof OrderInterface)) {
             throw new LocalizedException(__('"model" value should be specified'));
         }
         /** @var OrderInterface $parentOrder */

app/code/Magento/SalesGraphQl/Model/Resolver/OrderTotal.php

@@ -25,7 +25,7 @@ public function resolve(
         array $value = null,
         array $args = null
     ) {
-        if (!($value['model'] ?? null) instanceof OrderInterface)  {
+        if (!(($value['model'] ?? null) instanceof OrderInterface)) {
             throw new LocalizedException(__('"model" value should be specified'));
         }
 

dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/RetrieveOrdersByOrderNumberTest.php

@@ -112,7 +112,7 @@ public function testGetCustomerOrdersSimpleProductQuery()
         /** @var \Magento\Sales\Api\Data\OrderInterface[] $items */
         $orders = $this->orderRepository->getList($searchCriteria)->getItems();
         foreach ($orders as $order) {
-            $orderId = $order->getEntityId();
+            $orderId = base64_encode($order->getEntityId());
             $orderNumber = $order->getIncrementId();
             $this->assertEquals($orderId, $customerOrderItemsInResponse['id']);
             $this->assertEquals($orderNumber, $customerOrderItemsInResponse['number']);
@@ -819,8 +819,7 @@ public function testGetCustomerOrdersTwoStoreViewQuery(string $orderNumber, stri
             [],
             '',
             array_merge(
-                $this->customerAuthenticationHeader->execute(
-                $currentEmail, $currentPassword),
+                $this->customerAuthenticationHeader->execute($currentEmail, $currentPassword),
                 ['Store' => $store]
             )
         );

dev/tests/integration/testsuite/Magento/Sales/_files/orders_with_customer.php

@@ -120,4 +120,3 @@
 
     $orderRepository->save($order);
 }
-