AC-6714: Fixed static and unit test failures

Author: faizan-shk

app/code/Magento/Elasticsearch8/Model/Adapter/Elasticsearch.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Elasticsearch8\Model\Adapter;
 

app/code/Magento/Elasticsearch8/Model/Client/Elasticsearch.php

@@ -292,6 +292,7 @@ public function getAlias(string $alias): array
      * @param string $index
      * @param string $entityType
      * @return void
+     * @SuppressWarnings("unused")
      */
     public function addFieldsMapping(array $fields, string $index, string $entityType)
     {

app/code/Magento/Elasticsearch8/Test/Unit/Model/Client/ElasticsearchTest.php

@@ -26,6 +26,8 @@
 
 /**
  * Class ElasticsearchTest to test Elasticsearch 8
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ElasticsearchTest extends TestCase
 {

composer.json

@@ -170,6 +170,7 @@
         "magento/module-open-search": "*",
         "magento/module-elasticsearch": "*",
         "magento/module-elasticsearch-7": "*",
+        "magento/module-elasticsearch-8": "*",
         "magento/module-email": "*",
         "magento/module-encryption-key": "*",
         "magento/module-fedex": "*",

composer.lock

@@ -8,6 +8,7 @@
 return [
     'Magento\Elasticsearch' => [
         'Magento\Elasticsearch7',
+        'Magento\Elasticsearch8',
         'Magento\OpenSearch'
     ]
 ];

dev/tests/static/testsuite/Magento/Test/Integrity/_files/extension_dependencies_test/allowed_dependencies/ce.php

@@ -11,6 +11,7 @@
     'Magento\LiveSearch' => [
         'Magento\Elasticsearch',
         'Magento\Elasticsearch7',
+        'Magento\Elasticsearch8',
         'Magento\OpenSearch'
     ],
 ];

dev/tests/static/testsuite/Magento/Test/Integrity/_files/extension_dependencies_test/extension_conflicts/ce.php

@@ -36,9 +36,10 @@ public function testGetOptionsList()
         $this->assertEquals('search-engine', $optionsList[0]->getName());
 
         $selectOptions = $optionsList[0]->getSelectOptions();
-        $this->assertCount(3, $selectOptions);
+        $this->assertCount(4, $selectOptions);
         $this->assertContains('elasticsearch5', $selectOptions);
         $this->assertContains('elasticsearch7', $selectOptions);
+        $this->assertContains('elasticsearch8', $selectOptions);
         $this->assertContains('opensearch', $selectOptions);
 
         $this->assertArrayHasKey(1, $optionsList);