ENGCOM-5228: #23053 : sendfriend verifies product visibility instead of status #23118

Author: sidolov

app/code/Magento/SendFriend/Controller/Product.php

@@ -61,6 +61,7 @@ public function __construct(
 
     /**
      * Check if module is enabled
+     *
      * If allow only for customer - redirect to login page
      *
      * @param RequestInterface $request
@@ -102,7 +103,7 @@ protected function _initProduct()
         }
         try {
             $product = $this->productRepository->getById($productId);
-            if (!$product->isVisibleInCatalog()) {
+            if (!$product->isVisibleInSiteVisibility() || !$product->isVisibleInCatalog()) {
                 return false;
             }
         } catch (NoSuchEntityException $noEntityException) {

dev/tests/integration/testsuite/Magento/SendFriend/Controller/SendmailTest.php

@@ -85,6 +85,24 @@ public function testSendActionAsGuestWithInvalidData()
         );
     }
 
+    /**
+     * Share the product invisible in catalog to friend as guest customer
+     *
+     * @magentoDbIsolation enabled
+     * @magentoAppIsolation enabled
+     * @magentoConfigFixture default_store sendfriend/email/enabled 1
+     * @magentoConfigFixture default_store sendfriend/email/allow_guest 1
+     * @magentoDataFixture Magento/Catalog/_files/simple_products_not_visible_individually.php
+     */
+    public function testSendInvisibleProduct()
+    {
+        $product = $this->getInvisibleProduct();
+        $this->prepareRequestData();
+
+        $this->dispatch('sendfriend/product/sendmail/id/' . $product->getId());
+        $this->assert404NotFound();
+    }
+
     /**
      * @return ProductInterface
      */
@@ -93,6 +111,14 @@ private function getProduct()
         return $this->_objectManager->get(ProductRepositoryInterface::class)->get('custom-design-simple-product');
     }
 
+    /**
+     * @return ProductInterface
+     */
+    private function getInvisibleProduct()
+    {
+        return $this->_objectManager->get(ProductRepositoryInterface::class)->get('simple_not_visible_1');
+    }
+
     /**
      * Login the user
      *