Skip to content

Commit 4065313

Browse files
author
Hwashiang Yu
committed
MAGETWO-55808: Eliminate @escapeNotVerified in Product Modules
- Resolved static failure from unescaped content
1 parent 042081e commit 4065313

File tree

10 files changed

+30
-30
lines changed

10 files changed

+30
-30
lines changed

‎app/code/Magento/Bundle/view/adminhtml/templates/sales/creditmemo/create/items/renderer.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,9 +190,9 @@
190190
<script>
191191
require(['prototype'], function(){
192192
<?php $escapedId = $block->escapeJs($_id) ?>
193-
$('<?= $escapedId ?>').hide();
194-
$('<?= $escapedId ?>').up().observe('mouseover', function(){$('<?= $escapedId ?>').show();});
195-
$('<?= $escapedId ?>').up().observe('mouseout', function(){$('<?= $escapedId ?>').hide();});
193+
$('<?= /* @noEscape */ $escapedId ?>').hide();
194+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseover', function(){$('<?= /* @noEscape */ $escapedId ?>').show();});
195+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseout', function(){$('<?= /* @noEscape */ $escapedId ?>').hide();});
196196
});
197197
</script>
198198
<?php endif;?>

‎app/code/Magento/Bundle/view/adminhtml/templates/sales/creditmemo/view/items/renderer.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,9 @@
117117
<script>
118118
require(['prototype'], function(){
119119
<?php $escapedId = $block->escapeJs($_id) ?>
120-
$('<?= $escapedId ?>').hide();
121-
$('<?= $escapedId ?>').up().observe('mouseover', function(){$('<?= $escapedId ?>').show();});
122-
$('<?= $escapedId ?>').up().observe('mouseout', function(){$('<?= $escapedId ?>').hide();});
120+
$('<?= /* @noEscape */ $escapedId ?>').hide();
121+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseover', function(){$('<?= /* @noEscape */ $escapedId ?>').show();});
122+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseout', function(){$('<?= /* @noEscape */ $escapedId ?>').hide();});
123123
});
124124
</script>
125125
<?php endif;?>

‎app/code/Magento/Bundle/view/adminhtml/templates/sales/invoice/create/items/renderer.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,9 +185,9 @@
185185
<script>
186186
require(['prototype'], function(){
187187
<?php $escapedId = $block->escapeJs($_id) ?>
188-
$('<?= $escapedId ?>').hide();
189-
$('<?= $escapedId ?>').up().observe('mouseover', function(){$('<?= $escapedId?>').show();});
190-
$('<?= $escapedId ?>').up().observe('mouseout', function(){$('<?= $escapedId ?>').hide();});
188+
$('<?= /* @noEscape */ $escapedId ?>').hide();
189+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseover', function(){$('<?= $escapedId?>').show();});
190+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseout', function(){$('<?= /* @noEscape */ $escapedId ?>').hide();});
191191

192192
});
193193
</script>

‎app/code/Magento/Bundle/view/adminhtml/templates/sales/invoice/view/items/renderer.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@
118118
<script>
119119
require(['prototype'], function(){
120120
<?php $escapedId = $block->escapeJs($_id) ?>
121-
$('<?= $escapedId ?>').hide();
122-
$('<?= $escapedId ?>').up().observe('mouseover', function(){$('<?= $escapedId ?>').show();});
123-
$('<?= $escapedId ?>').up().observe('mouseout', function(){$('<?= $escapedId ?>').hide();});
121+
$('<?= /* @noEscape */ $escapedId ?>').hide();
122+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseover', function(){$('<?= /* @noEscape */ $escapedId ?>').show();});
123+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseout', function(){$('<?= /* @noEscape */ $escapedId ?>').hide();});
124124
});
125125
</script>
126126
<?php endif;?>

‎app/code/Magento/Bundle/view/adminhtml/templates/sales/order/view/items/renderer.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,9 @@
187187
<script>
188188
require(['prototype'], function(){
189189
<?php $escapedId = $block->escapeJs($_id) ?>
190-
$('<?= $escapedId ?>').hide();
191-
$('<?= $escapedId ?>').up().observe('mouseover', function(){$('<?= $escapedId ?>').show();});
192-
$('<?= $escapedId ?>').up().observe('mouseout', function(){$('<?= $escapedId ?>').hide();});
190+
$('<?= /* @noEscape */ $escapedId ?>').hide();
191+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseover', function(){$('<?= /* @noEscape */ $escapedId ?>').show();});
192+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseout', function(){$('<?= /* @noEscape */ $escapedId ?>').hide();});
193193
});
194194
</script>
195195
<?php endif;?>

‎app/code/Magento/Bundle/view/adminhtml/templates/sales/shipment/create/items/renderer.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@
8484
<script>
8585
require(['prototype'], function(){
8686
<?php $escapedId = $block->escapeJs($_id) ?>
87-
$('<?= $escapedId ?>').hide();
88-
$('<?= $escapedId ?>').up().observe('mouseover', function(){$('<?= $escapedId ?>').show();});
89-
$('<?= $escapedId ?>').up().observe('mouseout', function(){$('<?= $escapedId ?>').hide();});
87+
$('<?= /* @noEscape */ $escapedId ?>').hide();
88+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseover', function(){$('<?= /* @noEscape */ $escapedId ?>').show();});
89+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseout', function(){$('<?= /* @noEscape */ $escapedId ?>').hide();});
9090
});
9191
</script>
9292
<?php endif;?>

‎app/code/Magento/Bundle/view/adminhtml/templates/sales/shipment/view/items/renderer.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,9 @@
7979
<script>
8080
require(['prototype'], function(){
8181
<?php $escapedId = $block->escapeJs($_id) ?>
82-
$('<?= $escapedId ?>').hide();
83-
$('<?= $escapedId ?>').up().observe('mouseover', function(){$('<?= $escapedId ?>').show();});
84-
$('<?= $escapedId ?>').up().observe('mouseout', function(){$('<?= $escapedId ?>').hide();});
82+
$('<?= /* @noEscape */ $escapedId ?>').hide();
83+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseover', function(){$('<?= /* @noEscape */ $escapedId ?>').show();});
84+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseout', function(){$('<?= /* @noEscape */ $escapedId ?>').hide();});
8585
});
8686
</script>
8787
<?php endif;?>

‎app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/creditmemo/name.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525
<script>
2626
require(['prototype'], function(){
2727
<?php $escapedId = $block->escapeJs($_id) ?>
28-
$('<?= $escapedId ?>').hide();
29-
$('<?= $escapedId ?>').up().observe('mouseover', function(){$('<?= $escapedId ?>').show();});
30-
$('<?= $escapedId ?>').up().observe('mouseout', function(){$('<?= $escapedId ?>').hide();});
28+
$('<?= /* @noEscape */ $escapedId ?>').hide();
29+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseover', function(){$('<?= /* @noEscape */ $escapedId ?>').show();});
30+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseout', function(){$('<?= /* @noEscape */ $escapedId ?>').hide();});
3131

3232
});
3333
</script>

‎app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/invoice/name.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525
<script>
2626
require(['prototype'], function(){
2727
<?php $escapedId = $block->escapeJs($_id) ?>
28-
$('<?= $escapedId ?>').hide();
29-
$('<?= $escapedId ?>').up().observe('mouseover', function(){$('<?= $escapedId ?>').show();});
30-
$('<?= $escapedId ?>').up().observe('mouseout', function(){$('<?= $escapedId ?>').hide();});
28+
$('<?= /* @noEscape */ $escapedId ?>').hide();
29+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseover', function(){$('<?= /* @noEscape */ $escapedId ?>').show();});
30+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseout', function(){$('<?= /* @noEscape */ $escapedId ?>').hide();});
3131
});
3232
</script>
3333
<?php endif;?>

‎app/code/Magento/Downloadable/view/adminhtml/templates/sales/items/column/downloadable/name.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@
2828
<script>
2929
require(['prototype'], function(){
3030
<?php $escapedId = $block->escapeJs($_id) ?>
31-
$('<?= $escapedId ?>').hide();
32-
$('<?= $escapedId ?>').up().observe('mouseover', function(){$('<?= $escapedId ?>').show();});
33-
$('<?= $escapedId ?>').up().observe('mouseout', function(){$('<?= $escapedId ?>').hide();});
31+
$('<?= /* @noEscape */ $escapedId ?>').hide();
32+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseover', function(){$('<?= /* @noEscape */ $escapedId ?>').show();});
33+
$('<?= /* @noEscape */ $escapedId ?>').up().observe('mouseout', function(){$('<?= /* @noEscape */ $escapedId ?>').hide();});
3434
});
3535
</script>
3636
<?php endif;?>

0 commit comments

Comments
 (0)