Skip to content

Commit 40a7570

Browse files
Accessibility: WAI-ARIA roles nesting wrong in menu
1 parent ef6d9c8 commit 40a7570

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

app/code/Magento/Theme/Block/Html/Topmenu.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ protected function _getHtml(
246246
}
247247

248248
$html .= '<li ' . $this->_getRenderedMenuItemAttributes($child) . '>';
249-
$html .= '<a href="' . $child->getUrl() . '" ' . $outermostClassCode . '><span>' . $this->escapeHtml(
249+
$html .= '<a href="' . $child->getUrl() . '" ' . $outermostClassCode . ' role="menuitem"><span>' . $this->escapeHtml(
250250
$child->getName()
251251
) . '</span></a>' . $this->_addSubMenu(
252252
$child,
@@ -288,7 +288,10 @@ protected function _getRenderedMenuItemAttributes(Node $item)
288288
*/
289289
protected function _getMenuItemAttributes(Node $item)
290290
{
291-
return ['class' => implode(' ', $this->_getMenuItemClasses($item))];
291+
return [
292+
'class' => implode(' ', $this->_getMenuItemClasses($item)),
293+
'role' => 'presentation'
294+
];
292295
}
293296

294297
/**

app/code/Magento/Theme/view/frontend/templates/html/sections.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ $groupCss = $block->getGroupCss();
3434
</div>
3535
<div class="section-item-content <?= $block->escapeHtmlAttr($groupCss) ?>-item-content"
3636
id="<?= $block->escapeHtmlAttr($alias) ?>"
37-
data-role="content">
37+
role="tab">
3838
<?= /* @noEscape */ $html ?>
3939
</div>
4040
<?php endforeach;?>

0 commit comments

Comments
 (0)