Skip to content

Commit 4129100

Browse files
author
Hwashiang Yu
committed
MAGETWO-56444: UI-Related Modules Template Update
- Resolved static test failures - Resolved Magento function failures due to templaet updates
1 parent 5fae450 commit 4129100

File tree

27 files changed

+138
-53
lines changed

27 files changed

+138
-53
lines changed

app/code/Magento/Theme/view/adminhtml/templates/browser/content/files.phtml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6-
?>
76

8-
<?php
7+
// @codingStandardsIgnoreFile
8+
99
/** @var $block \Magento\Theme\Block\Adminhtml\Wysiwyg\Files\Content\Files */
1010
?>
1111

@@ -15,7 +15,8 @@
1515
<p class="nm">
1616
<?= $block->escapeHtml($file['text']) ?>
1717
<?php if (isset($file['thumbnailParams'])): ?>
18-
<img src="<?= $block->escapeUrl($block->getUrl('*/*/previewImage', $file['thumbnailParams'])) ?>" alt="<?= $block->escapeHtmlAttr(__('thumbnail')) ?>">
18+
<img src="<?= $block->escapeUrl($block->getUrl('*/*/previewImage', $file['thumbnailParams'])) ?>"
19+
alt="<?= $block->escapeHtmlAttr(__('thumbnail')) ?>">
1920
<?php endif; ?>
2021
</p>
2122
</div>

app/code/Magento/Theme/view/adminhtml/templates/tabs/fieldset/js.phtml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
* See COPYING.txt for license details.
55
*/
66

7+
// @codingStandardsIgnoreFile
8+
79
/** @var $block \Magento\Backend\Block\Widget\Form\Renderer\Fieldset */
810
?>
911

@@ -59,7 +61,9 @@ jQuery(function($) {
5961
});
6062
$('body').trigger(
6163
'refreshJsList',
62-
{jsList: <?= $block->escapeJs($this->helper('Magento\Framework\Json\Helper\Data')->jsonEncode($block->getJsFiles())) ?>}
64+
{
65+
jsList: <?= $block->escapeJs($this->helper('Magento\Framework\Json\Helper\Data')->jsonEncode($block->getJsFiles())) ?>
66+
}
6367
);
6468
});
6569

app/code/Magento/Theme/view/adminhtml/templates/title.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
/**
88
* @var $block \Magento\Theme\Block\Html\Title
99
*/
10-
$titleId = ($block->getTitleId()) ? ' id="' . $block->getTitleId() . '"' : '';
10+
$titleIdHtml = ($block->getTitleId()) ? ' id="' . $block->escapeHtmlAttr($block->getTitleId()) . '"' : '';
1111
$titleClass = ($block->getTitleClass()) ? ' ' . $block->getTitleClass() : '';
1212
$title = $block->getPageTitle();
1313
?>
1414

1515
<div class="page-title-wrapper<?= $block->escapeHtmlAttr($titleClass) ?>">
16-
<h1 class="page-title"<?= $block->escapeHtmlAttr($titleId) ?>><?= $block->escapeHtml($title) ?></h1>
16+
<h1 class="page-title"<?= /* @noEscape */ $titleIdHtml ?>><?= $block->escapeHtml($title) ?></h1>
1717
<?= $block->getChildHtml() ?>
1818
</div>

app/code/Magento/Theme/view/base/templates/root.phtml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
<?= /* @noEscape */ $headContent ?>
1313
<?= /* @noEscape */ $headAdditional ?>
1414
</head>
15-
<body data-container="body" data-mage-init='{"loaderAjax": {}, "loader": { "icon": "<?= /* @noEscape */ $loaderIcon ?>"}}' <?= /* @noEscape */ $bodyAttributes ?>>
15+
<body data-container="body"
16+
data-mage-init='{"loaderAjax": {}, "loader": { "icon": "<?= /* @noEscape */ $loaderIcon ?>"}}'
17+
<?= /* @noEscape */ $bodyAttributes ?>>
1618
<?= /* @noEscape */ $layoutContent ?>
1719
</body>
1820
</html>

app/code/Magento/Theme/view/frontend/templates/callouts/left_col.phtml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,23 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
7+
// @codingStandardsIgnoreFile
68
?>
79
<div class="block block-banner">
810
<div class="block-content">
911
<?php if (strtolower(substr($block->getLinkUrl(), 0, 4)) === 'http'): ?>
10-
<a href="<?= $block->escapeUrl($block->getLinkUrl()) ?>" title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>">
12+
<a href="<?= $block->escapeUrl($block->getLinkUrl()) ?>"
13+
title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>">
1114
<?php elseif ($block->getLinkUrl()): ?>
12-
<a href="<?= $block->escapeUrl($block->getUrl($block->getLinkUrl())) ?>" title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>">
15+
<a href="<?= $block->escapeUrl($block->getUrl($block->getLinkUrl())) ?>"
16+
title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>">
1317
<?php endif; ?>
14-
<img src="<?= $block->escapeUrl($block->getViewFileUrl($block->getImgSrc())) ?>"<?php if (!$block->getLinkUrl()): ?> title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>"<?php endif; ?> alt="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>" />
18+
<img src="<?= $block->escapeUrl($block->getViewFileUrl($block->getImgSrc())) ?>"
19+
<?php if (!$block->getLinkUrl()): ?>
20+
title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>"
21+
<?php endif; ?>
22+
alt="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>" />
1523
<?php if ($block->getLinkUrl()): ?>
1624
</a>
1725
<?php endif ?>

app/code/Magento/Theme/view/frontend/templates/callouts/right_col.phtml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,23 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
7+
// @codingStandardsIgnoreFile
68
?>
79
<div class="block block-banner">
810
<div class="block-content">
911
<?php if (strtolower(substr($block->getLinkUrl(), 0, 4)) === 'http'): ?>
10-
<a href="<?= $block->escapeUrl($block->getLinkUrl()) ?>" title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>">
12+
<a href="<?= $block->escapeUrl($block->getLinkUrl()) ?>"
13+
title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>">
1114
<?php elseif ($block->getLinkUrl()): ?>
12-
<a href="<?= $block->escapeUrl($block->getUrl($block->getLinkUrl())) ?>" title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>">
15+
<a href="<?= $block->escapeUrl($block->getUrl($block->getLinkUrl())) ?>"
16+
title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>">
1317
<?php endif; ?>
14-
<img src="<?= $block->escapeUrl($block->getViewFileUrl($block->getImgSrc())) ?>"<?php if (!$block->getLinkUrl()): ?> title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>"<?php endif; ?> alt="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>" />
18+
<img src="<?= $block->escapeUrl($block->getViewFileUrl($block->getImgSrc())) ?>"
19+
<?php if (!$block->getLinkUrl()): ?>
20+
title="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>"
21+
<?php endif; ?>
22+
alt="<?= $block->escapeHtmlAttr(__($block->getImgAlt())) ?>" />
1523
<?php if ($block->getLinkUrl()): ?>
1624
</a>
1725
<?php endif ?>

app/code/Magento/Theme/view/frontend/templates/html/absolute_footer.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
* See COPYING.txt for license details.
55
*/
66
?>
7-
<?= $block->getMiscellaneousHtml() ?>
7+
<?= $block->getMiscellaneousHtml();

app/code/Magento/Theme/view/frontend/templates/html/block.phtml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
*/
66
?>
77
<div class="block <?= $block->escapeHtmlAttr($block->getBlockCss()) ?>">
8-
<div class="block-title <?= $block->escapeHtmlAttr($block->getBlockCss()) ?>-title"><strong><?= $block->escapeHtml($block->getBlockTitle()) ?></strong></div>
8+
<div class="block-title <?= $block->escapeHtmlAttr($block->getBlockCss()) ?>-title">
9+
<strong><?= $block->escapeHtml($block->getBlockTitle()) ?></strong>
10+
</div>
911
<div class="block-content <?= $block->escapeHtmlAttr($block->getBlockCss()) ?>-content">
1012
<?= $block->getChildHtml() ?>
1113
</div>

app/code/Magento/Theme/view/frontend/templates/html/breadcrumbs.phtml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,19 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
7+
// @codingStandardsIgnoreFile
68
?>
79
<?php if ($crumbs && is_array($crumbs)) : ?>
810
<div class="breadcrumbs">
911
<ul class="items">
1012
<?php foreach ($crumbs as $crumbName => $crumbInfo) : ?>
1113
<li class="item <?= $block->escapeHtmlAttr($crumbName) ?>">
1214
<?php if ($crumbInfo['link']) : ?>
13-
<a href="<?= $block->escapeUrl($crumbInfo['link']) ?>" title="<?= $block->escapeHtml($crumbInfo['title']) ?>"><?= $block->escapeHtml($crumbInfo['label']) ?></a>
15+
<a href="<?= $block->escapeUrl($crumbInfo['link']) ?>"
16+
title="<?= $block->escapeHtml($crumbInfo['title']) ?>">
17+
<?= $block->escapeHtml($crumbInfo['label']) ?>
18+
</a>
1419
<?php elseif ($crumbInfo['last']) : ?>
1520
<strong><?= $block->escapeHtml($crumbInfo['label']) ?></strong>
1621
<?php else: ?>

app/code/Magento/Theme/view/frontend/templates/html/collapsible.phtml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,19 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
7+
// @codingStandardsIgnoreFile
68
?>
79

810
<div class="block <?= $block->escapeHtmlAttr($block->getBlockCss()) ?>">
9-
<div class="title <?= $block->escapeHtmlAttr($block->getBlockCss()) ?>-title" data-mage-init='{"toggleAdvanced": {"toggleContainers": "#<?= $block->escapeHtmlAttr($block->getBlockCss()) ?>", "selectorsToggleClass": "active"}}'>
10-
<strong><?= $block->escapeHtml(__($block->getBlockTitle())) ?></strong>
11+
<div class="title <?= $block->escapeHtmlAttr($block->getBlockCss()) ?>-title"
12+
data-mage-init='{"toggleAdvanced": {"toggleContainers": "#<?= $block->escapeHtmlAttr($block->getBlockCss()) ?>", "selectorsToggleClass": "active"}}'>
13+
<strong>
14+
<?= $block->escapeHtml(__($block->getBlockTitle())) ?>
15+
</strong>
1116
</div>
12-
<div class="content <?= $block->escapeHtmlAttr($block->getBlockCss()) ?>-content" id="<?= $block->escapeHtmlAttr($block->getBlockCss()) ?>">
17+
<div class="content <?= $block->escapeHtmlAttr($block->getBlockCss()) ?>-content"
18+
id="<?= $block->escapeHtmlAttr($block->getBlockCss()) ?>">
1319
<?= $block->getChildHtml() ?>
1420
</div>
1521
</div>

0 commit comments

Comments
 (0)