Skip to content

Commit 4141f48

Browse files
authored
Fix HTML syntax error in visual.phtml
Fix static test failure
1 parent db94f8b commit 4141f48

File tree

1 file changed

+6
-5
lines changed
  • app/code/Magento/Swatches/view/adminhtml/templates/catalog/product/attribute

1 file changed

+6
-5
lines changed

app/code/Magento/Swatches/view/adminhtml/templates/catalog/product/attribute/visual.phtml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66

77
// phpcs:disable PHPCompatibility.Miscellaneous.RemovedAlternativePHPTags.MaybeASPOpenTagFound
8+
// phpcs:disable Generic.Files.LineLength.TooLong
89
/** @var $block \Magento\Swatches\Block\Adminhtml\Attribute\Edit\Options\Visual */
910

1011
$stores = $block->getStoresSortedBySortOrder();
@@ -20,7 +21,7 @@ $stores = $block->getStoresSortedBySortOrder();
2021
<th class="col-draggable"></th>
2122
<th class="col-default"><span><?= $block->escapeHtml(__('Is Default')) ?></span></th>
2223
<th><span><?= $block->escapeHtml(__('Swatch')) ?></span></th>
23-
<?php foreach ($stores as $_store) : ?>
24+
<?php foreach ($stores as $_store): ?>
2425
<th<?= ($_store->getId() == \Magento\Store\Model\Store::DEFAULT_STORE_ID) ? ' class="_required"' : '' ?>>
2526
<span><?= $block->escapeHtml($_store->getName()) ?></span>
2627
</th>
@@ -39,7 +40,7 @@ $stores = $block->getStoresSortedBySortOrder();
3940
</tr>
4041
<tr>
4142
<th colspan="<?= (int)$colTotal ?>" class="col-actions-add">
42-
<?php if (!$block->getReadOnly() && !$block->canManageOptionDefaultOnly()) : ?>
43+
<?php if (!$block->getReadOnly() && !$block->canManageOptionDefaultOnly()): ?>
4344
<button id="add_new_swatch_visual_option_button"
4445
title="<?= $block->escapeHtml(__('Add Swatch')) ?>"
4546
type="button" class="action- scalable add">
@@ -55,7 +56,7 @@ $stores = $block->getStoresSortedBySortOrder();
5556
<script id="swatch-visual-row-template" type="text/x-magento-template">
5657
<tr>
5758
<td class="col-draggable">
58-
<?php if (!$block->getReadOnly() && !$block->canManageOptionDefaultOnly()) : ?>
59+
<?php if (!$block->getReadOnly() && !$block->canManageOptionDefaultOnly()): ?>
5960
<div data-role="draggable-handle" class="draggable-handle"
6061
title="<?= $block->escapeHtml(__('Sort Option')) ?>"></div>
6162
<?php endif; ?>
@@ -86,7 +87,7 @@ $stores = $block->getStoresSortedBySortOrder();
8687
</div>
8788
</div>
8889
</td>
89-
<?php foreach ($stores as $_store) : ?>
90+
<?php foreach ($stores as $_store): ?>
9091
<td class="swatch-col-<%- data.id %>">
9192
<input name="optionvisual[value][<%- data.id %>][<?= (int)$_store->getId() ?>]"
9293
value="<%- data.store<?= (int) $_store->getId() ?> %>"
@@ -96,7 +97,7 @@ $stores = $block->getStoresSortedBySortOrder();
9697
<?php endforeach; ?>
9798
<td id="delete_button_swatch_container_<%- data.id %>" class="col-delete">
9899
<input type="hidden" class="delete-flag" name="optionvisual[delete][<%- data.id %>]" value="" />
99-
<?php if (!$block->getReadOnly() && !$block->canManageOptionDefaultOnly()) : ?>
100+
<?php if (!$block->getReadOnly() && !$block->canManageOptionDefaultOnly()): ?>
100101
<button title="<?= $block->escapeHtml(__('Delete')) ?>" type="button"
101102
class="action- scalable delete delete-option">
102103
<span><?= $block->escapeHtml(__('Delete')) ?></span>

0 commit comments

Comments
 (0)