MC-32658: MyAccount :: Order Details :: Order Details by Order Number Taxes and Discounts

- Added changes on taxes tests and code, fixed review comments

Author: avattam06

app/code/Magento/SalesGraphQl/Model/Resolver/OrderTotal.php

@@ -11,6 +11,7 @@
 use Magento\Framework\GraphQl\Config\Element\Field;
 use Magento\Framework\GraphQl\Query\ResolverInterface;
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
+use Magento\Sales\Api\Data\OrderExtensionInterface;
 use Magento\Sales\Api\Data\OrderInterface;
 
 class OrderTotal implements ResolverInterface
@@ -33,24 +34,9 @@ public function resolve(
         $order = $value['model'];
         $currency = $order->getOrderCurrencyCode();
         $extensionAttributes = $order->getExtensionAttributes();
-        $allAppliedTaxesForItemsData = [];
-        $appliedShippingTaxesForItemsData = [];
-        foreach ($extensionAttributes->getItemAppliedTaxes() ?? [] as $taxItemIndex => $appliedTaxForItem) {
-            foreach ($appliedTaxForItem->getAppliedTaxes() ?? [] as $taxLineItem) {
-                $appliedShippingTaxesForItemsData[$taxItemIndex][$taxItemIndex] = [
-                    'title' => $taxLineItem->getDataByKey('title'),
-                    'percent' => $taxLineItem->getDataByKey('percent'),
-                    'amount' => $taxLineItem->getDataByKey('amount'),
-                ];
-                if ($appliedTaxForItem->getType() === "shipping") {
-                    $appliedShippingTaxesForItemsData[$taxItemIndex][$taxItemIndex] = [
-                        'title' => $taxLineItem->getDataByKey('title'),
-                        'percent' => $taxLineItem->getDataByKey('percent'),
-                        'amount' => $taxLineItem->getDataByKey('amount')
-                    ];
-                }
-            }
-        }
+
+        $allAppliedTaxesForItemsData =  $this->getAllAppliedTaxesForItemsData($extensionAttributes);
+        $appliedShippingTaxesForItemsData = $this->getAppliedShippingTaxesForItemsData($extensionAttributes);
 
         return [
             'base_grand_total' => ['value' => $order->getBaseGrandTotal(), 'currency' => $currency],
@@ -73,6 +59,46 @@ public function resolve(
         ];
     }
 
+    /**
+     * @param OrderExtensionInterface $extensionAttributes
+     * @return array
+     */
+    private function getAllAppliedTaxesForItemsData(OrderExtensionInterface $extensionAttributes): array
+    {
+        $allAppliedTaxesForItemsData = [];
+        foreach ($extensionAttributes->getItemAppliedTaxes() ?? [] as $taxItemIndex => $appliedTaxForItem) {
+            foreach ($appliedTaxForItem->getAppliedTaxes() ?? [] as $taxLineItem) {
+                $allAppliedTaxesForItemsData[$taxItemIndex][$taxItemIndex] = [
+                    'title' => $taxLineItem->getDataByKey('title'),
+                    'percent' => $taxLineItem->getDataByKey('percent'),
+                    'amount' => $taxLineItem->getDataByKey('amount'),
+                ];
+            }
+        }
+        return $allAppliedTaxesForItemsData;
+    }
+
+    /**
+     * @param OrderExtensionInterface $extensionAttributes
+     * @return array
+     */
+    private function getAppliedShippingTaxesForItemsData(OrderExtensionInterface $extensionAttributes): array
+    {
+        $appliedShippingTaxesForItemsData = [];
+        foreach ($extensionAttributes->getItemAppliedTaxes() ?? [] as $taxItemIndex => $appliedTaxForItem) {
+            foreach ($appliedTaxForItem->getAppliedTaxes() ?? [] as $taxLineItem) {
+                if ($appliedTaxForItem->getType() === "shipping") {
+                    $appliedShippingTaxesForItemsData[$taxItemIndex][$taxItemIndex] = [
+                        'title' => $taxLineItem->getDataByKey('title'),
+                        'percent' => $taxLineItem->getDataByKey('percent'),
+                        'amount' => $taxLineItem->getDataByKey('amount')
+                    ];
+                }
+            }
+        }
+        return $appliedShippingTaxesForItemsData;
+    }
+
     /**
      * Return information about an applied discount
      *

dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/RetrieveOrdersByOrderNumberTest.php

@@ -590,10 +590,6 @@ public function testGetMultipleCustomerOrdersQueryWithDefaultPagination()
                 4,
                 $customerOrderItemsInResponse[$key]['total']['shipping_handling']['total_amount']['value']
             );
-            $this->assertEquals(
-                0,
-                $customerOrderItemsInResponse[$key]['total']['shipping_handling']['taxes'][0]['amount']['value']
-            );
             $this->assertEquals(
                 5,
                 $customerOrderItemsInResponse[$key]['total']['total_shipping']['value']
@@ -1666,14 +1662,6 @@ private function assertTotals(array $response, int $expectedCount): void
                 'USD',
                 $response['customer']['orders']['items'][0]['total']['shipping_handling']['total_amount']['currency']
             );
-            $this->assertEquals(
-                0,
-                $response['customer']['orders']['items'][0]['total']['taxes'][0]['amount']['value']
-            );
-            $this->assertEquals(
-                'USD',
-                $response['customer']['orders']['items'][0]['total']['taxes'][0]['amount']['currency']
-            );
         }
     }