AC-11453: newsletter templates and queue validations

Rizwan Khan · Rizwan Khan · commit 42d79bef7524 · 2024-06-10T17:26:42.000+05:30
diff --git a/app/code/Magento/Newsletter/Controller/Adminhtml/Queue/Edit.php b/app/code/Magento/Newsletter/Controller/Adminhtml/Queue/Edit.php
@@ -11,7 +11,7 @@
 class Edit extends \Magento\Newsletter\Controller\Adminhtml\Queue implements HttpGetActionInterface
 {
     /**
-     * Core registry
+     * Core registry variable
      *
      * @var \Magento\Framework\Registry
      */
@@ -31,6 +31,7 @@ public function __construct(\Magento\Backend\App\Action\Context $context, \Magen
      * Edit Newsletter queue
      *
      * @return void
+     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
      */
     public function execute()
     {
@@ -61,6 +62,8 @@ public function execute()
     }
 
     /**
+     * Checks the acl permission
+     *
      * @return bool
      */
     protected function _isAllowed()
diff --git a/app/code/Magento/Newsletter/Controller/Adminhtml/Template/Edit.php b/app/code/Magento/Newsletter/Controller/Adminhtml/Template/Edit.php
@@ -11,7 +11,7 @@
 class Edit extends \Magento\Newsletter\Controller\Adminhtml\Template implements HttpGetActionInterface
 {
     /**
-     * Core registry
+     * Registry core variable
      *
      * @var \Magento\Framework\Registry
      */
@@ -69,6 +69,8 @@ public function execute()
     }
 
     /**
+     * Checks the acl permission
+     *
      * @return bool
      */
     protected function _isAllowed()

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`class Edit extends \Magento\Newsletter\Controller\Adminhtml\Queue implements HttpGetActionInterface`
`12`	`12`	`{`
`13`	`13`	`/**`
`14`		`- * Core registry`
	`14`	`+ * Core registry variable`
`15`	`15`	`*`
`16`	`16`	`* @var \Magento\Framework\Registry`
`17`	`17`	`*/`
`@@ -31,6 +31,7 @@ public function __construct(\Magento\Backend\App\Action\Context $context, \Magen`
`31`	`31`	`* Edit Newsletter queue`
`32`	`32`	`*`
`33`	`33`	`* @return void`
	`34`	`+ * @SuppressWarnings(PHPMD.UnusedLocalVariable)`
`34`	`35`	`*/`
`35`	`36`	`public function execute()`
`36`	`37`	`{`
`@@ -61,6 +62,8 @@ public function execute()`
`61`	`62`	`}`
`62`	`63`
`63`	`64`	`/**`
	`65`	`+ * Checks the acl permission`
	`66`	`+ *`
`64`	`67`	`* @return bool`
`65`	`68`	`*/`
`66`	`69`	`protected function _isAllowed()`