MC-33459: Magento\Quote\Model\ShippingMethodManagementTest::testEstimateByAddressWithInclExclTaxAndVATGroup failed for 2.4-develop

Author: serhii-balko

dev/tests/integration/testsuite/Magento/Customer/_files/customer_group_rollback.php

@@ -7,6 +7,7 @@
 
 use Magento\Framework\Api\SearchCriteriaBuilder;
 use Magento\Customer\Api\GroupRepositoryInterface;
+use Magento\Framework\Registry;
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\Framework\ObjectManagerInterface;
 use Magento\Framework\Exception\NoSuchEntityException;
@@ -21,10 +22,17 @@
     ->create();
 $groups = $groupRepository->getList($searchCriteria)
     ->getItems();
+
+/** @var Registry $registry */
+$registry = $objectManager->get(Registry::class);
+$registry->unregister('isSecureArea');
+$registry->register('isSecureArea', true);
 foreach ($groups as $group) {
     try {
         $groupRepository->delete($group);
     } catch (NoSuchEntityException $exception) {
         //Group already removed
     }
 }
+$registry->unregister('isSecureArea');
+$registry->register('isSecureArea', false);

dev/tests/integration/testsuite/Magento/Quote/Model/ShippingMethodManagementTest.php

@@ -11,15 +11,19 @@
 use Magento\Customer\Api\Data\GroupInterface;
 use Magento\Customer\Api\GroupRepositoryInterface;
 use Magento\Customer\Model\Vat;
+use Magento\Customer\Observer\AfterAddressSaveObserver;
 use Magento\Framework\Api\SearchCriteriaBuilder;
 use Magento\Framework\App\Config\MutableScopeConfigInterface;
+use Magento\Framework\DataObject;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\ObjectManagerInterface;
 use Magento\Quote\Api\CartRepositoryInterface;
 use Magento\Quote\Api\Data\AddressInterfaceFactory;
 use Magento\Quote\Api\Data\EstimateAddressInterface;
 use Magento\Quote\Api\GuestShippingMethodManagementInterface;
 use Magento\Quote\Api\ShippingMethodManagementInterface;
+use Magento\Quote\Observer\Frontend\Quote\Address\CollectTotalsObserver;
+use Magento\Quote\Observer\Frontend\Quote\Address\VatValidator;
 use Magento\Store\Model\ScopeInterface;
 use Magento\Tax\Api\Data\TaxClassInterface;
 use Magento\Tax\Api\TaxClassRepositoryInterface;
@@ -299,6 +303,8 @@ private function executeTestFlow($flatRateAmount, $tableRateAmount)
      */
     public function testEstimateByAddressWithInclExclTaxAndVATGroup()
     {
+        $this->mockCustomerVat();
+
         /** @var CustomerRepositoryInterface $customerRepository */
         $customerRepository = $this->objectManager->get(CustomerRepositoryInterface::class);
         $customer = $customerRepository->get('[email protected]');
@@ -324,11 +330,45 @@ public function testEstimateByAddressWithInclExclTaxAndVATGroup()
         $this->assertEquals(5.0, $result[0]->getPriceExclTax());
     }
 
+    /**
+     * Create a test double fot customer vat class
+     */
+    private function mockCustomerVat(): void
+    {
+        $gatewayResponse = new DataObject([
+            'is_valid' => false,
+            'request_date' => '',
+            'request_identifier' => '123123123',
+            'request_success' => false,
+            'request_message' => __('Error during VAT Number verification.'),
+        ]);
+        $customerVat = $this->createPartialMock(Vat::class,
+            [
+                'checkVatNumber',
+                'isCountryInEU',
+                'getCustomerGroupIdBasedOnVatNumber',
+                'getMerchantCountryCode',
+                'getMerchantVatNumber'
+            ]
+        );
+        $customerVat->method('checkVatNumber')->willReturn($gatewayResponse);
+        $customerVat->method('isCountryInEU')->willReturn(true);
+        $customerVat->method('getMerchantCountryCode')->willReturn('GB');
+        $customerVat->method('getMerchantVatNumber')->willReturn('11111');
+        $customerVat->method('getCustomerGroupIdBasedOnVatNumber')->willReturn('4');
+        $this->objectManager->removeSharedInstance(Vat::class);
+        $this->objectManager->addSharedInstance($customerVat, Vat::class);
+
+        // Remove instances where the customer vat object is cached
+        $this->objectManager->removeSharedInstance(CollectTotalsObserver::class);
+        $this->objectManager->removeSharedInstance(AfterAddressSaveObserver::class);
+        $this->objectManager->removeSharedInstance(VatValidator::class);
+    }
+
     /**
      * Find the group with a given code.
      *
      * @param string $code
-     *
      * @return GroupInterface
      */
     protected function findCustomerGroupByCode(string $code): ?GroupInterface
@@ -397,11 +437,6 @@ private function setConfig(int $customerGroupId, int $productTaxClassId): void
                 'value' => $customerGroupId,
                 'scope' => ScopeInterface::SCOPE_STORE,
             ],
-            [
-                'path' => Vat::XML_PATH_CUSTOMER_VIV_ERROR_GROUP,
-                'value' => $customerGroupId,
-                'scope' => ScopeInterface::SCOPE_STORE,
-            ],
             [
                 'path' => TaxConfig::CONFIG_XML_PATH_SHIPPING_TAX_CLASS,
                 'value' => $productTaxClassId,

dev/tests/integration/testsuite/Magento/Tax/_files/tax_classes_de_rollback.php

@@ -6,6 +6,8 @@
 declare(strict_types=1);
 
 use Magento\Framework\Api\SearchCriteriaBuilder;
+use Magento\Framework\Registry;
+use Magento\Tax\Api\TaxClassManagementInterface;
 use Magento\Tax\Model\ClassModel;
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\Framework\ObjectManagerInterface;
@@ -18,37 +20,44 @@
 
 /** @var ObjectManagerInterface $objectManager */
 $objectManager = Bootstrap::getObjectManager();
-$taxClasses = [
-    'CustomerTaxClass',
-    'ProductTaxClass',
-];
 $taxRuleRepository = $objectManager->get(TaxRuleRepositoryInterface::class);
 /** @var SearchCriteriaBuilder $searchBuilder */
 $searchBuilder = $objectManager->get(SearchCriteriaBuilder::class);
 $searchCriteria = $searchBuilder->addFilter(Rule::KEY_CODE, 'Test Rule')
     ->create();
 $taxRules = $taxRuleRepository->getList($searchCriteria)
     ->getItems();
+
+/** @var Registry $registry */
+$registry = $objectManager->get(Registry::class);
+$registry->unregister('isSecureArea');
+$registry->register('isSecureArea', true);
 foreach ($taxRules as $taxRule) {
     try {
         $taxRuleRepository->delete($taxRule);
     } catch (NoSuchEntityException $exception) {
         //Rule already removed
     }
 }
-$searchCriteria = $searchBuilder->addFilter(ClassModel::KEY_NAME, $taxClasses, 'in')
-    ->create();
-/** @var TaxClassRepositoryInterface $groupRepository */
+
+/** @var TaxClassRepositoryInterface $taxClassRepository */
 $taxClassRepository = $objectManager->get(TaxClassRepositoryInterface::class);
-$taxClasses = $taxClassRepository->getList($searchCriteria)
-    ->getItems();
+$searchCriteria = $searchBuilder->addFilter(ClassModel::KEY_NAME, 'CustomerTaxClass')
+    ->addFilter(ClassModel::KEY_TYPE, TaxClassManagementInterface::TYPE_CUSTOMER)
+    ->create();
+$taxClasses = $taxClassRepository->getList($searchCriteria)->getItems();
+$searchCriteria = $searchBuilder->addFilter(ClassModel::KEY_NAME, 'ProductTaxClass')
+    ->addFilter(ClassModel::KEY_TYPE, TaxClassManagementInterface::TYPE_PRODUCT)
+    ->create();
+$taxClasses = array_merge($taxClasses, $taxClassRepository->getList($searchCriteria)->getItems());
 foreach ($taxClasses as $taxClass) {
     try {
         $taxClassRepository->delete($taxClass);
     } catch (NoSuchEntityException $exception) {
         //TaxClass already removed
     }
 }
+
 $searchCriteria = $searchBuilder->addFilter(Rate::KEY_CODE, 'Denmark')
     ->create();
 /** @var TaxRateRepositoryInterface $groupRepository */
@@ -62,3 +71,5 @@
         //TaxRate already removed
     }
 }
+$registry->unregister('isSecureArea');
+$registry->register('isSecureArea', false);