MAGETWO-96242: High Database Load for Sales Rule Validation

Author: Oleksandr Iegorov

app/code/Magento/SalesRule/Model/ResourceModel/Rule/Collection.php

@@ -162,67 +162,17 @@ public function setValidationFilter(
 
             $connection = $this->getConnection();
             if (strlen($couponCode)) {
-                $select->joinLeft(
-                    ['rule_coupons' => $this->getTable('salesrule_coupon')],
-                    $connection->quoteInto(
-                        'main_table.rule_id = rule_coupons.rule_id AND main_table.coupon_type != ?',
-                        \Magento\SalesRule\Model\Rule::COUPON_TYPE_NO_COUPON
-                    ),
-                    ['code']
-                );
-
                 $noCouponWhereCondition = $connection->quoteInto(
-                    'main_table.coupon_type = ? ',
+                    'main_table.coupon_type = ?',
                     \Magento\SalesRule\Model\Rule::COUPON_TYPE_NO_COUPON
                 );
-
-                $autoGeneratedCouponCondition = [
-                    $connection->quoteInto(
-                        "main_table.coupon_type = ?",
-                        \Magento\SalesRule\Model\Rule::COUPON_TYPE_AUTO
-                    ),
-                    $connection->quoteInto(
-                        "rule_coupons.type = ?",
-                        \Magento\SalesRule\Api\Data\CouponInterface::TYPE_GENERATED
-                    ),
-                ];
-
-                $orWhereConditions = [
-                    "(" . implode($autoGeneratedCouponCondition, " AND ") . ")",
-                    $connection->quoteInto(
-                        '(main_table.coupon_type = ? AND main_table.use_auto_generation = 1 AND rule_coupons.type = 1)',
-                        \Magento\SalesRule\Model\Rule::COUPON_TYPE_SPECIFIC
-                    ),
-                    $connection->quoteInto(
-                        '(main_table.coupon_type = ? AND main_table.use_auto_generation = 0 AND rule_coupons.type = 0)',
-                        \Magento\SalesRule\Model\Rule::COUPON_TYPE_SPECIFIC
-                    ),
-                ];
-
-                $andWhereConditions = [
-                    $connection->quoteInto(
-                        'rule_coupons.code = ?',
-                        $couponCode
-                    ),
-                    $connection->quoteInto(
-                        '(rule_coupons.expiration_date IS NULL OR rule_coupons.expiration_date >= ?)',
-                        $this->_date->date()->format('Y-m-d')
-                    ),
-                ];
-
-                $orWhereCondition = implode(' OR ', $orWhereConditions);
-                $andWhereCondition = implode(' AND ', $andWhereConditions);
-
-                $selectClone = clone $select;
+                $relatedRulesIds = $this->getCouponRelatedRuleIds($couponCode);
 
                 $select->where(
-                    '(' . $orWhereCondition . ') AND ' . $andWhereCondition,
-                    null,
+                    $noCouponWhereCondition . ' OR main_table.rule_id IN (?)',
+                    $relatedRulesIds,
                     Select::TYPE_CONDITION
                 );
-                $selectClone->where($noCouponWhereCondition, null, Select::TYPE_CONDITION);
-                $select = $this->getConnection()->select()->union([$select, $selectClone]);
-                $this->_select = $select;
             } else {
                 $this->addFieldToFilter(
                     'main_table.coupon_type',
@@ -236,6 +186,75 @@ public function setValidationFilter(
         return $this;
     }
 
+    /**
+     * Get rules ids related to coupon code
+     *
+     * @param string $couponCode
+     * @return array|null
+     */
+    private function getCouponRelatedRuleIds(string $couponCode): ?array
+    {
+        $connection = $this->getConnection();
+        $select = $connection->select()->from(
+            ['main_table' => $this->getTable('salesrule')],
+            'rule_id'
+        );
+        $select->joinLeft(
+            ['rule_coupons' => $this->getTable('salesrule_coupon')],
+            $connection->quoteInto(
+                'main_table.rule_id = rule_coupons.rule_id AND main_table.coupon_type != ?',
+                \Magento\SalesRule\Model\Rule::COUPON_TYPE_NO_COUPON,
+                null
+            )
+        );
+
+        $autoGeneratedCouponCondition = [
+            $connection->quoteInto(
+                "main_table.coupon_type = ?",
+                \Magento\SalesRule\Model\Rule::COUPON_TYPE_AUTO
+            ),
+            $connection->quoteInto(
+                "rule_coupons.type = ?",
+                \Magento\SalesRule\Api\Data\CouponInterface::TYPE_GENERATED
+            ),
+        ];
+
+        $orWhereConditions = [
+            "(" . implode($autoGeneratedCouponCondition, " AND ") . ")",
+            $connection->quoteInto(
+                '(main_table.coupon_type = ? AND main_table.use_auto_generation = 1 AND rule_coupons.type = 1)',
+                \Magento\SalesRule\Model\Rule::COUPON_TYPE_SPECIFIC
+            ),
+            $connection->quoteInto(
+                '(main_table.coupon_type = ? AND main_table.use_auto_generation = 0 AND rule_coupons.type = 0)',
+                \Magento\SalesRule\Model\Rule::COUPON_TYPE_SPECIFIC
+            ),
+        ];
+
+        $andWhereConditions = [
+            $connection->quoteInto(
+                'rule_coupons.code = ?',
+                $couponCode
+            ),
+            $connection->quoteInto(
+                '(rule_coupons.expiration_date IS NULL OR rule_coupons.expiration_date >= ?)',
+                $this->_date->date()->format('Y-m-d')
+            ),
+        ];
+
+        $orWhereCondition = implode(' OR ', $orWhereConditions);
+        $andWhereCondition = implode(' AND ', $andWhereConditions);
+
+        $select->where(
+            '(' . $orWhereCondition . ') AND ' . $andWhereCondition,
+            null,
+            Select::TYPE_CONDITION
+        );
+        $select->group('main_table.rule_id');
+
+        return $connection->fetchCol($select);
+    }
+
     /**
      * Filter collection by website(s), customer group(s) and date.
      * Filter collection to only active rules.