ENGCOM-5235: Do an empty check instead of isset check on image removed #22910

magento-engcom-team · magento-engcom-team · commit 44d26979a2fb · 2019-06-07T16:38:24.000-05:00
- Merge Pull Request #22910 from arnoudhgz/magento2:feature/improve-image-roles-saving - Merged commits: 1. b65c12e
diff --git a/app/code/Magento/Catalog/Model/ProductRepository/MediaGalleryProcessor.php b/app/code/Magento/Catalog/Model/ProductRepository/MediaGalleryProcessor.php
@@ -231,7 +231,7 @@ private function processEntries(ProductInterface $product, array $newEntries, ar
     private function processMediaAttributes(ProductInterface $product, array $images): void
     {
         foreach ($images as $image) {
-            if (!isset($image['removed']) && !empty($image['types'])) {
+            if (empty($image['removed']) && !empty($image['types'])) {
                 $this->processor->setMediaAttribute($product, $image['types'], $image['file']);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ private function processEntries(ProductInterface $product, array $newEntries, ar`
`231`	`231`	`private function processMediaAttributes(ProductInterface $product, array $images): void`
`232`	`232`	`{`
`233`	`233`	`foreach ($images as $image) {`
`234`		`- if (!isset($image['removed']) && !empty($image['types'])) {`
	`234`	`+ if (empty($image['removed']) && !empty($image['types'])) {`
`235`	`235`	`$this->processor->setMediaAttribute($product, $image['types'], $image['file']);`
`236`	`236`	`}`
`237`	`237`	`}`