MC-16258: [final] Pop-up message in case of changing option to NO

Author: andimov

app/code/Magento/CatalogUrlRewrite/etc/adminhtml/system.xml

@@ -29,12 +29,13 @@
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                 </field>
                 <field id="generate_rewrites_on_save" translate="label" type="select" sortOrder="6" showInDefault="1" showInWebsite="0" showInStore="0">
-                    <label>Generate URL Rewrites for Products on Category Save</label>
+                    <label>Generate URL Rewrites for Products in Categories</label>
                     <backend_model>Magento\CatalogUrlRewrite\Model\TableCleaner</backend_model>
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                     <comment>
-                        <![CDATA[<strong style="color:red">Warning!</strong> If you will set option to No autogenerated urls will be deleted, please see documentation]]>
+                        <![CDATA[<strong style="color:red">Warning!</strong> Turning this option off will result in permanent removal of category/product URL rewrites without an ability to restore them back.]]>
                     </comment>
+                    <frontend_class>generate_rewrites_on_save</frontend_class>
                 </field>
             </group>
         </section>

app/code/Magento/CatalogUrlRewrite/i18n/en_US.csv

@@ -5,4 +5,6 @@
 "Product URL Suffix","Product URL Suffix"
 "Use Categories Path for Product URLs","Use Categories Path for Product URLs"
 "Create Permanent Redirect for URLs if URL Key Changed","Create Permanent Redirect for URLs if URL Key Changed"
-"Generate URL Rewrites for Products on Category Save","Generate URL Rewrites for Products on Category Save"
+"Generate URL Rewrites for Products in Categories","Generate URL Rewrites for Products in Categories"
+"Turn off automatic generation of products with categories path URL rewrites?","Turn off automatic generation of products with categories path URL rewrites?"
+"Turning off automatic generation of products with categories path URL rewrites will result in permanent removal of all the currently existing “category/product” type URL rewrites without an ability to restore them back. This may potentially cause unresolved “category/product” type URL conflicts which you have to resolve by creating a URL rewrite manually.","Turning off automatic generation of products with categories path URL rewrites will result in permanent removal of all the currently existing “category/product” type URL rewrites without an ability to restore them back. This may potentially cause unresolved “category/product” type URL conflicts which you have to resolve by creating a URL rewrite manually."

app/code/Magento/Config/view/adminhtml/templates/system/config/edit.phtml

@@ -32,12 +32,14 @@
 require([
     "jquery",
     "uiRegistry",
+    "Magento_Ui/js/modal/confirm",
+    "mage/translate",
     "mage/mage",
     "prototype",
     "mage/adminhtml/form",
     "domReady!",
     "jquery/ui"
-], function(jQuery, registry){
+], function(jQuery, registry, confirmation, $t){
 
     var adminSystemConfig = {
         navigateToElement: function (searchRequest) {
@@ -384,5 +386,25 @@ require([
     registry.set('adminSystemConfig', adminSystemConfig);
 
     adminSystemConfig.navigateToElement(<?php echo /* @noEscape */ $block->getConfigSearchParamsJson(); ?>);
+
+    //confirmation for removing category/product URL rewrites
+    jQuery('select.generate_rewrites_on_save').on('change', function(event){
+        if (this.value == 0) {
+            confirmation({
+                title: $t('Turn off automatic generation of products with categories path URL rewrites?'),
+                content: $t('Turning off automatic generation of products with categories path URL rewrites will ' +
+                    'result in permanent removal of all the currently existing “category/product” type URL rewrites ' +
+                    'without an ability to restore them back. This may potentially cause unresolved “category/product”' +
+                    ' type URL conflicts which you have to resolve by creating a URL rewrite manually.'),
+                actions: {
+                    cancel: function () {
+                        jQuery('select.generate_rewrites_on_save').val(1);
+                        return false;
+                    },
+                }
+            })
+        }
+    });
+
 });
 </script>