ACPT-1587: Send GraphQl errors to New Relic

Sending errors from Magento\Framework\GraphQl\Query\ErrorHandler now too

Author: JacobBrownAustin

app/code/Magento/GraphQlNewRelic/Plugin/ReportError.php

@@ -7,7 +7,8 @@
 
 namespace Magento\GraphQlNewRelic\Plugin;
 
-use Magento\Framework\GraphQl\Exception\ExceptionFormatter;
+use GraphQL\Error\Error;
+use Magento\Framework\GraphQl\Query\ErrorHandler;
 use Magento\NewRelicReporting\Model\NewRelicWrapper;
 
 /**
@@ -24,18 +25,17 @@ public function __construct(private NewRelicWrapper $newRelicWrapper) {
     /**
      * Sends error from GraphQL to New Relic
      *
-     * @param ExceptionFormatter $subject
-     * @param \Throwable $exception
-     * @param string|null $internalErrorMessage
+     * @param ErrorHandler $subject
+     * @param Error[] $errors
+     * @param callable $formatter
      * @return null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function beforeCheck(
-        ExceptionFormatter $subject,
-        \Throwable $exception,
-        string $internalErrorMessage= null
+    public function beforeHandle(ErrorHandler $subject, array $errors, callable $formatter
     ): null {
-        $this->newRelicWrapper->reportError($exception);
+        if (!empty($errors)) {
+            $this->newRelicWrapper->reportError($errors[0]); // Note: We only log the first error because performance
+        }
         return null;
     }
 }

app/code/Magento/GraphQlNewRelic/Plugin/ReportException.php

@@ -0,0 +1,41 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\GraphQlNewRelic\Plugin;
+
+use Magento\Framework\GraphQl\Exception\ExceptionFormatter;
+use Magento\NewRelicReporting\Model\NewRelicWrapper;
+
+/**
+ * Plugin that sends GraphQL Errors to New Relic
+ */
+class ReportException
+{
+    /**
+     * @param NewRelicWrapper $newRelicWrapper
+     */
+    public function __construct(private NewRelicWrapper $newRelicWrapper) {
+    }
+
+    /**
+     * Sends error from GraphQL to New Relic
+     *
+     * @param ExceptionFormatter $subject
+     * @param \Throwable $exception
+     * @param string|null $internalErrorMessage
+     * @return null
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function beforeCheck(
+        ExceptionFormatter $subject,
+        \Throwable $exception,
+        string $internalErrorMessage= null
+    ): null {
+        $this->newRelicWrapper->reportError($exception);
+        return null;
+    }
+}

app/code/Magento/GraphQlNewRelic/etc/di.xml

@@ -14,6 +14,9 @@
         </arguments>
     </type>
     <type name="Magento\Framework\GraphQl\Exception\ExceptionFormatter">
+        <plugin name="report-exception-to-new-relic" type="Magento\GraphQlNewRelic\Plugin\ReportException" sortOrder="50"/>
+    </type>
+    <type name="Magento\Framework\GraphQl\Query\ErrorHandler">
         <plugin name="report-error-to-new-relic" type="Magento\GraphQlNewRelic\Plugin\ReportError" sortOrder="50"/>
     </type>
 </config>