graphQl-892: fixed billing address return implementation

Author: Vitaliy Boyko

app/code/Magento/QuoteGraphQl/Model/Resolver/BillingAddress.php

@@ -44,7 +44,13 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         $cart = $value['model'];
 
         $billingAddress = $cart->getBillingAddress();
-        if (null === $billingAddress) {
+        if (null === $billingAddress ||
+            null === $billingAddress->getFirstname() ||
+            null === $billingAddress->getLastname() ||
+            null === $billingAddress->getCity() ||
+            null === $billingAddress->getCountry() ||
+            null === $billingAddress->getTelephone() ||
+            null === $billingAddress->getStreet()) {
             return null;
         }
 

app/code/Magento/QuoteGraphQl/etc/schema.graphqls

@@ -194,7 +194,7 @@ type Cart {
     applied_coupon: AppliedCoupon @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\AppliedCoupon")
     email: String @resolver (class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartEmail")
     shipping_addresses: [ShippingCartAddress]! @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\ShippingAddresses")
-    billing_address: BillingCartAddress! @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\BillingAddress")
+    billing_address: BillingCartAddress @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\BillingAddress")
     available_payment_methods: [AvailablePaymentMethod] @resolver(class: "Magento\\QuoteGraphQl\\Model\\Resolver\\AvailablePaymentMethods") @doc(description: "Available payment methods")
     selected_payment_method: SelectedPaymentMethod @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\SelectedPaymentMethod")
     prices: CartPrices @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartPrices")

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetSpecifiedBillingAddressTest.php

@@ -91,29 +91,7 @@ public function testGetSpecifiedBillingAddressIfBillingAddressIsNotSet()
         $response = $this->graphQlQuery($query, [], '', $this->getHeaderMap());
         self::assertArrayHasKey('cart', $response);
         self::assertArrayHasKey('billing_address', $response['cart']);
-
-        $expectedBillingAddressData = [
-            'firstname' => null,
-            'lastname' => null,
-            'company' => null,
-            'street' => [
-                ''
-            ],
-            'city' => null,
-            'region' => [
-                'code' => null,
-                'label' => null,
-            ],
-            'postcode' => null,
-            'country' => [
-                'code' => null,
-                'label' => null,
-            ],
-            'telephone' => null,
-            '__typename' => 'BillingCartAddress',
-            'customer_notes' => null,
-        ];
-        self::assertEquals($expectedBillingAddressData, $response['cart']['billing_address']);
+        self::assertNull($response['cart']['billing_address']);
     }
 
     /**

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/GetSpecifiedBillingAddressTest.php

@@ -81,28 +81,7 @@ public function testGetSpecifiedBillingAddressIfBillingAddressIsNotSet()
         $response = $this->graphQlQuery($query);
         self::assertArrayHasKey('cart', $response);
         self::assertArrayHasKey('billing_address', $response['cart']);
-
-        $expectedBillingAddressData = [
-            'firstname' => null,
-            'lastname' => null,
-            'company' => null,
-            'street' => [
-                ''
-            ],
-            'city' => null,
-            'region' => [
-                'code' => null,
-                'label' => null,
-            ],
-            'postcode' => null,
-            'country' => [
-                'code' => null,
-                'label' => null,
-            ],
-            'telephone' => null,
-            '__typename' => 'BillingCartAddress',
-        ];
-        self::assertEquals($expectedBillingAddressData, $response['cart']['billing_address']);
+        self::assertNull($response['cart']['billing_address']);
     }
 
     /**