Skip to content

Commit 49f7dae

Browse files
author
ogorkun
committed
MC-34385: Filter fields allowing HTML
1 parent e4e7812 commit 49f7dae

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

app/code/Magento/Catalog/Model/Attribute/Backend/DefaultBackend.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ private function validateHtml(DataObject $object): void
4747
$attribute = $this->getAttribute();
4848
$code = $attribute->getAttributeCode();
4949
if ($attribute instanceof Attribute && $attribute->getIsHtmlAllowedOnFront()) {
50-
if ($object->getData($code)
50+
$value = $object->getData($code);
51+
if ($value
52+
&& is_string($value)
5153
&& (!($object instanceof AbstractModel) || $object->getData($code) !== $object->getOrigData($code))
5254
) {
5355
try {

app/code/Magento/Cms/etc/di.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@
293293
<item name="alt" xsi:type="string">alt</item>
294294
<item name="title" xsi:type="string">title</item>
295295
<item name="border" xsi:type="string">border</item>
296+
<item name="id" xsi:type="string">id</item>
296297
</argument>
297298
<argument name="attributesAllowedByTags" xsi:type="array">
298299
<item name="a" xsi:type="array">

app/etc/di.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1856,6 +1856,8 @@
18561856
<item name="th" xsi:type="string">th</item>
18571857
<item name="tfoot" xsi:type="string">tfoot</item>
18581858
<item name="img" xsi:type="string">img</item>
1859+
<item name="hr" xsi:type="string">hr</item>
1860+
<item name="figure" xsi:type="string">figure</item>
18591861
</argument>
18601862
<argument name="allowedAttributes" xsi:type="array">
18611863
<item name="class" xsi:type="string">class</item>
@@ -1865,6 +1867,7 @@
18651867
<item name="alt" xsi:type="string">alt</item>
18661868
<item name="title" xsi:type="string">title</item>
18671869
<item name="border" xsi:type="string">border</item>
1870+
<item name="id" xsi:type="string">id</item>
18681871
</argument>
18691872
<argument name="attributesAllowedByTags" xsi:type="array">
18701873
<item name="a" xsi:type="array">
@@ -1875,9 +1878,7 @@
18751878
</item>
18761879
</argument>
18771880
<argument name="attributeValidators" xsi:type="array">
1878-
<item name="style" xsi:type="array">
1879-
<item name="style" xsi:type="object">Magento\Framework\Validator\HTML\StyleAttributeValidator</item>
1880-
</item>
1881+
<item name="style" xsi:type="object">Magento\Framework\Validator\HTML\StyleAttributeValidator</item>
18811882
</argument>
18821883
</arguments>
18831884
</virtualType>

0 commit comments

Comments
 (0)