Skip to content

Commit 4ce8ecb

Browse files
author
Oleksandr Gorkun
committed
MAGETWO-88432: Filesystem Directory Improvement
1 parent 1637cf5 commit 4ce8ecb

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

app/code/Magento/CatalogImportExport/Model/Import/Uploader.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,15 @@ public function move($fileName, $renameFileOff = false)
170170
}
171171
}
172172

173+
if ($this->getTmpDir()) {
174+
$filePath = $this->getTmpDir() . '/';
175+
} else {
176+
$filePath = '';
177+
}
173178
$fileName = preg_replace('/[^a-z0-9\._-]+/i', '', $fileName);
179+
$filePath = $this->_directory->getRelativePath($filePath . $fileName);
174180
$this->_directory->writeFile(
175-
$this->_directory->getRelativePath($this->getTmpDir() . '/' . $fileName),
181+
$filePath,
176182
$read->readAll()
177183
);
178184
}

app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/UploaderTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ protected function setUp()
103103
public function testMoveFileUrl($fileUrl, $expectedHost, $expectedFileName)
104104
{
105105
$destDir = 'var/dest/dir';
106-
$expectedRelativeFilePath = $this->uploader->getTmpDir() . '/' . $expectedFileName;
106+
$expectedRelativeFilePath = $expectedFileName;
107107
$this->directoryMock->expects($this->once())->method('isWritable')->with($destDir)->willReturn(true);
108108
$this->directoryMock->expects($this->any())->method('getRelativePath')->with($expectedRelativeFilePath);
109109
$this->directoryMock->expects($this->once())->method('getAbsolutePath')->with($destDir)
@@ -139,7 +139,7 @@ public function testMoveFileName()
139139
{
140140
$destDir = 'var/dest/dir';
141141
$fileName = 'test_uploader_file';
142-
$expectedRelativeFilePath = $this->uploader->getTmpDir() . '/' . $fileName;
142+
$expectedRelativeFilePath = $fileName;
143143
$this->directoryMock->expects($this->once())->method('isWritable')->with($destDir)->willReturn(true);
144144
$this->directoryMock->expects($this->any())->method('getRelativePath')->with($expectedRelativeFilePath);
145145
$this->directoryMock->expects($this->once())->method('getAbsolutePath')->with($destDir)

0 commit comments

Comments
 (0)