Skip to content

Commit 4d2c4a3

Browse files
committed
Mixin moved and simplified to avoid usage of weird LESS global scoping
1 parent 16ef8a5 commit 4d2c4a3

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

lib/web/css/source/lib/_icons.less

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,10 @@
285285
.lib-icon-text-hide();
286286
}
287287

288+
._lib-icon-image-url(@_path) when not (@_path = false) {
289+
.lib-css(background-image, url(@_path));
290+
}
291+
288292
._lib-icon-image(
289293
@_icon-image,
290294
@_icon-image-width,
@@ -294,9 +298,7 @@
294298
@_icon-image-position-x,
295299
@_icon-image-position-y
296300
) {
297-
.lib-url-check(@_icon-image);
298-
299-
.lib-css(background-image, @lib-url-check-output); // @lib-url-check-output is a returned variable of .lib-url-check() mixin
301+
._lib-icon-image-url(@_icon-image);
300302
.lib-css(background-position-x, @_icon-image-position-x);
301303
.lib-css(background-position-y, @_icon-image-position-y);
302304
.lib-css(line-height, @_icon-image-height);

lib/web/css/source/lib/_utilities.less

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -334,18 +334,6 @@
334334
@url: "@{baseDir}@{_module}/@{_path}";
335335
}
336336

337-
//
338-
// Url existing check
339-
// ---------------------------------------------
340-
341-
.lib-url-check(@_path) {
342-
@lib-url-check-output: @_path;
343-
}
344-
345-
.lib-url-check(@_path) when not (@_path = false) {
346-
@lib-url-check-output: url(@_path);
347-
}
348-
349337
//
350338
// Arrow
351339
// ---------------------------------------------

0 commit comments

Comments
 (0)