Fixing Config\Loader to not depend on broken cloning Proxy logic

Config/Loader was getting Config\Data\Collection from deprecated getCollection() method which was cloning a Proxy of a Collection which was causing the Collection object to have state in some cases which is totally broken.  Switched to using CollectionFactory as per technical guidelines and deprecated warnings.
Also modified AbstractModel to prefer Service Locator Pattern over cloning Collection to try to avoid other unclean Collections being returned by this broken deprecated method.

Author: JacobBrownAustin

app/code/Magento/Config/Model/Config/Loader.php

@@ -9,6 +9,9 @@
  */
 namespace Magento\Config\Model\Config;
 
+use Magento\Config\Model\ResourceModel\Config\Data\CollectionFactory;
+use Magento\Framework\App\ObjectManager;
+
 /**
  * Class which can read config by paths
  *
@@ -22,15 +25,26 @@ class Loader
      * Config data factory
      *
      * @var \Magento\Framework\App\Config\ValueFactory
+     * @deprecated
+     * @see $collectionFactory
      */
     protected $_configValueFactory;
 
+    /**
+     * @var CollectionFactory
+     */
+    private $collectionFactory;
+
     /**
      * @param \Magento\Framework\App\Config\ValueFactory $configValueFactory
+     * @param ?CollectionFactory $collectionFactory
      */
-    public function __construct(\Magento\Framework\App\Config\ValueFactory $configValueFactory)
-    {
+    public function __construct(
+        \Magento\Framework\App\Config\ValueFactory $configValueFactory,
+        CollectionFactory $collectionFactory = null
+    ) {
         $this->_configValueFactory = $configValueFactory;
+        $this->collectionFactory = $collectionFactory ?: ObjectManager::getInstance()->get(CollectionFactory::class);
     }
 
     /**
@@ -44,9 +58,8 @@ public function __construct(\Magento\Framework\App\Config\ValueFactory $configVa
      */
     public function getConfigByPath($path, $scope, $scopeId, $full = true)
     {
-        $configDataCollection = $this->_configValueFactory->create();
-        $configDataCollection = $configDataCollection->getCollection()->addScopeFilter($scope, $scopeId, $path);
-
+        $configDataCollection = $this->collectionFactory->create();
+        $configDataCollection->addScopeFilter($scope, $scopeId, $path);
         $config = [];
         $configDataCollection->load();
         foreach ($configDataCollection->getItems() as $data) {

lib/internal/Magento/Framework/Model/AbstractModel.php

@@ -511,7 +511,7 @@ public function getResourceCollection()
                 new \Magento\Framework\Phrase('Model collection resource name is not defined.')
             );
         }
-        return $this->_resourceCollection ? clone $this
+        return !$this->_collectionName ? clone $this
             ->_resourceCollection : \Magento\Framework\App\ObjectManager::getInstance()
             ->create(
                 $this->_collectionName