ENGCOM-3430: #4154 - There is no ability to add a tab to product page at a desired position #19007

 - Merge Pull Request #19007 from vasilii-b/magento2:2.3-issue-4154
 - Merged commits:
   1. c91649a
   2. c1d0f31

Author: magento-engcom-team

app/code/Magento/Catalog/Block/Product/View/Details.php

@@ -0,0 +1,48 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+declare(strict_types=1);
+
+/**
+ * Product details block
+ * Holds a group of blocks to show as tabs
+ *
+ * @author     Magento Core Team <[email protected]>
+ */
+
+namespace Magento\Catalog\Block\Product\View;
+
+/**
+ * @api
+ */
+class Details extends \Magento\Framework\View\Element\Template
+{
+    /**
+     * @param string $groupName
+     * @param $callback
+     * @throws \Magento\Framework\Exception\LocalizedException
+     *
+     * @return array
+     */
+    public function getGroupSortedChildNames(string $groupName, $callback): array
+    {
+        $groupChildNames = $this->getGroupChildNames($groupName, $callback);
+        $layout = $this->getLayout();
+
+        $childNamesSortOrder = [];
+
+        foreach ($groupChildNames as $childName) {
+            $alias = $layout->getElementAlias($childName);
+            $sortOrder = (int)$this->getChildData($alias, 'sort_order') ?? 0;
+
+            $childNamesSortOrder[$sortOrder] = $childName;
+        }
+
+        ksort($childNamesSortOrder, SORT_NUMERIC);
+
+        return $childNamesSortOrder;
+    }
+}

app/code/Magento/Catalog/view/frontend/layout/catalog_product_view.xml

@@ -136,19 +136,21 @@
                     </arguments>
                 </block>
             </container>
-            <block class="Magento\Catalog\Block\Product\View\Description" name="product.info.details" template="Magento_Catalog::product/view/details.phtml" after="product.info.media">
+            <block class="Magento\Catalog\Block\Product\View\Details" name="product.info.details" template="Magento_Catalog::product/view/details.phtml" after="product.info.media">
                 <block class="Magento\Catalog\Block\Product\View\Description" name="product.info.description" as="description" template="Magento_Catalog::product/view/attribute.phtml" group="detailed_info">
                     <arguments>
                         <argument name="at_call" xsi:type="string">getDescription</argument>
                         <argument name="at_code" xsi:type="string">description</argument>
                         <argument name="css_class" xsi:type="string">description</argument>
                         <argument name="at_label" xsi:type="string">none</argument>
                         <argument name="title" translate="true" xsi:type="string">Details</argument>
+                        <argument name="sort_order" xsi:type="string">10</argument>
                     </arguments>
                 </block>
                 <block class="Magento\Catalog\Block\Product\View\Attributes" name="product.attributes" as="additional" template="Magento_Catalog::product/view/attributes.phtml" group="detailed_info">
                     <arguments>
                         <argument translate="true" name="title" xsi:type="string">More Information</argument>
+                        <argument name="sort_order" xsi:type="string">20</argument>
                     </arguments>
                 </block>
             </block>

app/code/Magento/Catalog/view/frontend/templates/product/view/details.phtml

@@ -6,8 +6,9 @@
 
 // @codingStandardsIgnoreFile
 
+/** @var \Magento\Catalog\Block\Product\View\Details $block */
 ?>
-<?php if ($detailedInfoGroup = $block->getGroupChildNames('detailed_info', 'getChildHtml')):?>
+<?php if ($detailedInfoGroup = $block->getGroupSortedChildNames('detailed_info', 'getChildHtml')):?>
     <div class="product info detailed">
         <?php $layout = $block->getLayout(); ?>
         <div class="product data items" data-mage-init='{"tabs":{"openedState":"active"}}'>

app/code/Magento/Review/view/frontend/layout/catalog_product_view.xml

@@ -19,6 +19,9 @@
         </referenceContainer>
         <referenceBlock name="product.info.details">
             <block class="Magento\Review\Block\Product\Review" name="reviews.tab" as="reviews" template="Magento_Review::review.phtml" group="detailed_info" ifconfig="catalog/review/active">
+                <arguments>
+                    <argument name="sort_order" xsi:type="string">30</argument>
+                </arguments>
                 <block class="Magento\Review\Block\Form" name="product.review.form" as="review_form" ifconfig="catalog/review/active">
                     <container name="product.review.form.fields.before" as="form_fields_before" label="Review Form Fields Before"/>
                 </block>