refactoring test

Author: konarshankar07

dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/grid/sortBy.test.js

@@ -12,106 +12,63 @@ define([
             });
         });
 
-        describe('"initObservable" method', function () {
-            it('Check for defined ', function () {
-                expect(sortByObj.hasOwnProperty('initObservable')).toBeDefined();
-            });
-            it('Check method type', function () {
-                var type = typeof sortByObj.initObservable;
-
-                expect(type).toEqual('function');
-            });
-            it('Check returned value if method called without arguments', function () {
-                expect(sortByObj.initObservable()).toBeDefined();
-            });
-            it('Check returned value type if method called without arguments', function () {
-                var type = typeof sortByObj.initObservable();
-                expect(type).toEqual('object');
-            });
-        });
-
         describe('"preparedOptions" method', function () {
-            it('Check for defined ', function () {
-                expect(sortByObj.hasOwnProperty('preparedOptions')).toBeDefined();
-            });
-            it('Check method type', function () {
-                var type = typeof sortByObj.preparedOptions;
-                expect(type).toEqual('function');
-            });
-
-            it('Check "options" array is empty if sortable is set false', function () {
+            it('return empty array if sorting is disabled for the columns', function () {
                 var columns = [{
                         sortable: false,
                         label: 'magento',
-                        index: 'test'
+                        index: 'name'
                     }],
-                    expectedValue = [];
+                    options = [];
                 sortByObj.preparedOptions(columns);
-                expect(sortByObj.options).toEqual(expectedValue);
+                expect(sortByObj.options).toEqual(options);
             });
 
-            it('Check "options" array is set the correct value', function () {
+            it('return array of options if sorting is enabled for the columns', function () {
                 var columns = [{
                         sortable: true,
                         label: 'magento',
-                        index: 'test'
+                        index: 'name'
                     }],
-                    expectedValue = [{
-                        value: 'test',
+                    options = [{
+                        value: 'name',
                         label: 'magento'
                     }];
                 sortByObj.preparedOptions(columns);
-                expect(sortByObj.options).toEqual(expectedValue);
+                expect(sortByObj.options).toEqual(options);
             });
 
-            it('Check "isVisible" set true if column is sortable', function () {
+            it('return "isVisible" method true if column is sortable', function () {
                 var columns = [{
                         sortable: true,
                         label: 'magento',
-                        index: 'test'
+                        index: 'name'
                     }];
-                spyOn(sortByObj, "isVisible").and.callFake(function () {
-                    return true;
-                });
                 sortByObj.preparedOptions(columns);
-                expect(sortByObj.isVisible).toHaveBeenCalled();
                 expect(sortByObj.isVisible()).toBeTruthy();
             });
 
-            it('Check "isVisible" set true if column is sortable', function () {
+            it('return "isVisible" method false if column is sortable', function () {
                 var columns = [{
-                    sortable: true,
+                    sortable: false,
                     label: 'magento',
-                    index: 'test'
+                    index: 'name'
                 }];
-                spyOn(sortByObj, "isVisible").and.callFake(function () {
-                    return false;
-                });
                 sortByObj.preparedOptions(columns);
-                expect(sortByObj.isVisible).toHaveBeenCalled();
                 expect(sortByObj.isVisible()).toBeFalsy();
             });
         });
         describe('"applyChanges" method', function () {
-            it('Check for defined ', function () {
-                expect(sortByObj.hasOwnProperty('applyChanges')).toBeDefined();
-            });
-            it('Check method type', function () {
-                var type = typeof sortByObj.applyChanges;
-                expect(type).toEqual('function');
-            });
-
-            it('Check "selectedOption" method has been called', function () {
-                spyOn(sortByObj, 'selectedOption');
+            it('return applied option', function () {
+                var applied = {
+                    field: 'selectedOption',
+                    direction: 'desc'
+                };
+                spyOn(sortByObj, 'selectedOption').and.returnValue('selectedOption');
                 sortByObj.applyChanges();
+                expect(sortByObj.applied()).toEqual(applied);
                 expect(sortByObj.selectedOption).toHaveBeenCalled();
             });
-
-            it('Check "applied" method has been called', function () {
-                spyOn(sortByObj, 'applied');
-                sortByObj.applyChanges();
-                expect(sortByObj.applied).toHaveBeenCalled();
-            });
         });
     });
 });