MC-17865: Finalize @codingStandardsIgnoreFile elimination in CE

Author: OlgaVasyltsun

app/code/Magento/Cms/view/adminhtml/templates/browser/content/uploader.phtml

@@ -8,6 +8,7 @@
 
 $filters = $block->getConfig()->getFilters() ?? [];
 $allowedExtensions = [];
+$blockHtmlId = $block->escapeHtml($block->getHtmlId());
 
 foreach ($filters as $media_type) {
     $allowedExtensions = array_merge($allowedExtensions, array_map(function ($fileExt) {
@@ -24,13 +25,13 @@ $resizeConfig = $block->getImageUploadConfigData()->getIsResizeEnabled()
     : "{action: 'resize'}";
 ?>
 
-<div id="<?= $block->getHtmlId() ?>" class="uploader">
+<div id="<?= /* @noEscape */ $blockHtmlId ?>" class="uploader">
     <span class="fileinput-button form-buttons">
         <span><?= $block->escapeHtml(__('Upload Images')) ?></span>
         <input class="fileupload" type="file" name="<?= $block->escapeHtmlAttr($block->getConfig()->getFileField()) ?>" data-url="<?= $block->escapeUrl($block->getConfig()->getUrl()) ?>" multiple>
     </span>
     <div class="clear"></div>
-    <script type="text/x-magento-template" id="<?= $block->getHtmlId() ?>-template">
+    <script type="text/x-magento-template" id="<?= /* @noEscape */ $blockHtmlId ?>-template">
         <div id="<%- data.id %>" class="file-row">
             <span class="file-info"><%- data.name %> (<%- data.size %>)</span>
             <div class="progressbar-container">
@@ -52,7 +53,7 @@ require([
     var maxFileSize = <?= $block->escapeJs($block->getFileSizeService()->getMaxFileSize()) ?>,
         allowedExtensions = '<?= $block->escapeHtml(implode(' ', $allowedExtensions)) ?>';
 
-    $('#<?= $block->getHtmlId() ?> .fileupload').fileupload({
+    $('#<?= /* @noEscape */ $blockHtmlId ?> .fileupload').fileupload({
         dataType: 'json',
         formData: {
             isAjax: 'true',
@@ -62,9 +63,9 @@ require([
         acceptFileTypes: /(\.|\/)(gif|jpe?g|png)$/i,
         allowedExtensions: allowedExtensions,
         maxFileSize: maxFileSize,
-        dropZone: $('#<?= $block->getHtmlId() ?>').closest('[role="dialog"]'),
+        dropZone: $('#<?= /* @noEscape */ $blockHtmlId ?>').closest('[role="dialog"]'),
         add: function (e, data) {
-            var progressTmpl = mageTemplate('#<?= $block->getHtmlId() ?>-template'),
+            var progressTmpl = mageTemplate('#<?= /* @noEscape */ $blockHtmlId ?>-template'),
                 fileSize,
                 tmpl,
                 validationResult;
@@ -108,7 +109,7 @@ require([
                     }
                 });
 
-                $(tmpl).data('image', data).appendTo('#<?= $block->getHtmlId() ?>');
+                $(tmpl).data('image', data).appendTo('#<?= /* @noEscape */ $blockHtmlId ?>');
 
                 return true;
             });
@@ -145,7 +146,7 @@ require([
         }
     });
 
-    $('#<?= $block->getHtmlId() ?> .fileupload').fileupload('option', {
+    $('#<?= /* @noEscape */ $blockHtmlId ?> .fileupload').fileupload('option', {
         process: [{
             action: 'load',
             fileTypes: /^image\/(gif|jpeg|png)$/,

app/code/Magento/Payment/view/frontend/templates/transparent/form.phtml

@@ -9,7 +9,7 @@ $code = $block->escapeHtml($block->getMethodCode());
 $ccExpMonth = $block->getInfoData('cc_exp_month');
 $ccExpYear = $block->getInfoData('cc_exp_year');
 $ccType = $block->getInfoData('cc_type');
-$content = '<img src=\"' . $block->getViewFileUrl('Magento_Checkout::cvv.png') . '\" alt=\"' .
+$content = '<img src=\"' . $block->escapeUrl($block->getViewFileUrl('Magento_Checkout::cvv.png')) . '\" alt=\"' .
     $block->escapeHtml(__('Card Verification Number Visual Reference')) . '\" title=\"' .
     $block->escapeHtml(__('Card Verification Number Visual Reference')) . '\" />';
 ?>

app/code/Magento/Paypal/view/adminhtml/templates/system/config/fieldset/hint.phtml

@@ -13,7 +13,7 @@ $helpLink = $block->escapeUrl($block->getHelpLink());
 <?php if ($helpLink) : ?>
     <div class="paypal-payment-notice">
         <?= $block->escapeHtml(__('Not sure what PayPal payment method to use? Click ')) ?>
-        <a href="<?= /* @noEscape */$helpLink; ?>" target="_blank"><?= $block->escapeHtml(__('here')) ?></a>
+        <a href="<?= /* @noEscape */ $helpLink; ?>" target="_blank"><?= $block->escapeHtml(__('here')) ?></a>
         <?= $block->escapeHtml(__(' to learn more.')) ?>
     </div>
 <?php endif; ?>

app/code/Magento/UrlRewrite/view/adminhtml/templates/categories.phtml

@@ -22,8 +22,7 @@
             "categoryTree": {
                 "data": <?= /* @noEscape */
                 $this->helper(\Magento\Framework\Json\Helper\Data::class)->jsonEncode($block->getTreeArray()); ?>,
-                "url": "<?= /* @noEscape */
-                $block->escapeUrl($block->getLoadTreeUrl()); ?>"
+                "url": "<?= $block->escapeUrl($block->getLoadTreeUrl()); ?>"
             }
         }
     }

app/code/Magento/UrlRewrite/view/adminhtml/templates/selector.phtml

@@ -15,7 +15,7 @@
             <div class="admin__field-control control">
                 <select data-role="entity-type-selector" class="admin__control-select select" onchange="window.location = this.value;" id="entity-type-selector">
                 <?php foreach ($block->getModes() as $mode => $label) : ?>
-                    <option <?= /* noEscape */ $block->isMode($mode) ? 'selected="selected" ' : '' ?>value="<?= $block->escapeUrl($block->getModeUrl($mode)) ?>"><?= $block->escapeHtml($label) ?></option>
+                    <option <?= /* @noEscape */ $block->isMode($mode) ? 'selected="selected" ' : '' ?>value="<?= $block->escapeUrl($block->getModeUrl($mode)) ?>"><?= $block->escapeHtml($label) ?></option>
                 <?php endforeach; ?>
                 </select>
             </div>

app/code/Magento/Vault/view/frontend/templates/cards_list.phtml

@@ -10,12 +10,12 @@ $tokens = $block->getPaymentTokens();
 <?php if (count($tokens) !== 0) : ?>
     <div class="table-wrapper my-credit-cards">
         <table class="data table table-credit-cards" id="my-orders-table">
-            <caption class="table-caption"><?= /* @noEscape */ __('Stored Payment Methods') ?></caption>
+            <caption class="table-caption"><?= $block->escapeHtml(__('Stored Payment Methods')) ?></caption>
             <thead>
             <tr>
-                <th scope="col" class="col card-number"><?= /* @noEscape */ __('Card Number') ?></th>
-                <th scope="col" class="col expire"><?= /* @noEscape */ __('Expiration Date') ?></th>
-                <th scope="col" class="col card-type"><?= /* @noEscape */ __('Type') ?></th>
+                <th scope="col" class="col card-number"><?= $block->escapeHtml(__('Card Number')) ?></th>
+                <th scope="col" class="col expire"><?= $block->escapeHtml(__('Expiration Date')) ?></th>
+                <th scope="col" class="col card-type"><?= $block->escapeHtml(__('Type')) ?></th>
                 <th scope="col" class="col actions">&nbsp;</th>
             </tr>
             </thead>
@@ -30,5 +30,5 @@ $tokens = $block->getPaymentTokens();
     </div>
 
 <?php elseif (!$block->isExistsCustomerTokens()) : ?>
-    <div class="message info empty"><span><?= /* @noEscape */ __('You have no stored payment methods.') ?></span></div>
+    <div class="message info empty"><span><?= $block->escapeHtml(__('You have no stored payment methods.')) ?></span></div>
 <?php endif ?>