Skip to content

Commit 4f660a1

Browse files
committed
Add action group to configure 'Maximum Login Failures to Lockout Account'
1 parent 3cef881 commit 4f660a1

File tree

6 files changed

+46
-4
lines changed

6 files changed

+46
-4
lines changed
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="AdminExpandSecurityTabActionGroup">
12+
<conditionalClick selector="{{AdminSection.SecurityTab}}" dependentSelector="{{AdminSection.CheckIfTabExpand}}" visible="true" stepKey="openSecurityTab"/>
13+
</actionGroup>
14+
</actionGroups>
15+
16+

app/code/Magento/Config/Test/Mftf/ActionGroup/AdminOpenConfigurationPageActionGroup.xml renamed to app/code/Magento/Config/Test/Mftf/ActionGroup/AdminOpenAdminSectionPageActionGroup.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10-
<actionGroup name="AdminOpenConfigurationPageActionGroup">
11-
<amOnPage url="{{AdminConfigurationAdminSectionPage.url}}" stepKey="goToConfigurationPage"/>
10+
<actionGroup name="AdminOpenAdminSectionPageActionGroup">
11+
<amOnPage url="{{AdminEditAdminSectionPage.url}}" stepKey="goToConfigurationPage"/>
1212
<waitForPageLoad stepKey="waitForPageLoad"/>
1313
</actionGroup>
1414
</actionGroups>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="AdminSetMaximumLoginFailuresToLockoutAccountActionGroup">
12+
<arguments>
13+
<argument name="qty" type="string" defaultValue="5"/>
14+
</arguments>
15+
<uncheckOption selector="{{AdminSection.systemValueForMaximumLoginFailures}}" stepKey="uncheckUseSystemValue"/>
16+
<fillField selector="{{AdminSection.MaximumLoginFailures}}" userInput="{{qty}}" stepKey="setMaximumLoginFailures"/>
17+
<seeInField selector="{{AdminSection.MaximumLoginFailures}}" userInput="{{qty}}" stepKey="seeNewValueInField"/>
18+
</actionGroup>
19+
</actionGroups>
20+

app/code/Magento/Config/Test/Mftf/Page/AdminConfigurationAdminSectionPage.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*/
77
-->
88
<pages xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/PageObject.xsd">
9-
<page name="AdminConfigurationAdminSectionPage" url="admin/system_config/edit/section/admin" module="Magento_Config" area="admin">
9+
<page name="AdminEditAdminSectionPage" url="admin/system_config/edit/section/admin" module="Magento_Config" area="admin">
1010
<section name="AdminSection"/>
1111
</page>
1212
</pages>

app/code/Magento/Config/Test/Mftf/Section/AdminSection.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,7 @@
1313
<element name="SecurityTab" type="button" selector="#admin_security-head"/>
1414
<element name="AdminAccountSharing" type="button" selector="#admin_security_admin_account_sharing"/>
1515
<element name="EnableSystemValue" type="button" selector="#admin_security_admin_account_sharing_inherit"/>
16+
<element name="systemValueForMaximumLoginFailures" type="checkbox" selector="#admin_security_lockout_failures_inherit"/>
17+
<element name="MaximumLoginFailures" type="input" selector="#admin_security_lockout_failures"/>
1618
</section>
1719
</sections>

app/code/Magento/User/Test/Mftf/Test/LockAdminUserEntityTest.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@
3232
</actionGroup>
3333
<actionGroup ref="AdminClickSaveButtonOnUserFormActionGroup" stepKey="saveNewUser"/>
3434

35-
<actionGroup ref="AdminOpenConfigurationPageActionGroup" stepKey="goToConfigurationPage"/>
35+
<!--Configure 'Maximum Login Failures to Lockout Account'-->
36+
<actionGroup ref="AdminOpenAdminSectionPageActionGroup" stepKey="goToConfigurationPage"/>
37+
<actionGroup ref="AdminExpandSecurityTabActionGroup" stepKey="openSecurityTab"/>
38+
<actionGroup ref="AdminSetMaximumLoginFailuresToLockoutAccountActionGroup" stepKey="setMaximumLoginFailures"/>
39+
<actionGroup ref="AdminSaveConfigActionGroup" stepKey="saveCahges"/>
3640

3741
</test>
3842
</tests>

0 commit comments

Comments
 (0)