MC-16618: Eliminate @escapeNotVerified in Sales-related Modules

- Admin static issues

Author: davemacaulay

app/code/Magento/Sales/view/adminhtml/templates/order/create/js.phtml

@@ -3,7 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
- ?>
+?>
 <script>
 require([
     "prototype",

app/code/Magento/Sales/view/adminhtml/templates/order/details.phtml

@@ -44,7 +44,7 @@ $_order = $block->getOrder() ?>
             <td align="center" valign="top" style="padding:3px 9px"><?= (int) $_item->getQtyOrdered()*1 ?></td>
             <td align="right" valign="top" style="padding:3px 9px"><?= /* @noEscape */ $_order->formatPrice($_item->getRowTotal()) ?></td>
         </tr>
-<?php endforeach ?>
+<?php endforeach; ?>
     </tbody>
 
     <tfoot>
@@ -57,7 +57,7 @@ $_order = $block->getOrder() ?>
             <br /><?= $block->escapeHtml(__('Message:')) ?><br /> <?= $block->escapeHtml($_giftMessage->getMessage()) ?>
             </td>
         </tr>
-     <?php endif; ?>
+    <?php endif; ?>
         <tr>
             <td colspan="2" align="right" style="padding:3px 9px"><?= $block->escapeHtml(__('Subtotal')) ?></td>
             <td align="right" style="padding:3px 9px"><?= /* @noEscape */ $_order->formatPrice($_order->getSubtotal()) ?></td>

app/code/Magento/Sales/view/adminhtml/templates/order/totalbar.phtml

@@ -7,11 +7,13 @@
 // @deprecated
 $totals = $block->getTotals();
 ?>
-<?php if ($totals && count($totals) > 0) : ?>
+<?php if ($totals && !empty($totals)) : ?>
 <table class="items-to-invoice">
     <tr>
-    <?php foreach ($totals as $total): ?>
-        <td <?php if ($total['grand']): ?>class="grand-total"<?php endif; ?>>
+    <?php foreach ($totals as $total) : ?>
+        <td <?php if ($total['grand']) :
+            ?>class="grand-total"<?php
+            endif; ?>>
             <?= $block->escapeHtml($total['label']) ?><br />
             <?= $block->escapeHtml($total['value']) ?>
         </td>

app/code/Magento/Sales/view/adminhtml/templates/order/totals/paid.phtml

@@ -4,7 +4,7 @@
  * See COPYING.txt for license details.
  */
 ?>
-<?php if ($block->getCanDisplayTotalPaid()): ?>
+<?php if ($block->getCanDisplayTotalPaid()) : ?>
 <tr>
     <td class="label"><strong><?= $block->escapeHtml(__('Total Paid')) ?></strong></td>
     <td class="emph"><?= /* @noEscape */ $block->displayPriceAttribute('total_paid', true) ?>

app/code/Magento/Sales/view/adminhtml/templates/rss/order/grid/link.phtml

@@ -6,6 +6,6 @@
 
 /** @var $block \Magento\Sales\Block\Adminhtml\Rss\Order\Grid\Link */
 ?>
-<?php if ($block->isRssAllowed() && $block->getLink()): ?>
+<?php if ($block->isRssAllowed() && $block->getLink()) : ?>
 <a href="<?= $block->escapeUrl($block->getLink()) ?>" class="link-feed"><?= $block->escapeHtml($block->getLabel()) ?></a>
 <?php endif; ?>