Skip to content

Commit 547296b

Browse files
ShradddhaShradddha
authored andcommitted
AC-12092:: Remove Deprecations- PhpUnit10 Unit Tests
1 parent e39b04f commit 547296b

File tree

1 file changed

+36
-19
lines changed

1 file changed

+36
-19
lines changed

app/code/Magento/Catalog/Test/Unit/Model/ProductTest.php

Lines changed: 36 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -821,6 +821,9 @@ public function testGetIdentities(
821821
bool $isDeleted = false,
822822
bool $isNew = false
823823
): void {
824+
if (!empty($data['extension_attributes']) && is_callable($data['extension_attributes'])) {
825+
$data['extension_attributes'] = $data['extension_attributes']($this);
826+
}
824827
$this->model->setIdFieldName('id');
825828
if (is_array($origData)) {
826829
foreach ($origData as $key => $value) {
@@ -835,11 +838,7 @@ public function testGetIdentities(
835838
$this->assertEquals($expected, $this->model->getIdentities());
836839
}
837840

838-
/**
839-
* @return array
840-
*/
841-
public function getIdentitiesProvider(): array
842-
{
841+
protected function getMockForExtensionAttribute() {
843842
$extensionAttributesMock = $this->getMockBuilder(ExtensionAttributesInterface::class)
844843
->disableOriginalConstructor()
845844
->addMethods(['getStockItem'])
@@ -848,16 +847,34 @@ public function getIdentitiesProvider(): array
848847
->disableOriginalConstructor()
849848
->getMockForAbstractClass();
850849
$extensionAttributesMock->expects($this->any())->method('getStockItem')->willReturn($stockItemMock);
850+
return $extensionAttributesMock;
851+
}
852+
853+
protected function getMockForStockInterface() {
854+
$stockItemMock = $this->getMockBuilder(StockItemInterface::class)
855+
->disableOriginalConstructor()
856+
->getMockForAbstractClass();
851857
$stockItemMock->expects($this->any())->method('getIsInStock')->willReturn(true);
858+
}
859+
860+
/**
861+
* @return array
862+
*/
863+
public static function getIdentitiesProvider(): array
864+
{
865+
$extensionAttributesMock = static fn (self $testCase)
866+
=> $testCase->getMockForExtensionAttribute();
867+
$stockItemMock = static fn (self $testCase)
868+
=> $testCase->getMockForStockInterface();
852869

853870
return [
854871
'no changes' => [
855872
['cat_p_1'],
856873
['id' => 1, 'name' => 'value', 'category_ids' => [1]],
857874
['id' => 1, 'name' => 'value', 'category_ids' => [1]]
858875
],
859-
'new product' => $this->getNewProductProviderData(),
860-
'new disabled product' => $this->getNewDisabledProductProviderData(),
876+
'new product' => self::getNewProductProviderData(),
877+
'new disabled product' => self::getNewDisabledProductProviderData(),
861878
'status and category change' => [
862879
[0 => 'cat_p_1', 1 => 'cat_c_p_1', 2 => 'cat_c_p_2'],
863880
['id' => 1, 'name' => 'value', 'category_ids' => [1], 'status' => Status::STATUS_DISABLED],
@@ -892,13 +909,13 @@ public function getIdentitiesProvider(): array
892909
['id' => 1, 'name' => 'value', 'category_ids' => [7], 'status' => Status::STATUS_DISABLED],
893910
['id' => 1, 'name' => 'value', 'category_ids' => [7], 'status' => Status::STATUS_ENABLED]
894911
],
895-
'status changed, category unassigned' => $this->getStatusAndCategoryChangesData(),
912+
'status changed, category unassigned' => self::getStatusAndCategoryChangesData(),
896913
'no status changes' => [
897914
[0 => 'cat_p_1'],
898915
['id' => 1, 'name' => 'value', 'category_ids' => [1], 'status' => Status::STATUS_ENABLED],
899916
['id' => 1, 'name' => 'value', 'category_ids' => [1], 'status' => Status::STATUS_ENABLED]
900917
],
901-
'no stock status changes' => $this->getNoStockStatusChangesData($extensionAttributesMock),
918+
'no stock status changes' => self::getNoStockStatusChangesData($extensionAttributesMock),
902919
'no stock status data 1' => [
903920
[0 => 'cat_p_1'],
904921
['id' => 1, 'name' => 'value', 'category_ids' => [1], 'status' => Status::STATUS_ENABLED],
@@ -921,7 +938,7 @@ public function getIdentitiesProvider(): array
921938
'stock_data' => ['is_in_stock' => true]
922939
]
923940
],
924-
'stock status changes for enabled product' => $this->getStatusStockProviderData($extensionAttributesMock),
941+
'stock status changes for enabled product' => self::getStatusStockProviderData($extensionAttributesMock),
925942
'stock status changes for disabled product' => [
926943
[0 => 'cat_p_1'],
927944
['id' => 1, 'name' => 'value', 'category_ids' => [1], 'status' => Status::STATUS_DISABLED],
@@ -940,7 +957,7 @@ public function getIdentitiesProvider(): array
940957
/**
941958
* @return array
942959
*/
943-
private function getStatusAndCategoryChangesData(): array
960+
private static function getStatusAndCategoryChangesData(): array
944961
{
945962
return [
946963
[0 => 'cat_p_1', 1 => 'cat_c_p_5'],
@@ -957,11 +974,11 @@ private function getStatusAndCategoryChangesData(): array
957974
}
958975

959976
/**
960-
* @param MockObject $extensionAttributesMock
977+
* @param $extensionAttributesMock
961978
*
962979
* @return array
963980
*/
964-
private function getNoStockStatusChangesData(MockObject $extensionAttributesMock): array
981+
private static function getNoStockStatusChangesData($extensionAttributesMock): array
965982
{
966983
return [
967984
[0 => 'cat_p_1'],
@@ -971,7 +988,7 @@ private function getNoStockStatusChangesData(MockObject $extensionAttributesMock
971988
'name' => 'value',
972989
'category_ids' => [1],
973990
'status' => Status::STATUS_ENABLED,
974-
'stock_data' => ['is_in_stock' => true],
991+
'stock_data' => ['is_in_stock' => false],
975992
ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY => $extensionAttributesMock
976993
]
977994
];
@@ -980,7 +997,7 @@ private function getNoStockStatusChangesData(MockObject $extensionAttributesMock
980997
/**
981998
* @return array
982999
*/
983-
private function getNewProductProviderData(): array
1000+
private static function getNewProductProviderData(): array
9841001
{
9851002
return [
9861003
['cat_p_1', 'cat_c_p_1', 'cat_p_new'],
@@ -1000,7 +1017,7 @@ private function getNewProductProviderData(): array
10001017
/**
10011018
* @return array
10021019
*/
1003-
private function getNewDisabledProductProviderData(): array
1020+
private static function getNewDisabledProductProviderData(): array
10041021
{
10051022
return [
10061023
['cat_p_1'],
@@ -1019,11 +1036,11 @@ private function getNewDisabledProductProviderData(): array
10191036
}
10201037

10211038
/**
1022-
* @param MockObject $extensionAttributesMock
1039+
* @param $extensionAttributesMock
10231040
*
10241041
* @return array
10251042
*/
1026-
private function getStatusStockProviderData(MockObject $extensionAttributesMock): array
1043+
private static function getStatusStockProviderData($extensionAttributesMock): array
10271044
{
10281045
return [
10291046
[0 => 'cat_p_1', 1 => 'cat_c_p_1'],
@@ -1033,7 +1050,7 @@ private function getStatusStockProviderData(MockObject $extensionAttributesMock)
10331050
'name' => 'value',
10341051
'category_ids' => [1],
10351052
'status' => Status::STATUS_ENABLED,
1036-
'stock_data' => ['is_in_stock' => false],
1053+
'stock_data' => ['is_in_stock' => true],
10371054
ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY => $extensionAttributesMock
10381055
]
10391056
];

0 commit comments

Comments
 (0)