MAGETWO-36337: Not user-friendly behaviour of "Save in address book" check-box inside "Shipping Address" section on "create Order" Admin page

Author: eugene-petrov

app/code/Magento/Sales/Block/Adminhtml/Order/Create/Shipping/Address.php

@@ -81,6 +81,15 @@ public function getIsAsBilling()
      */
     public function getDontSaveInAddressBook()
     {
+        $shippingIsTheSameAsBilling = $this->getIsAsBilling() && $this->getIsShipping();
+        $params = $this->getRequest()->getParams();
+        if ($shippingIsTheSameAsBilling && $params) {
+            $save = $params['order']['billing_address']['save_in_address_book'] ?? false;
+            return !$save;
+        }
+        if ($shippingIsTheSameAsBilling) {
+            return !($this->getIsAsBilling() && $this->getIsShipping());
+        }
         return $this->getIsAsBilling();
     }
 
@@ -121,6 +130,7 @@ public function getAddress()
 
     /**
      * Return is address disabled flag
+     *
      * Return true is the quote is virtual
      *
      * @return bool

app/code/Magento/Sales/view/adminhtml/web/order/create/scripts.js

@@ -259,7 +259,7 @@ define([
             data = data.toObject();
 
             if (type === 'billing' && this.shippingAsBilling) {
-                this.syncAddressField(this.shippingAddressContainer, field.name, field.value);
+                this.syncAddressField(this.shippingAddressContainer, field.name, field);
                 resetShipping = true;
             }
 
@@ -308,7 +308,11 @@ define([
 
             $(container).select('[name="' + syncName + '"]').each(function (element) {
                 if (~['input', 'textarea', 'select'].indexOf(element.tagName.toLowerCase())) {
-                    element.value = fieldValue;
+                    if (element.type === "checkbox") {
+                        element.checked = fieldValue.checked;
+                    } else {
+                        element.value = fieldValue.value;
+                    }
                 }
             });
         },