MC-4538: Convert RegisterCustomerFrontendEntityTest to MFTF

Addressing more review comments

Author: sapanathakur

app/code/Magento/Customer/Test/Mftf/ActionGroup/DeleteCustomerActionGroup.xml

@@ -24,21 +24,23 @@
         <click stepKey="clickOnOk" selector="{{CustomersPageSection.ok}}"/>
         <waitForElementVisible stepKey="waitForSuccessfullyDeletedMessage" selector="{{CustomersPageSection.deletedSuccessMessage}}" time="10"/>
     </actionGroup>
-    <actionGroup name="DeleteNewCustomerByEmailActionGroup">
+    <actionGroup name="DeleteCustomerByEmailActionGroup">
         <arguments>
             <argument name="email" type="string"/>
         </arguments>
         <amOnPage url="{{AdminCustomerPage.url}}" stepKey="navigateToCustomers"/>
         <waitForPageLoad stepKey="waitForAdminCustomerPageLoad"/>
         <click selector="{{AdminCustomerFiltersSection.filtersButton}}" stepKey="clickFilterButton"/>
+        <conditionalClick selector="{{AdminDataGridHeaderSection.clearFilters}}" dependentSelector="{{AdminDataGridHeaderSection.clearFilters}}" visible="true" stepKey="cleanFiltersIfTheySet"/>
         <waitForPageLoad stepKey="waitForClearFilters"/>
-        <fillField selector="{{AdminCustomerFiltersSection.emailInput}}" userInput="{{CustomerEntityOne.email}}" stepKey="filterEmail"/>
+        <fillField selector="{{AdminCustomerFiltersSection.emailInput}}" userInput="{{email}}" stepKey="filterEmail"/>
         <click selector="{{AdminCustomerFiltersSection.apply}}" stepKey="applyFilter"/>
-        <waitForPageLoad stepKey="waitForApplyFilters"/>
-        <checkOption selector="{{CustomersPageSection.customerCheckbox(email)}}" stepKey="seeCustomerEmailInGrid"/>
+        <waitForPageLoad stepKey="waitForPageToLoad"/>
+        <click selector="{{AdminCustomerGridSection.selectFirstRow}}" stepKey="clickOnEditButton1"/>
         <click selector="{{CustomersPageSection.actions}}" stepKey="clickActionsDropdown"/>
         <click selector="{{CustomersPageSection.delete}}" stepKey="clickDelete"/>
+        <waitForElementVisible selector="{{CustomersPageSection.ok}}" stepKey="waitForOkToVisible"/>
         <click selector="{{CustomersPageSection.ok}}" stepKey="clickOkConfirmationButton"/>
-        <waitForElementVisible stepKey="waitForSuccessfullyDeletedMessage" selector="{{CustomersPageSection.deletedSuccessMessage}}" time="10"/>
+        <waitForElementVisible stepKey="waitForSuccessfullyDeletedMessage" selector="{{CustomersPageSection.deletedSuccessMessage}}" time="30"/>
     </actionGroup>
 </actionGroups>

app/code/Magento/Customer/Test/Mftf/Section/AdminCustomerGridSection.xml

@@ -11,5 +11,6 @@
     <section name="AdminCustomerGridSection">
         <element name="customerGrid" type="text" selector="table[data-role='grid']"/>
         <element name="firstRowEditLink" type="text" selector="tr[data-repeat-index='0'] .action-menu-item" timeout="30"/>
+        <element name="selectFirstRow" type="checkbox" selector="//td[@class='data-grid-checkbox-cell']"/>
     </section>
 </sections>

app/code/Magento/Customer/Test/Mftf/Section/CustomersPageSection.xml

@@ -11,9 +11,9 @@
     <section name="CustomersPageSection">
         <element name="addNewCustomerButton" type="button" selector="//*[@id='add']"/>
         <element name="customerCheckbox" type="button" selector="//*[contains(text(),'{{args}}')]/parent::td/preceding-sibling::td/label[@class='data-grid-checkbox-cell-inner']" parameterized="true"/>
-        <element name="actions" type="button" selector="//div[@class='col-xs-2']/div[@class='action-select-wrap']/button[@class='action-select']"/>
-        <element name="delete" type="button" selector="//*[contains(@class,'admin__data-grid-header-row row row-gutter')]//*[text()='Delete']"/>
-        <element name="ok" type="button" selector="//button[@data-role='action']//span[text()='OK']"/>
+        <element name="actions" type="button" selector="//div[@class='col-xs-2']/div[@class='action-select-wrap']/button[@class='action-select']" timeout="30"/>
+        <element name="delete" type="button" selector="//*[contains(@class,'admin__data-grid-header-row row row-gutter')]//*[text()='Delete']" timeout="30"/>
+        <element name="ok" type="button" selector="//button[@data-role='action']//span[text()='OK']" timeout="30"/>
         <element name="deletedSuccessMessage" type="button" selector="//*[@class='message message-success success']"/>
     </section>
 </sections>

app/code/Magento/Customer/Test/Mftf/Section/StorefrontPanelHeaderSection.xml

@@ -10,7 +10,7 @@
         xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
     <section name="StorefrontPanelHeaderSection">
         <element name="WelcomeMessage" type="text" selector=".greet.welcome span"/>
-        <element name="createAnAccountLink" type="select" selector=".panel.header li:nth-child(3)" timeout="30"/>
+        <element name="createAnAccountLink" type="select" selector="//div[@class='panel wrapper']//li/a[contains(.,'Create an Account')]" timeout="30"/>
         <element name="notYouLink" type="button" selector=".greet.welcome span a"/>
         <element name="customerWelcome" type="text" selector=".panel.header .customer-welcome"/>
         <element name="customerWelcomeMenu" type="text" selector=".panel.header .customer-welcome .customer-menu"/>

app/code/Magento/Customer/Test/Mftf/Test/AdminCreateNewCustomerOnStorefrontSignupNewsletterTest.xml

@@ -23,7 +23,7 @@
             <actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
         </before>
         <after>
-            <actionGroup ref="DeleteNewCustomerByEmailActionGroup" stepKey="deleteNewUser">
+            <actionGroup ref="DeleteCustomerByEmailActionGroup" stepKey="deleteNewUser">
                 <argument name="email" value="{{CustomerEntityOne.email}}"/>
             </actionGroup>
             <actionGroup ref="logout" stepKey="logout"/>
@@ -34,7 +34,7 @@
             <argument name="customer" value="CustomerEntityOne" />
         </actionGroup>
 
-        <!--Verify created new customer in grid-->
+        <!--Assert verify created new customer in grid-->
         <amOnPage url="{{AdminCustomerPage.url}}" stepKey="navigateToCustomers"/>
         <waitForPageLoad stepKey="waitForNavigateToCustomersPageLoad"/>
         <click selector="{{AdminCustomerFiltersSection.filtersButton}}" stepKey="clickFilterButton"/>
@@ -44,7 +44,7 @@
         <see selector="{{AdminCustomerGridSection.customerGrid}}" userInput="{{CustomerEntityOne.lastname}}" stepKey="seeAssertCustomerLastNameInGrid"/>
         <see selector="{{AdminCustomerGridSection.customerGrid}}" userInput="{{CustomerEntityOne.email}}" stepKey="seeAssertCustomerEmailInGrid"/>
 
-        <!--Verify created new customer is subscribed to newsletter-->
+        <!--Assert verify created new customer is subscribed to newsletter-->
         <click selector="{{AdminCustomerGridSection.firstRowEditLink}}" stepKey="clickFirstRowEditLink"/>
         <waitForPageLoad stepKey="waitForEditLinkLoad"/>
         <click selector="{{AdminEditCustomerInformationSection.newsLetter}}" stepKey="clickNewsLetter"/>

app/code/Magento/Customer/Test/Mftf/Test/AdminCreateNewCustomerOnStorefrontTest.xml

@@ -23,7 +23,7 @@
             <actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
         </before>
         <after>
-            <actionGroup ref="DeleteNewCustomerByEmailActionGroup" stepKey="deleteNewUser">
+            <actionGroup ref="DeleteCustomerByEmailActionGroup" stepKey="deleteNewUser">
                 <argument name="email" value="{{CustomerEntityOne.email}}"/>
             </actionGroup>
             <actionGroup ref="logout" stepKey="logout"/>