Skip to content

Commit 5722051

Browse files
Merge remote-tracking branch 'magento-l3/ACP2E-1923' into L3-PR-2023-09-06
2 parents 6ebd6b5 + 69627a3 commit 5722051

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

app/code/Magento/SalesRule/Model/Rule/DataProvider.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
use Magento\SalesRule\Model\Rule;
1212

1313
/**
14-
* Class DataProvider
14+
* Data Provider for sales rule form
1515
*/
1616
class DataProvider extends \Magento\Ui\DataProvider\AbstractDataProvider
1717
{
@@ -26,8 +26,6 @@ class DataProvider extends \Magento\Ui\DataProvider\AbstractDataProvider
2626
protected $loadedData;
2727

2828
/**
29-
* Core registry
30-
*
3129
* @var \Magento\Framework\Registry
3230
*/
3331
protected $coreRegistry;
@@ -103,6 +101,8 @@ public function getData()
103101
$rule->setDiscountQty($rule->getDiscountQty() * 1);
104102

105103
$this->loadedData[$rule->getId()] = $rule->getData();
104+
$labels = $rule->getStoreLabels();
105+
$this->loadedData[$rule->getId()]['store_labels'] = $labels;
106106
}
107107
$data = $this->dataPersistor->get('sale_rule');
108108
if (!empty($data)) {

app/code/Magento/SalesRule/Test/Unit/Model/Rule/DataProviderTest.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,11 @@ protected function setUp(): void
8989
public function testGetData()
9090
{
9191
$ruleId = 42;
92-
$ruleData = ['name' => 'Sales Price Rule'];
92+
$ruleData = ['name' => 'Sales Price Rule', 'store_labels' => ['1' => 'Store Label']];
9393

9494
$ruleMock = $this->getMockBuilder(Rule::class)
95-
->addMethods(['getDiscountAmount', 'setDiscountAmount', 'getDiscountQty', 'setDiscountQty'])
96-
->onlyMethods(['load', 'getId', 'getData'])
95+
->addMethods(['getDiscountAmount', 'setDiscountAmount', 'getDiscountQty', 'setDiscountQty',])
96+
->onlyMethods(['load', 'getId', 'getData', 'getStoreLabels'])
9797
->disableOriginalConstructor()
9898
->getMock();
9999
$this->collectionMock->expects($this->once())->method('getItems')->willReturn([$ruleMock]);
@@ -105,6 +105,7 @@ public function testGetData()
105105
$ruleMock->expects($this->once())->method('setDiscountAmount')->with(50)->willReturn($ruleMock);
106106
$ruleMock->expects($this->once())->method('getDiscountQty')->willReturn(20.010);
107107
$ruleMock->expects($this->once())->method('setDiscountQty')->with(20.01)->willReturn($ruleMock);
108+
$ruleMock->expects($this->once())->method('getStoreLabels')->willReturn(["1" => "Store Label"]);
108109

109110
$this->assertEquals([$ruleId => $ruleData], $this->model->getData());
110111
// Load from object-cache the second time

0 commit comments

Comments
 (0)