Skip to content

Commit 5764991

Browse files
MAGETWO-56849: Clean Up JS files code styles based on black list
1 parent ab4f4c4 commit 5764991

File tree

12 files changed

+26
-55
lines changed

12 files changed

+26
-55
lines changed

app/code/Magento/Checkout/view/frontend/web/js/view/cart/shipping-rates.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,10 @@ define([
2424
shippingRates: shippingService.getShippingRates(),
2525
shippingRateGroups: ko.observableArray([]),
2626
selectedShippingMethod: ko.computed(function () {
27-
return quote.shippingMethod() ?
28-
quote.shippingMethod()['carrier_code'] + '_' + quote.shippingMethod()['method_code'] :
29-
null;
30-
}
31-
),
27+
return quote.shippingMethod() ?
28+
quote.shippingMethod()['carrier_code'] + '_' + quote.shippingMethod()['method_code'] :
29+
null;
30+
}),
3231

3332
/**
3433
* @override

app/code/Magento/Checkout/view/frontend/web/js/view/shipping-information/list.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ define([
7171
} else {
7272
// rendererTemplates are provided via layout
7373
rendererTemplate = address.getType() != undefined && this.rendererTemplates[address.getType()] != undefined ? //eslint-disable-line
74-
utils.extend({}, defaultRendererTemplate, this.rendererTemplates[address.getType()]) :
75-
defaultRendererTemplate;
74+
utils.extend({}, defaultRendererTemplate, this.rendererTemplates[address.getType()]) :
75+
defaultRendererTemplate;
7676
templateData = {
7777
parentName: this.name,
7878
name: address.getType()

app/code/Magento/Checkout/view/frontend/web/js/view/shipping.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,11 +204,10 @@ define([
204204
rates: shippingService.getShippingRates(),
205205
isLoading: shippingService.isLoading,
206206
isSelected: ko.computed(function () {
207-
return quote.shippingMethod() ?
208-
quote.shippingMethod()['carrier_code'] + '_' + quote.shippingMethod()['method_code'] :
209-
null;
210-
}
211-
),
207+
return quote.shippingMethod() ?
208+
quote.shippingMethod()['carrier_code'] + '_' + quote.shippingMethod()['method_code'] :
209+
null;
210+
}),
212211

213212
/**
214213
* @param {Object} shippingMethod

app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/product-grid.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,8 +312,8 @@ define([
312312

313313
if (this.callbackName == 'appendProducts') { //eslint-disable-line eqeqeq
314314
selectedRows = _.filter(this.productsProvider().data.items, function (row) {
315-
return selected.indexOf(row['entity_id']) !== -1;
316-
});
315+
return selected.indexOf(row['entity_id']) !== -1;
316+
});
317317
selectedVariationKeys = _.values(this._getVariationKeyMap(selectedRows));
318318
this._disableRows(this.productsProvider().data.items, selectedVariationKeys, selected);
319319
}

app/code/Magento/Customer/view/adminhtml/web/edit/tab/js/addresses.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@ define([
2828
formsSelector: '[data-container="address-forms"]',
2929
addAddressSelector: '[data-container="add-address"]',
3030
formFirstNameSelector: ':input' +
31-
'[data-ui-id="adminhtml-edit-tab-addresses-fieldset-element-text-address-template-firstname"]',
31+
'[data-ui-id="adminhtml-edit-tab-addresses-fieldset-element-text-address-template-firstname"]',
3232
accountFirstNameSelector: ':input' +
33-
'[data-ui-id="adminhtml-edit-tab-account-fieldset-element-text-account-firstname"]',
33+
'[data-ui-id="adminhtml-edit-tab-account-fieldset-element-text-account-firstname"]',
3434
formLastNameSelector: ':input' +
35-
'[data-ui-id="adminhtml-edit-tab-addresses-fieldset-element-text-address-template-lastname"]',
35+
'[data-ui-id="adminhtml-edit-tab-addresses-fieldset-element-text-address-template-lastname"]',
3636
accountLastNameSelector: ':input' +
37-
'[data-ui-id="adminhtml-edit-tab-account-fieldset-element-text-account-lastname"]',
37+
'[data-ui-id="adminhtml-edit-tab-account-fieldset-element-text-account-lastname"]',
3838
accountWebsiteIdSelector: ':input' +
39-
'[data-ui-id="store-switcher-form-renderer-fieldset-element-select-account-website-id"]',
39+
'[data-ui-id="store-switcher-form-renderer-fieldset-element-select-account-website-id"]',
4040
formCountrySelector: 'customer-edit-tab-addresses-fieldset-element-form-field-country-id',
4141
addAddressButtonSelector: ':button[data-ui-id="adminhtml-edit-tab-addresses-add-address-button"]'
4242
},

app/code/Magento/Customer/view/frontend/web/js/zxcvbn.js

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/OfflinePayments/view/frontend/web/js/view/payment/method-renderer/purchaseorder-method.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ define([
3333
'po_number': this.purchaseOrderNumber(),
3434
'additional_data': null
3535
};
36-
3736
},
3837

3938
/**

lib/web/mage/adminhtml/accordion.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ define([
1919

2020
this.containerId = containerId;
2121
this.activeOnlyOne = activeOnlyOne || false;
22-
this.container = $(this.containerId);
23-
this.items = $$('#' + this.containerId + ' dt');
24-
this.loader = new varienLoader(true); //jscs:ignore requireCapitalizedConstructors
22+
this.container = $(this.containerId);
23+
this.items = $$('#' + this.containerId + ' dt');
24+
this.loader = new varienLoader(true); //jscs:ignore requireCapitalizedConstructors
2525

2626
links = $$('#' + this.containerId + ' dt a');
2727

lib/web/mage/adminhtml/form.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -321,14 +321,6 @@ define([
321321
this.lastCountryId = '';
322322
}
323323
this.setMarkDisplay(this.regionSelectEl, false);
324-
325-
// clone required stuff from select element and then remove it
326-
// this._regionSelectEl.className = this.regionSelectEl.className;
327-
// this._regionSelectEl.name = this.regionSelectEl.name;
328-
// this._regionSelectEl.id = this.regionSelectEl.id;
329-
// this._regionSelectEl.innerHTML = this.regionSelectEl.innerHTML;
330-
// Element.remove(this.regionSelectEl);
331-
// this.regionSelectEl = null;
332324
}
333325
varienGlobalEvents.fireEvent('address_country_changed', this.countryEl);
334326
this._checkRegionRequired();

lib/web/mage/adminhtml/grid.js

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -340,23 +340,6 @@ define([
340340
location.href = url;
341341
},
342342

343-
/*_processComplete : function(transport){
344-
console.log(transport);
345-
if (transport && transport.responseText){
346-
try{
347-
response = eval('(' + transport.responseText + ')');
348-
}
349-
catch (e) {
350-
response = {};
351-
}
352-
}
353-
if (response.ajaxExpired && response.ajaxRedirect) {
354-
location.href = response.ajaxRedirect;
355-
return false;
356-
}
357-
this.initGrid();
358-
},*/
359-
360343
/**
361344
* @private
362345
*/

0 commit comments

Comments
 (0)