Skip to content

Commit 597cbaf

Browse files
Indrani SonawaneIndrani Sonawane
authored andcommitted
Fixed new review comments
1 parent f64f9fb commit 597cbaf

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

app/code/Magento/Catalog/Helper/Product/View.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ public function prepareAndRender(ResultPage $resultPage, $productId, $controller
302302
* @param string $title
303303
* @return string
304304
*/
305-
private function addConfigValues($title): string
305+
private function addConfigValues(string $title): string
306306
{
307307
$preparedTitle = $this->scopeConfig->getValue(
308308
'design/head/title_prefix',

app/code/Magento/ConfigurableProduct/Model/LinkManagement.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ class LinkManagement implements \Magento\ConfigurableProduct\Api\LinkManagementI
5757
/**
5858
* @var ProductAttributeMediaGalleryEntryInterfaceFactory|mixed
5959
*/
60-
public \Magento\Catalog\Api\Data\ProductAttributeMediaGalleryEntryInterfaceFactory $myModelFactory;
60+
private \Magento\Catalog\Api\Data\ProductAttributeMediaGalleryEntryInterfaceFactory $myModelFactory;
6161

6262
/**
6363
* Constructor
@@ -136,7 +136,7 @@ public function getChildren($sku)
136136
* @param array $images
137137
* @return array
138138
*/
139-
public function getMediaEntries($images): array
139+
public function getMediaEntries(array $images): array
140140
{
141141
$media = $this->myModelFactory->create();
142142
$mediaGalleryEntries=[];

0 commit comments

Comments
 (0)