MC-13825: [2.4.x] Migrate ZF2 components to Laminas

Author: fascinosum

app/code/Magento/CacheInvalidate/Model/PurgeCache.php

@@ -8,7 +8,7 @@
 use Magento\Framework\Cache\InvalidateLogger;
 
 /**
- * Class PurgeCache
+ * PurgeCache model
  */
 class PurgeCache
 {

app/code/Magento/CacheInvalidate/Model/SocketFactory.php

@@ -3,11 +3,18 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\CacheInvalidate\Model;
 
+/**
+ * Factory for the \Laminas\Http\Client\Adapter\Socket
+ */
 class SocketFactory
 {
     /**
+     * Create object
+     *
      * @return \Laminas\Http\Client\Adapter\Socket
      */
     public function create()

app/code/Magento/Captcha/Model/ResourceModel/Log.php

@@ -13,7 +13,7 @@
 class Log extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb
 {
     /**
-     * Type Remote Address
+     * Remote Address log type
      */
     const TYPE_REMOTE_ADDRESS = 1;
 

app/code/Magento/Catalog/Controller/Product/Frontend/Action/Synchronize.php

@@ -7,12 +7,13 @@
 
 use Magento\Catalog\Model\Product\ProductFrontendAction\Synchronizer;
 use Magento\Framework\App\Action\Context;
+use Magento\Framework\App\Action\HttpPostActionInterface;
 use Magento\Framework\Controller\Result\JsonFactory;
 
 /**
  * Synchronizes Product Frontend Actions with database
  */
-class Synchronize extends \Magento\Framework\App\Action\Action
+class Synchronize extends \Magento\Framework\App\Action\Action implements HttpPostActionInterface
 {
     /**
      * @var Context
@@ -46,6 +47,8 @@ public function __construct(
     }
 
     /**
+     * @inheritDoc
+     *
      * This is handle for synchronizing between frontend and backend product actions:
      *  - visit product page (recently_viewed)
      *  - compare products (recently_compared)
@@ -57,9 +60,6 @@ public function __construct(
      *      'added_at' => "JS_TIMESTAMP"
      *  ]
      * ]
-     *
-     *
-     * @inheritdoc
      */
     public function execute()
     {

app/code/Magento/Checkout/Model/Cart/RequestQuantityProcessor.php

@@ -9,6 +9,9 @@
 
 use Magento\Framework\Locale\ResolverInterface;
 
+/**
+ * Cart request quantity processor
+ */
 class RequestQuantityProcessor
 {
     /**

app/code/Magento/Downloadable/Setup/Patch/Data/AddDownloadableHostsConfig.php

@@ -7,21 +7,22 @@
 
 namespace Magento\Downloadable\Setup\Patch\Data;
 
+use Laminas\Uri\Uri as UriHandler;
+use Magento\Backend\App\Area\FrontNameResolver;
 use Magento\Config\Model\Config\Backend\Admin\Custom;
+use Magento\Downloadable\Api\DomainManagerInterface as DomainManager;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\Exception\NoSuchEntityException;
+use Magento\Framework\Setup\ModuleDataSetupInterface;
 use Magento\Framework\Setup\Patch\DataPatchInterface;
+use Magento\Framework\Url\ScopeResolverInterface;
 use Magento\Framework\UrlInterface;
 use Magento\Store\Model\ScopeInterface;
 use Magento\Store\Model\Store;
-use Laminas\Uri\Uri as UriHandler;
-use Magento\Framework\Url\ScopeResolverInterface;
-use Magento\Downloadable\Api\DomainManagerInterface as DomainManager;
-use Magento\Framework\Setup\ModuleDataSetupInterface;
-use Magento\Backend\App\Area\FrontNameResolver;
 
 /**
  * Adding base url as allowed downloadable domain.
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class AddDownloadableHostsConfig implements DataPatchInterface
 {
@@ -79,7 +80,7 @@ public function __construct(
     }
 
     /**
-     * @inheritdoc
+     * @inheritDoc
      */
     public function apply()
     {

app/code/Magento/Integration/Test/Unit/Model/Oauth/ConsumerTest.php

@@ -111,8 +111,8 @@ protected function setUp()
         );
 
         $this->validDataArray = [
-            'key' => md5(uniqid()),
-            'secret' => md5(uniqid()),
+            'key' => md5(uniqid()), // phpcs:ignore Magento2.Security.InsecureFunction
+            'secret' => md5(uniqid()), // phpcs:ignore Magento2.Security.InsecureFunction
             'callback_url' => 'http://example.com/callback',
             'rejected_callback_url' => 'http://example.com/rejectedCallback'
         ];

app/code/Magento/PageCache/Model/App/FrontController/BuiltinPlugin.php

@@ -53,6 +53,8 @@ public function __construct(
     }
 
     /**
+     * Add PageCache functionality to Dispatch method
+     *
      * @param \Magento\Framework\App\FrontControllerInterface $subject
      * @param callable $proceed
      * @param \Magento\Framework\App\RequestInterface $request

app/code/Magento/PageCache/Test/Unit/Model/Cache/ServerTest.php

@@ -23,6 +23,9 @@ class ServerTest extends \PHPUnit\Framework\TestCase
     /** @var \PHPUnit_Framework_MockObject_MockObject | \Magento\Framework\UrlInterface */
     protected $urlBuilderMock;
 
+    /** @var \PHPUnit_Framework_MockObject_MockObject| \Magento\Framework\Cache\InvalidateLogger */
+    private $loggerMock;
+
     protected function setUp()
     {
         $this->configMock = $this->createMock(\Magento\Framework\App\DeploymentConfig::class);

app/code/Magento/Quote/Model/Quote/Item/Updater.php

@@ -8,12 +8,11 @@
 use Magento\Catalog\Model\ProductFactory;
 use Magento\Framework\Locale\FormatInterface;
 use Magento\Framework\DataObject\Factory as ObjectFactory;
-use Magento\Quote\Model\Quote;
 use Magento\Quote\Model\Quote\Item;
 use Laminas\Code\Exception\InvalidArgumentException;
 
 /**
- * Class Updater
+ * Quote item updater
  */
 class Updater
 {