Skip to content

Commit 5aa97c4

Browse files
committed
MC-16618: Eliminate @escapeNotVerified in Sales-related Modules
- Resolve admin attribute issues
1 parent 142efda commit 5aa97c4

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

app/code/Magento/Sales/view/adminhtml/templates/items/column/name.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<dt><?= $block->escapeHtml($_option['label']) ?>:</dt>
2525
<dd>
2626
<?php if (isset($_option['custom_view']) && $_option['custom_view']) : ?>
27-
<?= $block->escapeHtml($block->getCustomizedOptionValue($_option)) ?>
27+
<?= /* @noEscape */ $block->getCustomizedOptionValue($_option) ?>
2828
<?php else : ?>
2929
<?php $_option = $block->getFormattedOption($_option['value']); ?>
3030
<?php $dots = 'dots' . uniqid(); ?>

app/code/Magento/Sales/view/adminhtml/templates/order/create/form/account.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
/** @var $block \Magento\Sales\Block\Adminhtml\Order\Create\Form\Account */
88
?>
99

10-
<div class="admin__page-section-title <?= $block->escapeHtmlAttr($block->getHeaderCssClass()) ?>">
10+
<div class="admin__page-section-title <?= /* @noEscape */ $block->getHeaderCssClass() ?>">
1111
<span class="title"><?= $block->escapeHtml($block->getHeaderText()) ?></span>
1212
<div class="actions"></div>
1313
</div>

app/code/Magento/Sales/view/adminhtml/templates/order/create/form/address.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ else :
4646
endif; ?>
4747

4848
<fieldset class="admin__fieldset">
49-
<legend class="admin__legend <?= $block->escapeHtmlAttr($block->getHeaderCssClass()) ?>">
49+
<legend class="admin__legend <?= /* @noEscape */ $block->getHeaderCssClass() ?>">
5050
<span><?= $block->escapeHtml($block->getHeaderText()) ?></span>
5151
</legend><br>
5252

app/code/Magento/Sales/view/adminhtml/templates/order/totals.phtml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
<?= $block->getChildHtml($_total->getBlockName(), false) ?>
1717
<?php else : ?>
1818
<tr class="col-<?= $block->escapeHtmlAttr($_code) ?>">
19-
<td <?= $block->escapeHtmlAttr($block->getLabelProperties()) ?> class="label">
19+
<td <?= /* @noEscape */ $block->getLabelProperties() ?> class="label">
2020
<strong><?= $block->escapeHtml($_total->getLabel()) ?></strong>
2121
</td>
22-
<td <?= $block->escapeHtmlAttr($block->getValueProperties()) ?>>
22+
<td <?= /* @noEscape */ $block->getValueProperties() ?>>
2323
<strong><?= /* @noEscape */ $block->formatValue($_total) ?></strong>
2424
</td>
2525
</tr>
@@ -45,11 +45,11 @@
4545
</td>
4646

4747
<?php if ($_total->getStrong()) : ?>
48-
<td <?= $block->escapeHtmlAttr($block->getValueProperties()) ?>>
48+
<td <?= /* @noEscape */ $block->getValueProperties() ?>>
4949
<strong><?= /* @noEscape */ $block->formatValue($_total) ?></strong>
5050
</td>
5151
<?php else : ?>
52-
<td <?= $block->escapeHtmlAttr($block->getValueProperties()) ?>>
52+
<td <?= /* @noEscape */ $block->getValueProperties() ?>>
5353
<span><?= /* @noEscape */ $block->formatValue($_total) ?></span>
5454
</td>
5555
<?php endif; ?>

app/code/Magento/Sales/view/adminhtml/templates/order/view/items/renderer/default.phtml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
$lastItemNumber = count($columns) ?>
1414
<?php foreach ($columns as $columnName => $columnClass) : ?>
1515
<?php $i++; ?>
16-
<td class="<?= /* @noEscape */ $columnClass ?><?= /* @noEscape */ ($i === $lastItemNumber ? ' last' : '') ?>"><?= $block->getColumnHtml($_item, $columnName) ?></td>
16+
<td class="<?= /* @noEscape */ $columnClass ?><?= /* @noEscape */ ($i === $lastItemNumber ? ' last' : '') ?>">
17+
<?= $block->getColumnHtml($_item, $columnName) ?>
18+
</td>
1719
<?php endforeach; ?>
1820
</tr>

0 commit comments

Comments
 (0)