Skip to content

Commit 5c478f1

Browse files
JhalakMathurManjusha.S
authored andcommitted
Feedback changes
1 parent 7aa938a commit 5c478f1

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

app/code/Magento/Multishipping/Test/Mftf/Test/StoreFrontVerifyMultishippingCheckoutForVirtualProductTest.xml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,9 @@
8484
<actionGroup ref="StorefrontCheckoutWithMultipleAddressesActionGroup" stepKey="checkoutWithMultipleAddresses"/>
8585

8686
<!-- Check Ship to Multiple Address Page is opened-->
87-
<wait time="10" stepKey="waitForAddressPage"/>
87+
88+
<waitForPageLoad stepKey="waitForAddressPage"/>
89+
8890
<seeInCurrentUrl url="{{MultishippingCheckoutAddressesPage.url}}" stepKey="seeShiptoMultipleAddressesPageIsOpened"/>
8991

9092
<!-- Assert Simple product has address in Send To section-->
@@ -108,8 +110,9 @@
108110
<seeInCurrentUrl url="{{MultishippingCheckoutShippingPage.url}}" stepKey="seeSelectShippingMethodPageIsOpened"/>
109111

110112

111-
<!-- Halt test execution for 10 seconds before continuing. -->
112-
<wait time="10" stepKey="waitForElement"/>
113+
<!-- wait for selector -->
114+
<waitForElement selector="{{StorefrontMultishippingCheckoutAddressesToolbarSection.shippingmethods($$createSimpleProduct.name$$)}}" stepKey="waitForShippingMethodsVisible"/>
115+
113116
<!-- See Shipping Method available ONLY for Simple product-->
114117
<seeElement selector="{{StorefrontMultishippingCheckoutAddressesToolbarSection.shippingmethods($$createSimpleProduct.name$$)}}" stepKey="ShippingMethodForSimpleProduct"/>
115118

@@ -121,7 +124,6 @@
121124
<waitForPageLoad stepKey="waitForCheckoutShippingToolbarPageLoad"/>
122125

123126
<!-- See Billing Information Page is opened-->
124-
<wait time="10" stepKey="waitForUrl"/>
125127
<seeInCurrentUrl url="{{MultishippingCheckoutBillingPage.url}}" stepKey="seeBillingPageIsOpened"/>
126128

127129
<!-- Check Page contains customer's billing address-->
@@ -135,7 +137,9 @@
135137
<conditionalClick selector="{{StorefrontMultishippingCheckoutAddressesToolbarSection.checkmoneyorder}}" dependentSelector="{{StorefrontMultishippingCheckoutAddressesToolbarSection.checkmoneyorder}}" visible="true" stepKey="selectCheckmoPaymentMethod"/>
136138

137139
<!-- Select Payment method e.g. "Check / Money Order" and click Go to Review Your Order -->
138-
<wait time="10" stepKey="waitforReviewOrderButton"/>
140+
141+
<waitForElement selector="{{StorefrontMultishippingCheckoutBillingToolbarSection.goToReviewOrder}}" stepKey="waitForElementgoToReviewOrder"/>
142+
139143
<click selector="{{StorefrontMultishippingCheckoutBillingToolbarSection.goToReviewOrder}}" stepKey="clickGoToReviewOrder"/>
140144

141145

@@ -179,3 +183,4 @@
179183
</test>
180184
</tests>
181185

186+

0 commit comments

Comments
 (0)