Skip to content

Commit 5c57dc2

Browse files
committed
Make sure that the new dependancy on Serializer\Json is the last thing in the constructor
1 parent eb31f86 commit 5c57dc2

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

app/code/Magento/Checkout/Block/Cart/Shipping.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ class Shipping extends \Magento\Checkout\Block\Cart\AbstractCart
3131
* @param \Magento\Checkout\Model\Session $checkoutSession
3232
* @param \Magento\Checkout\Model\CompositeConfigProvider $configProvider
3333
* @param array $layoutProcessors
34-
* @param \Magento\Framework\Serialize\Serializer\Json|null $serializer
3534
* @param array $data
35+
* @param \Magento\Framework\Serialize\Serializer\Json|null $serializer
3636
* @throws \RuntimeException
3737
*/
3838
public function __construct(
@@ -41,8 +41,8 @@ public function __construct(
4141
\Magento\Checkout\Model\Session $checkoutSession,
4242
\Magento\Checkout\Model\CompositeConfigProvider $configProvider,
4343
array $layoutProcessors = [],
44-
\Magento\Framework\Serialize\Serializer\Json $serializer = null,
45-
array $data = []
44+
array $data = [],
45+
\Magento\Framework\Serialize\Serializer\Json $serializer = null
4646
) {
4747
$this->configProvider = $configProvider;
4848
$this->layoutProcessors = $layoutProcessors;

app/code/Magento/Checkout/Block/Cart/Sidebar.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ class Sidebar extends AbstractCart
3838
* @param \Magento\Checkout\Model\Session $checkoutSession
3939
* @param \Magento\Catalog\Helper\Image $imageHelper
4040
* @param \Magento\Customer\CustomerData\JsLayoutDataProviderPoolInterface $jsLayoutDataProvider
41-
* @param \Magento\Framework\Serialize\Serializer\Json|null $serializer
4241
* @param array $data
42+
* @param \Magento\Framework\Serialize\Serializer\Json|null $serializer
4343
* @throws \RuntimeException
4444
*/
4545
public function __construct(
@@ -48,8 +48,8 @@ public function __construct(
4848
\Magento\Checkout\Model\Session $checkoutSession,
4949
\Magento\Catalog\Helper\Image $imageHelper,
5050
\Magento\Customer\CustomerData\JsLayoutDataProviderPoolInterface $jsLayoutDataProvider,
51-
\Magento\Framework\Serialize\Serializer\Json $serializer = null,
52-
array $data = []
51+
array $data = [],
52+
\Magento\Framework\Serialize\Serializer\Json $serializer = null
5353
) {
5454
if (isset($data['jsLayout'])) {
5555
$this->jsLayout = array_merge_recursive($jsLayoutDataProvider->getData(), $data['jsLayout']);

app/code/Magento/Checkout/Block/Onepage.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,17 @@ class Onepage extends \Magento\Framework\View\Element\Template
4646
* @param \Magento\Framework\Data\Form\FormKey $formKey
4747
* @param \Magento\Checkout\Model\CompositeConfigProvider $configProvider
4848
* @param array $layoutProcessors
49-
* @param \Magento\Framework\Serialize\Serializer\Json|null $serializer
5049
* @param array $data
50+
* @param \Magento\Framework\Serialize\Serializer\Json|null $serializer
5151
* @throws \RuntimeException
5252
*/
5353
public function __construct(
5454
\Magento\Framework\View\Element\Template\Context $context,
5555
\Magento\Framework\Data\Form\FormKey $formKey,
5656
\Magento\Checkout\Model\CompositeConfigProvider $configProvider,
5757
array $layoutProcessors = [],
58-
\Magento\Framework\Serialize\Serializer\Json $serializer = null,
59-
array $data = []
58+
array $data = [],
59+
\Magento\Framework\Serialize\Serializer\Json $serializer = null
6060
) {
6161
parent::__construct($context, $data);
6262
$this->formKey = $formKey;

app/code/Magento/Checkout/Test/Unit/Block/Cart/ShippingTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ protected function setUp()
8282
$this->checkoutSession,
8383
$this->configProvider,
8484
[$this->layoutProcessor],
85-
$this->serializer,
86-
['jsLayout' => $this->layout]
85+
['jsLayout' => $this->layout],
86+
$this->serializer
8787
);
8888
}
8989

app/code/Magento/Checkout/Test/Unit/Block/OnepageTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ protected function setUp()
6666
$this->formKeyMock,
6767
$this->configProviderMock,
6868
[$this->layoutProcessorMock],
69-
$this->serializer,
70-
[]
69+
[],
70+
$this->serializer
7171
);
7272
}
7373

0 commit comments

Comments
 (0)