Changed the admin integration file with custom role

Author: Krishna Kumar

dev/tests/api-functional/testsuite/Magento/GraphQl/LoginAsCustomer/GenerateLoginCustomerTokenTest.php

@@ -56,7 +56,7 @@ public function testGenerateCustomerValidTokenLoginAsCustomerEnabled()
             $mutation,
             [],
             '',
-            $this->getAdminHeaderAuthentication('TestAdmin1', 'Magento777')
+            $this->getAdminHeaderAuthentication('TestAdmin1', \Magento\TestFramework\Bootstrap::ADMIN_PASSWORD)
         );
         $this->assertArrayHasKey('generateCustomerTokenAsAdmin', $response);
         $this->assertIsArray($response['generateCustomerTokenAsAdmin']);
@@ -82,7 +82,7 @@ public function testGenerateCustomerValidTokenLoginAsCustomerDisabled()
             $mutation,
             [],
             '',
-            $this->getAdminHeaderAuthentication('TestAdmin1', 'Magento777')
+            $this->getAdminHeaderAuthentication('TestAdmin1', \Magento\TestFramework\Bootstrap::ADMIN_PASSWORD)
         );
     }
 
@@ -151,7 +151,7 @@ public function dataProviderInvalidInfo(): array
         return [
             'invalid_admin_user_name' => [
                 'TestAdmin(^%',
-                'Magento777',
+                \Magento\TestFramework\Bootstrap::ADMIN_PASSWORD,
                 '[email protected]',
                 'The account sign-in was incorrect or your account is disabled temporarily. ' .
                 'Please wait and try again later.'
@@ -195,7 +195,7 @@ private function getQuery(string $customerEmail) : string
      */
     public function getCustomerHeaderAuthentication(
         string $username = '[email protected]',
-        string $password = 'Magento777'
+        string $password = \Magento\TestFramework\Bootstrap::ADMIN_PASSWORD
     ): array {
         $customerToken = $this->customerTokenService->createCustomerAccessToken($username, $password);
 

dev/tests/integration/testsuite/Magento/LoginAsCustomer/_files/admin.php

@@ -3,30 +3,38 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-use Magento\User\Model\UserFactory;
-use Magento\User\Model\ResourceModel\User as UserResource;
 
-$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+declare(strict_types=1);
 
-/** @var UserFactory $userFactory */
-$userFactory = $objectManager->get(UserFactory::class);
-/** @var UserResource $userResource */
-$userResource = $objectManager->get(UserResource::class);
+use Magento\Authorization\Model\RoleFactory;
+use Magento\Authorization\Model\Role;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\User\Model\User;
+use Magento\Authorization\Model\RulesFactory;
+use Magento\Authorization\Model\Rules;
 
-$adminInfo = [
-    'username'  => 'TestAdmin1',
-    'firstname' => 'test',
-    'lastname'  => 'test',
-    'email'     => '[email protected]',
-    'password'  =>'Magento777',
-    'interface_locale' => 'en_US',
-    'is_active' => 1
-];
+//Creating a new admin user with a custom role to safely change role settings without affecting the main user's role.
+/** @var Role $role */
+$role = Bootstrap::getObjectManager()->get(RoleFactory::class)->create();
+$role->setName('test_custom_role');
+$role->setData('role_name', $role->getName());
+$role->setRoleType(\Magento\Authorization\Model\Acl\Role\Group::ROLE_TYPE);
+$role->setUserType((string)\Magento\Authorization\Model\UserContextInterface::USER_TYPE_ADMIN);
+$role->save();
+/** @var Rules $rules */
+$rules = Bootstrap::getObjectManager()->get(RulesFactory::class)->create();
+$rules->setRoleId($role->getId());
+//Granted all permissions.
+$rules->setResources([Bootstrap::getObjectManager()->get(\Magento\Framework\Acl\RootResource::class)->getId()]);
+$rules->saveRel();
 
-$userModel = $userFactory->create();
-try {
-    $userModel->setData($adminInfo);
-    $userModel->setRoleId(1);
-    $userResource->save($userModel);
-} catch (\Magento\Framework\Exception\AlreadyExistsException $e) {
-}
+/** @var User $user */
+$user = Bootstrap::getObjectManager()->create(User::class);
+$user->setFirstname("John")
+    ->setLastname("Doe")
+    ->setUsername('TestAdmin1')
+    ->setPassword(\Magento\TestFramework\Bootstrap::ADMIN_PASSWORD)
+    ->setEmail('[email protected]')
+    ->setIsActive(1)
+    ->setRoleId($role->getId());
+$user->save();

dev/tests/integration/testsuite/Magento/LoginAsCustomer/_files/admin_rollback.php

@@ -3,15 +3,26 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-use Magento\User\Model\UserFactory;
 
-$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+declare(strict_types=1);
 
-/** @var UserFactory $userFactory */
-$userFactory = $objectManager->get(UserFactory::class);
+use Magento\Authorization\Model\RoleFactory;
+use Magento\Authorization\Model\Role;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\User\Model\User;
+use Magento\Authorization\Model\RulesFactory;
+use Magento\Authorization\Model\Rules;
 
-$userModel = $userFactory->create();
-$userModel->loadByUsername('TestAdmin1');
-if ($userModel->getId()) {
-    $userModel->delete();
-}
+//Deleting the user and the role.
+/** @var User $user */
+$user = Bootstrap::getObjectManager()->create(User::class);
+$user->load('TestAdmin1', 'username');
+$user->delete();
+/** @var Role $role */
+$role = Bootstrap::getObjectManager()->get(RoleFactory::class)->create();
+$role->load('test_custom_role', 'role_name');
+/** @var Rules $rules */
+$rules = Bootstrap::getObjectManager()->get(RulesFactory::class)->create();
+$rules->load($role->getId(), 'role_id');
+$rules->delete();
+$role->delete();