ACP2E-1066: Credit memo not genrated if order configrable product with decimal quantity

devarul · devarul · commit 5e99d0cb1568 · 2022-08-08T17:34:09.000+05:30
- Fixed the issue.
diff --git a/app/code/Magento/Sales/Model/Order/CreditmemoFactory.php b/app/code/Magento/Sales/Model/Order/CreditmemoFactory.php
@@ -230,10 +230,10 @@ protected function initData($creditmemo, $data)
      * Calculate product options.
      *
      * @param Item $orderItem
-     * @param int $parentQty
-     * @return int
+     * @param int|float $parentQty
+     * @return int|float
      */
-    private function calculateProductOptions(Item $orderItem, int $parentQty): int
+    private function calculateProductOptions(Item $orderItem, int|float $parentQty): int|float
     {
         $qty = $parentQty;
         $productOptions = $orderItem->getProductOptions();

Original file line number	Diff line number	Diff line change
`@@ -230,10 +230,10 @@ protected function initData($creditmemo, $data)`
`230`	`230`	`* Calculate product options.`
`231`	`231`	`*`
`232`	`232`	`* @param Item $orderItem`
`233`		`- * @param int $parentQty`
`234`		`- * @return int`
	`233`	`+ * @param int\|float $parentQty`
	`234`	`+ * @return int\|float`
`235`	`235`	`*/`
`236`		`- private function calculateProductOptions(Item $orderItem, int $parentQty): int`
	`236`	`+ private function calculateProductOptions(Item $orderItem, int\|float $parentQty): int\|float`
`237`	`237`	`{`
`238`	`238`	`$qty = $parentQty;`
`239`	`239`	`$productOptions = $orderItem->getProductOptions();`