ACP2E-2756: [Cloud] Order Status changed to complete when partially refund of a partially shipped order

- when creating a credit memo, order should not be set to completed if it is still has items that haven't been shipped yet

Author: aplapana

app/code/Magento/Sales/Model/ResourceModel/Order/Handler/State.php

@@ -39,7 +39,8 @@ public function check(Order $order)
                 $order->setState(Order::STATE_CLOSED)
                     ->setStatus($order->getConfig()->getStateDefaultStatus(Order::STATE_CLOSED));
             } elseif ($currentState === Order::STATE_PROCESSING
-                && (!$order->canShip() || $this->isPartiallyRefundedOrderShipped($order))
+                && (!$order->canShip() ||
+                    ($this->isPartiallyRefundedOrderShipped($order) && !$this->hasPendingShipmentItems($order)))
             ) {
                 $order->setState(Order::STATE_COMPLETE)
                     ->setStatus($order->getConfig()->getStateDefaultStatus(Order::STATE_COMPLETE));
@@ -58,6 +59,7 @@ public function check(Order $order)
      */
     public function isPartiallyRefundedOrderShipped(Order $order): bool
     {
+        //we should also check the number of items that require shipping
         $isPartiallyRefundedOrderShipped = false;
         if ($this->getShippedItems($order) > 0
             && $order->getTotalQtyOrdered() <= $this->getRefundedItems($order) + $this->getShippedItems($order)) {
@@ -67,6 +69,23 @@ public function isPartiallyRefundedOrderShipped(Order $order): bool
         return $isPartiallyRefundedOrderShipped;
     }
 
+    /**
+     * Check if order has items that haven't been shipped yet
+     *
+     * @param Order $order
+     * @return bool
+     */
+    private function hasPendingShipmentItems(Order $order): bool
+    {
+        foreach ($order->getAllItems() as $item) {
+            if ($item->canShip()) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
     /**
      * Get all refunded items number
      *