MAGETWO-91735: Customer's store credit is not given back after Authorize.net failed payment

- Change order cancellation procedure during failed checkout to comply with plugin event observers
- Static tests fixes

Author: mcahriman

app/code/Magento/Authorizenet/Model/Directpost.php

@@ -372,6 +372,7 @@ public function void(\Magento\Payment\Model\InfoInterface $payment)
 
     /**
      * Refund the amount
+     *
      * Need to decode last 4 digits for request.
      *
      * @param \Magento\Framework\DataObject|\Magento\Payment\Model\InfoInterface $payment
@@ -682,6 +683,7 @@ protected function matchAmount($amount)
 
     /**
      * Operate with order using information from Authorize.net.
+     *
      * Authorize order or authorize and capture it.
      *
      * @param \Magento\Sales\Model\Order $order
@@ -699,6 +701,7 @@ protected function processOrder(\Magento\Sales\Model\Order $order)
             //decline the order (in case of wrong response code) but don't return money to customer.
             $message = $e->getMessage();
             $this->declineOrder($order, $message, false);
+
             throw $e;
         }
 
@@ -769,7 +772,7 @@ protected function processPaymentFraudStatus(\Magento\Sales\Model\Order\Payment
     }
 
     /**
-     * Add status comment
+     * Add status comment to history
      *
      * @param \Magento\Sales\Model\Order\Payment $payment
      * @return $this
@@ -824,6 +827,7 @@ protected function declineOrder(\Magento\Sales\Model\Order $order, $message = ''
                       ->void($response);
             }
             $order->registerCancellation($message)->save();
+            $this->_eventManager->dispatch('order_cancel_after', ['order' => $order ]);
         } catch (\Exception $e) {
             //quiet decline
             $this->getPsrLogger()->critical($e);
@@ -858,7 +862,7 @@ public function getConfigInterface()
      * Getter for specified value according to set payment method code
      *
      * @param mixed $key
-     * @param null $storeId
+     * @param mixed $storeId
      * @return mixed
      */
     public function getValue($key, $storeId = null)
@@ -922,6 +926,8 @@ public function fetchTransactionInfo(\Magento\Payment\Model\InfoInterface $payme
     }
 
     /**
+     * Add status comment on update
+     *
      * @param \Magento\Sales\Model\Order\Payment $payment
      * @param \Magento\Framework\DataObject $response
      * @param string $transactionId
@@ -996,6 +1002,8 @@ protected function getTransactionResponse($transactionId)
     }
 
     /**
+     * Retrieve PSR Logger if not properly loaded via DI
+     *
      * @return \Psr\Log\LoggerInterface
      *
      * @deprecated 100.1.0
@@ -1038,7 +1046,9 @@ private function getOrderIncrementId(): string
     }
 
     /**
-     * Checks if filter action is Report Only. Transactions that trigger this filter are processed as normal,
+     * Checks if filter action is Report Only.
+     *
+     * Transactions that trigger this filter are processed as normal,
      * but are also reported in the Merchant Interface as triggering this filter.
      *
      * @param string $fdsFilterAction