MC-32657: Deliver PR

- fix static tests

Author: irenelagno

app/code/Magento/Paypal/Test/Unit/Model/Express/LocaleResolverTest.php

@@ -18,7 +18,7 @@
 class LocaleResolverTest extends \PHPUnit\Framework\TestCase
 {
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|ResolverInterface
+     * @var \PHPUnit\Framework\MockObject\MockObject|ResolverInterface
      */
     private $resolver;
 

app/code/Magento/Paypal/view/frontend/templates/express/shortcut_button.phtml

@@ -4,6 +4,7 @@
  * See COPYING.txt for license details.
  */
 
+// phpcs:disable Magento2.Templates.ThisInTemplate
 /**
  * @var \Magento\Paypal\Block\Express\InContext\SmartButton $block
  */
@@ -12,4 +13,5 @@ $widgetConfig = $this->helper(\Magento\Framework\Json\Helper\Data::class)->jsonE
     $widget['Magento_Paypal/js/in-context/product-express-checkout']
 );
 ?>
-<div data-mage-init='{"Magento_Paypal/js/in-context/product-express-checkout":<?= /* @noEscape */ $widgetConfig ?>}'></div>
+<div id ="paypal-smart-button" data-mage-init='{"Magento_Paypal/js/in-context/product-express-checkout"
+:<?= /* @noEscape */ $widgetConfig ?>}'></div>

app/code/Magento/Paypal/view/frontend/web/js/in-context/express-checkout-smart-buttons.js

@@ -43,8 +43,7 @@ define([
      * @param {Object} actions
      * @returns {Object} jQuery promise
      */
-    function performOnApprove(clientConfig, data, actions)
-    {
+    function performOnApprove(clientConfig, data, actions) {
         var params = {
             paymentToken: data.orderID,
             payerId: data.payerID,
@@ -79,22 +78,49 @@ define([
                 onInit: function (data, actions) {
                     clientConfig.rendererComponent.validate(actions);
                 },
+
+                /**
+                 * Triggers beforePayment action on PayPal buttons
+                 * @returns {Object} jQuery promise
+                 */
                 createOrder: function () {
                     return performCreateOrder(clientConfig);
                 },
+
+                /**
+                 * Triggers beforeOnAuthorize action on PayPal buttons
+                 * @param {Object} data
+                 * @param {Object} actions
+                 */
                 onApprove: function (data, actions) {
                     performOnApprove(clientConfig, data, actions);
                 },
+
+                /**
+                 * Execute logic on Paypal button click
+                 */
                 onClick: function () {
                     clientConfig.rendererComponent.validate();
                     clientConfig.rendererComponent.onClick();
                 },
+
+                /**
+                 * Process cancel action
+                 * @param {Object} data
+                 * @param {Object} actions
+                 */
                 onCancel: function (data, actions) {
                     clientConfig.rendererComponent.onCancel(data, actions);
                 },
+
+                /**
+                 * Process errors
+                 *
+                 * @param {Error} err
+                 */
                 onError: function (err) {
                     clientConfig.rendererComponent.onError(err);
-                },
+                }
             }).render(element);
         });
     };

app/code/Magento/Paypal/view/frontend/web/js/in-context/express-checkout-wrapper.js

@@ -107,8 +107,10 @@ define([
          */
         afterOnAuthorize: function (res, resolve, reject, actions) {
             $('body').trigger('processStop');
+
             if (res.success) {
                 resolve();
+
                 return actions.redirect(res.redirectUrl);
             }
 

app/code/Magento/Paypal/view/frontend/web/js/in-context/paypal-sdk.js

@@ -26,7 +26,7 @@ define([
             }
         });
 
-        if (dfd.state() !== "resolved") {
+        if (dfd.state() !== 'resolved') {
             require(['paypalSdk'], function (paypalObject) {
                 dfd.resolve(paypalObject);
             });